mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: AngeloGioacchino Del Regno  <angelogioacchino.delregno@collabora.com>
To: Yunfei Dong <yunfei.dong@mediatek.com>,
	Rob Herring <robh@kernel.org>, Chen-Yu Tsai <wenst@chromium.org>,
	Hans Verkuil <hverkuil-cisco@xs4all.nl>,
	Benjamin Gaignard <benjamin.gaignard@collabora.com>,
	Tiffany Lin <tiffany.lin@mediatek.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Hsin-Yi Wang <hsinyi@chromium.org>,
	Daniel Vetter <daniel@ffwll.ch>,
	Steve Cho <stevecho@chromium.org>,
	linux-media@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org,
	Project_Global_Chrome_Upstream_Group@mediatek.com
Subject: Re: [PATCH 2/3] media: dt-bindings: media: mediatek: vcodec: Change the max reg value to 2
Date: Wed, 9 Nov 2022 10:29:45 +0100	[thread overview]
Message-ID: <96979d33-829a-4b38-bd8e-83b7f07a7c2c@collabora.com> (raw)
In-Reply-To: <20221109073529.26765-2-yunfei.dong@mediatek.com>

Il 09/11/22 08:35, Yunfei Dong ha scritto:
> Need to add racing control register base in device node for mt8195 support
> inner racing mode. Changing the max reg value from 1 to 2.
> 
> Signed-off-by: Yunfei Dong <yunfei.dong@mediatek.com>
> ---
>   .../bindings/media/mediatek,vcodec-subdev-decoder.yaml          | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/media/mediatek,vcodec-subdev-decoder.yaml b/Documentation/devicetree/bindings/media/mediatek,vcodec-subdev-decoder.yaml
> index 794012853834..1697feb1f854 100644
> --- a/Documentation/devicetree/bindings/media/mediatek,vcodec-subdev-decoder.yaml
> +++ b/Documentation/devicetree/bindings/media/mediatek,vcodec-subdev-decoder.yaml
> @@ -61,7 +61,7 @@ properties:
>         - mediatek,mt8195-vcodec-dec
>   
>     reg:
> -    maxItems: 1
> +    maxItems: 2

What about doing, instead...

- description: VDEC_SYS register space
- description: VDEC_RACING_CTRL register space

then, setting `minItems: 1` will make the racing_ctrl iospace optional :-)

Regards,
Angelo


  reply	other threads:[~2022-11-09  9:29 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-09  7:35 [PATCH 1/3] media: dt-bindings: media: mediatek: vcodec: Fix clock num not correctly Yunfei Dong
2022-11-09  7:35 ` [PATCH 2/3] media: dt-bindings: media: mediatek: vcodec: Change the max reg value to 2 Yunfei Dong
2022-11-09  9:29   ` AngeloGioacchino Del Regno [this message]
2022-11-10 10:34     ` Yunfei Dong (董云飞)
2022-11-09 12:59   ` Rob Herring
2022-11-11  1:39     ` Yunfei Dong (董云飞)
2022-11-09  7:35 ` [PATCH 3/3] arm64: dts: mt8195: Add video decoder node Yunfei Dong
2022-11-09  9:32   ` AngeloGioacchino Del Regno

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=96979d33-829a-4b38-bd8e-83b7f07a7c2c@collabora.com \
    --to=angelogioacchino.delregno@collabora.com \
    --cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
    --cc=benjamin.gaignard@collabora.com \
    --cc=daniel@ffwll.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=hsinyi@chromium.org \
    --cc=hverkuil-cisco@xs4all.nl \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=mchehab@kernel.org \
    --cc=robh@kernel.org \
    --cc=stevecho@chromium.org \
    --cc=tiffany.lin@mediatek.com \
    --cc=wenst@chromium.org \
    --cc=yunfei.dong@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®