mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Alexis Lothoré" <alexis.lothore@bootlin.com>
To: Michael Walle <mwalle@kernel.org>
Cc: Claudiu Beznea <claudiu.beznea@tuxon.dev>,
	Kalle Valo <kvalo@kernel.org>,
	linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Ajay Singh <ajay.kathat@microchip.com>,
	stable@vger.kernel.org, heiko.thiery@gmail.com
Subject: Re: [PATCH] wifi: wilc1000: use vmm_table as array in wilc struct
Date: Mon, 16 Oct 2023 08:59:22 +0200	[thread overview]
Message-ID: <969d7010-736f-46cb-98df-0a3ff6be867c@bootlin.com> (raw)
In-Reply-To: <f615b0895135489a2555d898afdcfbfa@kernel.org>

Hello Michael,

On 10/13/23 11:24, Michael Walle wrote:
>> Fixes: 40b717bfcefa ("wifi: wilc1000: fix DMA on stack objects")
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Ajay Singh <ajay.kathat@microchip.com>
>> Signed-off-by: Alexis Lothoré <alexis.lothore@bootlin.com>
> 
> Looks good to me. But you'll change the alignment of the table, not sure
> if that matters for some DMA controllers.

Thanks for the review.
Indeed, I may have overlooked that point. I am not sure either how much of an
issue it could be, but checking back the driver history on lore, I see that it
has already been mentioned, so let's be safe and keep a dedicated kzalloc for
vmm_table to make sure its address is safe to use with DMA.
I will send the corresponding v2.

Thanks,
Alexis

> 
> -michael

-- 
Alexis Lothoré, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com


      reply	other threads:[~2023-10-16  6:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-13  8:26 Alexis Lothoré
2023-10-13  9:24 ` Michael Walle
2023-10-16  6:59   ` Alexis Lothoré [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=969d7010-736f-46cb-98df-0a3ff6be867c@bootlin.com \
    --to=alexis.lothore@bootlin.com \
    --cc=ajay.kathat@microchip.com \
    --cc=claudiu.beznea@tuxon.dev \
    --cc=heiko.thiery@gmail.com \
    --cc=kvalo@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=mwalle@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®