From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752370AbeC1Gle (ORCPT ); Wed, 28 Mar 2018 02:41:34 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:56444 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750703AbeC1Glc (ORCPT ); Wed, 28 Mar 2018 02:41:32 -0400 Subject: Re: [RFC v2 01/12] KVM: arm/arm64: Set dist->spis to NULL after kfree To: Marc Zyngier , eric.auger.pro@gmail.com, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu, cdall@kernel.org, peter.maydell@linaro.org References: <1522159456-10419-1-git-send-email-eric.auger@redhat.com> <1522159456-10419-2-git-send-email-eric.auger@redhat.com> <26bb42a7-d946-e52c-68e6-eaeaae325983@arm.com> Cc: andre.przywara@arm.com, drjones@redhat.com, wei@redhat.com From: Auger Eric Message-ID: <969f4dcb-5f77-ddbe-7e72-322793065ccd@redhat.com> Date: Wed, 28 Mar 2018 08:41:26 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <26bb42a7-d946-e52c-68e6-eaeaae325983@arm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Marc, On 27/03/18 19:10, Marc Zyngier wrote: > On 27/03/18 15:04, Eric Auger wrote: >> in case kvm_vgic_map_resources() fails, typically if the vgic >> distributor is not defined, __kvm_vgic_destroy will be called >> several times. Indeed kvm_vgic_map_resources() is called on >> first vcpu run. As a result dist->spis is freeed more than once >> and on the second time it causes a "kernel BUG at mm/slub.c:3912!" >> >> Set dist->spis to NULL to avoid the crash. >> >> Signed-off-by: Eric Auger > > Fixes: ad275b8bb1e6 ("KVM: arm/arm64: vgic-new: vgic_init: implement > vgic_init") Sorry for the oversight :-( > > Reviewed-by: Marc Zyngier Thanks Eric > > M. >