Re: [PATCH 1/1] linux/io.h: Add cleanup defination for iounmap() and memunmap()

["Arnd Bergmann" <arnd@arndb.de>]

On Thu, Aug 1, 2024, at 01:31, Frank Li wrote:
> Add DEFINE_FREE for iounmap() and memunmap() to support scope based
> cleanup.
>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
>  include/linux/io.h | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/include/linux/io.h b/include/linux/io.h
> index 59ec5eea696c4..7695d7973c8ff 100644
> --- a/include/linux/io.h
> +++ b/include/linux/io.h
> @@ -163,6 +163,9 @@ enum {
>  void *memremap(resource_size_t offset, size_t size, unsigned long flags);
>  void memunmap(void *addr);
> 
> +DEFINE_FREE(iounmap, void __iomem *, if (!IS_ERR_OR_NULL(_T)) iounmap(_T))
> +DEFINE_FREE(memunmap, void *, if (!IS_ERR_OR_NULL(_T)) memunmap(_T))

I don't like the use of IS_ERR_OR_NULL(), which tends
to indicate a problem in the interface design.

In which cases do you expect to need scope based cleanup
on an error pointer here? The only interfaces I see that
returns an __iomem error pointer are the devm_* ones, but
those have their own cleanup method.

    Arnd