From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 167A7EB64DC for ; Tue, 11 Jul 2023 12:11:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229801AbjGKMLF (ORCPT ); Tue, 11 Jul 2023 08:11:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47230 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229871AbjGKMLB (ORCPT ); Tue, 11 Jul 2023 08:11:01 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 287821986; Tue, 11 Jul 2023 05:10:39 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E03312B; Tue, 11 Jul 2023 05:10:59 -0700 (PDT) Received: from [10.163.47.87] (unknown [10.163.47.87]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BCBA33F67D; Tue, 11 Jul 2023 05:10:11 -0700 (PDT) Message-ID: <96a3d12a-71d8-1779-28a3-316e1838292e@arm.com> Date: Tue, 11 Jul 2023 17:40:09 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH 4/4] perf: Remove unused PERF_PMU_CAP_HETEROGENEOUS_CPUS capability Content-Language: en-US To: James Clark , linux-perf-users@vger.kernel.org, irogers@google.com Cc: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Adrian Hunter , Thomas Gleixner , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Will Deacon , Kan Liang , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20230710122138.1450930-1-james.clark@arm.com> <20230710122138.1450930-5-james.clark@arm.com> From: Anshuman Khandual In-Reply-To: <20230710122138.1450930-5-james.clark@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/10/23 17:51, James Clark wrote: > Since commit bd2756811766 ("perf: Rewrite core context handling") the > relationship between perf_event_context and PMUs has changed so that > the error scenario that PERF_PMU_CAP_HETEROGENEOUS_CPUS originally > silenced no longer exists. > > Remove the capability to avoid confusion that it actually influences > any perf core behavior. This change should be a no-op. > > Signed-off-by: James Clark > --- > include/linux/perf_event.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h > index d5628a7b5eaa..3f4d941fd6c5 100644 > --- a/include/linux/perf_event.h > +++ b/include/linux/perf_event.h > @@ -288,7 +288,7 @@ struct perf_event_pmu_context; > #define PERF_PMU_CAP_EXTENDED_REGS 0x0008 > #define PERF_PMU_CAP_EXCLUSIVE 0x0010 > #define PERF_PMU_CAP_ITRACE 0x0020 > -#define PERF_PMU_CAP_HETEROGENEOUS_CPUS 0x0040 > +/* Unused 0x0040 */ Small nit, "Unused" marking might not be required here. > #define PERF_PMU_CAP_NO_EXCLUDE 0x0080 > #define PERF_PMU_CAP_AUX_OUTPUT 0x0100 > #define PERF_PMU_CAP_EXTENDED_HW_TYPE 0x0200