From: Jesse Brandeburg <jesse.brandeburg@intel.com>
To: Haiyang Zhang <haiyangz@microsoft.com>,
<linux-hyperv@vger.kernel.org>, <netdev@vger.kernel.org>
Cc: <decui@microsoft.com>, <kys@microsoft.com>,
<paulros@microsoft.com>, <olaf@aepfle.de>, <vkuznets@redhat.com>,
<davem@davemloft.net>, <wei.liu@kernel.org>,
<edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
<leon@kernel.org>, <longli@microsoft.com>,
<ssengar@linux.microsoft.com>, <linux-rdma@vger.kernel.org>,
<daniel@iogearbox.net>, <john.fastabend@gmail.com>,
<bpf@vger.kernel.org>, <ast@kernel.org>,
<sharmaajay@microsoft.com>, <hawk@kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2,net-next, 2/3] net: mana: Enable RX path to handle various MTU sizes
Date: Tue, 11 Apr 2023 08:06:31 -0700 [thread overview]
Message-ID: <96ad9a58-00c8-1bb3-06d6-841e7ea41488@intel.com> (raw)
In-Reply-To: <1680901196-20643-3-git-send-email-haiyangz@microsoft.com>
On 4/7/2023 1:59 PM, Haiyang Zhang wrote:
> Update RX data path to allocate and use RX queue DMA buffers with
> proper size based on potentially various MTU sizes.
>
> Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
>
> ---
> V2:
> Refectored to multiple patches for readability. Suggested by Yunsheng Lin.
Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
One tiny nit below, but not worth a respin.
> @@ -1764,6 +1798,7 @@ static struct mana_rxq *mana_create_rxq(struct mana_port_context *apc,
> struct mana_obj_spec wq_spec;
> struct mana_obj_spec cq_spec;
> struct gdma_queue_spec spec;
> + unsigned int mtu = ndev->mtu;
This one isn't quite RCT order. I'd only change it if you have another
respin for some reason.
Ha, I see you remove that line in the next patch, never mind...
next prev parent reply other threads:[~2023-04-11 15:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-07 20:59 [PATCH V2,net-next, 0/3] net: mana: Add support for jumbo frame Haiyang Zhang
2023-04-07 20:59 ` [PATCH V2,net-next, 1/3] net: mana: Use napi_build_skb in RX path Haiyang Zhang
2023-04-11 15:06 ` Jesse Brandeburg
2023-04-07 20:59 ` [PATCH V2,net-next, 2/3] net: mana: Enable RX path to handle various MTU sizes Haiyang Zhang
2023-04-11 15:06 ` Jesse Brandeburg [this message]
2023-04-11 23:10 ` Jacob Keller
2023-04-12 14:38 ` Haiyang Zhang
2023-04-07 20:59 ` [PATCH V2,net-next, 3/3] net: mana: Add support for jumbo frame Haiyang Zhang
2023-04-11 15:06 ` Jesse Brandeburg
2023-04-11 23:12 ` Jacob Keller
2023-04-12 14:36 ` Haiyang Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=96ad9a58-00c8-1bb3-06d6-841e7ea41488@intel.com \
--to=jesse.brandeburg@intel.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=decui@microsoft.com \
--cc=edumazet@google.com \
--cc=haiyangz@microsoft.com \
--cc=hawk@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=kys@microsoft.com \
--cc=leon@kernel.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=longli@microsoft.com \
--cc=netdev@vger.kernel.org \
--cc=olaf@aepfle.de \
--cc=pabeni@redhat.com \
--cc=paulros@microsoft.com \
--cc=sharmaajay@microsoft.com \
--cc=ssengar@linux.microsoft.com \
--cc=vkuznets@redhat.com \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®