mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bryan O'Donoghue <bod@kernel.org>
To: emcp@enser.io, Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
	Loic Poulain <loic.poulain@oss.qualcomm.com>
Cc: Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Robert Foss <rfoss@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Abel Vesa <abelvesa@kernel.org>,
	linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: media: qcom,sdm845-camss: Add interconnects
Date: Sun, 22 Nov 2026 12:15:31 +0000	[thread overview]
Message-ID: <96aff3fb-7a7a-4922-a18b-fa44f67d3655@kernel.org> (raw)
In-Reply-To: <20261122-b4-camss-sdm845-icc-v1-1-0671ef770fd0@enser.io>

On 22/11/2026 05:13, EMCP333 via B4 Relay wrote:
> From: EMCP333 <emcp@enser.io>
> 
> CAMSS on SDM845 reaches DDR through two camnoc HF ports and one SF
> port, and its registers through the config NoC. Describe the four
> paths, named as in the sm6150 binding, which has the same two HF ports.
> 
> They are optional, so existing device trees stay valid. The driver
> votes on them where they are present.
> 
> The code and this changelog were prepared with the help of an AI coding
> assistant. The submitter has reviewed both and takes responsibility for
> them.


> 
> Signed-off-by: EMCP333 <emcp@enser.io>
> ---
>   .../devicetree/bindings/media/qcom,sdm845-camss.yaml | 20 ++++++++++++++++++++
>   1 file changed, 20 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml
> index be09cf3a3b..8c87ecd406 100644
> --- a/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml
> +++ b/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml
> @@ -76,6 +76,16 @@ properties:
>         - const: vfe1
>         - const: vfe_lite
> 
> +  interconnects:
> +    maxItems: 4
> +
> +  interconnect-names:
> +    items:
> +      - const: ahb
> +      - const: hf_0
> +      - const: hf_1
> +      - const: sf_mnoc
> +
>     iommus:
>       maxItems: 4
> 
> @@ -233,6 +243,7 @@ examples:
>       #include <dt-bindings/interrupt-controller/arm-gic.h>
>       #include <dt-bindings/clock/qcom,camcc-sdm845.h>
>       #include <dt-bindings/clock/qcom,gcc-sdm845.h>
> +    #include <dt-bindings/interconnect/qcom,sdm845.h>
> 
>       soc {
>         #address-cells = <2>;
> @@ -337,6 +348,15 @@ examples:
>             "vfe1",
>             "vfe_lite";
> 
> +        interconnects = <&gladiator_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_CAMERA_CFG 0>,
> +          <&mmss_noc MASTER_CAMNOC_HF0 0 &mem_noc SLAVE_EBI1 0>,
> +          <&mmss_noc MASTER_CAMNOC_HF1 0 &mem_noc SLAVE_EBI1 0>,
> +          <&mmss_noc MASTER_CAMNOC_SF 0 &mem_noc SLAVE_EBI1 0>;

Ah come on. "The LLM made this and I reviewed it" but this is what 
sm6150 upstream looks like:


             interconnects = <&gem_noc MASTER_APPSS_PROC 
QCOM_ICC_TAG_ACTIVE_ONLY
                              &config_noc SLAVE_CAMERA_CFG 
QCOM_ICC_TAG_ACTIVE_ONLY>,
                             <&mmss_noc MASTER_CAMNOC_HF0 
QCOM_ICC_TAG_ALWAYS
                              &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>,
                             <&mmss_noc MASTER_CAMNOC_HF1 
QCOM_ICC_TAG_ALWAYS
                              &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>,
                             <&mmss_noc MASTER_CAMNOC_SF QCOM_ICC_TAG_ALWAYS
                              &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>;
             interconnect-names = "ahb",
                                  "hf_0",
                                  "hf_1",
                                  "sf_mnoc";

Please _actually_ review it, the patchlog even calls out the source yaml 
used as reference.

> +        interconnect-names = "ahb",
> +          "hf_0",
> +          "hf_1",
> +          "sf_mnoc";
> +
>           iommus = <&apps_smmu 0x0808 0x0>,
>             <&apps_smmu 0x0810 0x8>,
>             <&apps_smmu 0x0c08 0x0>,
> 
> --
> 2.47.3


  reply	other threads:[~2026-11-22 12:15 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-22  5:13 [PATCH 0/3] media: qcom: camss: Interconnect votes for SDM845 EMCP333 via B4 Relay
2026-11-22  5:13 ` [PATCH 1/3] dt-bindings: media: qcom,sdm845-camss: Add interconnects EMCP333 via B4 Relay
2026-11-22 12:15   ` Bryan O'Donoghue [this message]
2026-11-22  5:13 ` [PATCH 2/3] media: qcom: camss: Vote interconnect bandwidth on SDM845 EMCP333 via B4 Relay
2026-11-22  5:13 ` [PATCH 3/3] arm64: dts: qcom: sdm845: Add CAMSS interconnects EMCP333 via B4 Relay
2026-11-22 12:31   ` Bryan O'Donoghue

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=96aff3fb-7a7a-4922-a18b-fa44f67d3655@kernel.org \
    --to=bod@kernel.org \
    --cc=abelvesa@kernel.org \
    --cc=andersson@kernel.org \
    --cc=bryan.odonoghue@linaro.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=emcp@enser.io \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=loic.poulain@oss.qualcomm.com \
    --cc=mchehab@kernel.org \
    --cc=rfoss@kernel.org \
    --cc=robh@kernel.org \
    --cc=vladimir.zapolskiy@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®