From: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
To: "Kory Maincent (TI.com)" <kory.maincent@bootlin.com>
Cc: Markus Schneider-Pargmann <msp@baylibre.com>,
Luca Ceresoli <luca.ceresoli@bootlin.com>,
Louis Chauvet <louis.chauvet@bootlin.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Miguel Gazquez <miguel.gazquez@bootlin.com>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
Jyri Sarha <jyri.sarha@iki.fi>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Russell King <linux@armlinux.org.uk>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Tony Lindgren <tony@atomide.com>,
Andrzej Hajda <andrzej.hajda@intel.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Robert Foss <rfoss@kernel.org>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Jonas Karlman <jonas@kwiboo.se>,
Jernej Skrabec <jernej.skrabec@gmail.com>
Subject: Re: [PATCH 05/21] ARM: dts: omap: Bind panel to panel-dpi instead of ti,tilcdc,panel driver
Date: Mon, 1 Dec 2025 16:13:16 +0200 [thread overview]
Message-ID: <96b1b7bf-ddbe-4213-a201-dc89cf2998dd@ideasonboard.com> (raw)
In-Reply-To: <20251126-feature_tilcdc-v1-5-49b9ef2e3aa0@bootlin.com>
Hi Kory,
On 26/11/2025 19:35, Kory Maincent (TI.com) wrote:
> Use panel-dpi driver instead of the deprecated tilcdc-panel driver in
> preparation for removing the tilcdc-panel driver and binding.
>
> Signed-off-by: Kory Maincent (TI.com) <kory.maincent@bootlin.com>
> ---
>
> This patch is not tested. It would be nice if someone with one of this
> board could test and validate it.
> ---
> arch/arm/boot/dts/ti/davinci/da850-evm.dts | 26 +++++++++++++-------------
> arch/arm/boot/dts/ti/omap/am335x-guardian.dts | 25 +++++++++----------------
> arch/arm/boot/dts/ti/omap/am335x-pdu001.dts | 21 ++++++++++-----------
> arch/arm/boot/dts/ti/omap/am335x-pepper.dts | 22 +++++++++++-----------
> arch/arm/boot/dts/ti/omap/am335x-sbc-t335.dts | 25 +++++++++++++------------
> arch/arm/boot/dts/ti/omap/am335x-sl50.dts | 25 ++++++++++++-------------
> 6 files changed, 68 insertions(+), 76 deletions(-)
>
Doesn't this, or rather the following patches, break DTB compatibility
with all the above boards?
Tomi
> diff --git a/arch/arm/boot/dts/ti/davinci/da850-evm.dts b/arch/arm/boot/dts/ti/davinci/da850-evm.dts
> index 38a191fb04149..79cca1f6205ef 100644
> --- a/arch/arm/boot/dts/ti/davinci/da850-evm.dts
> +++ b/arch/arm/boot/dts/ti/davinci/da850-evm.dts
> @@ -40,7 +40,7 @@ backlight: backlight-pwm {
> };
>
> panel {
> - compatible = "ti,tilcdc,panel";
> + compatible = "panel-dpi";
> pinctrl-names = "default";
> pinctrl-0 = <&lcd_pins>;
> /*
> @@ -50,17 +50,10 @@ panel {
> */
> status = "okay";
> enable-gpios = <&gpio 40 GPIO_ACTIVE_HIGH>; /* lcd_panel_pwr */
> -
> - panel-info {
> - ac-bias = <255>;
> - ac-bias-intrpt = <0>;
> - dma-burst-sz = <16>;
> - bpp = <16>;
> - fdd = <0x80>;
> - sync-edge = <0>;
> - sync-ctrl = <1>;
> - raster-order = <0>;
> - fifo-th = <1>;
> + port {
> + panel_in: endpoint {
> + remote-endpoint = <&lcdc_out>;
> + };
> };
>
> display-timings {
> @@ -222,6 +215,13 @@ &rtc0 {
> };
>
> &lcdc {
> + fifo-threshold = <16>;
> +
> + port {
> + lcdc_out: endpoint {
> + remote-endpoint = <&panel_in>;
> + };
> + };
> status = "okay";
> };
>
> @@ -459,7 +459,7 @@ &vpif {
> pinctrl-0 = <&vpif_capture_pins>, <&vpif_display_pins>;
> /*
> * The vpif and the LCD are mutually exclusive.
> - * To enable VPIF, disable the ti,tilcdc,panel then
> + * To enable VPIF, disable the panel-dpi then
> * change the status below to 'okay'
> */
> status = "disabled";
> diff --git a/arch/arm/boot/dts/ti/omap/am335x-guardian.dts b/arch/arm/boot/dts/ti/omap/am335x-guardian.dts
> index 4b070e634b281..f38ce9be2c106 100644
> --- a/arch/arm/boot/dts/ti/omap/am335x-guardian.dts
> +++ b/arch/arm/boot/dts/ti/omap/am335x-guardian.dts
> @@ -68,10 +68,15 @@ gpio-poweroff {
> };
>
> panel {
> - compatible = "ti,tilcdc,panel";
> + compatible = "panel-dpi";
> pinctrl-names = "default", "sleep";
> pinctrl-0 = <&lcd_pins_default &lcd_disen_pins>;
> pinctrl-1 = <&lcd_pins_sleep>;
> + port {
> + panel_in: endpoint {
> + remote-endpoint = <&lcdc_out>;
> + };
> + };
>
> display-timings {
> timing-320x240 {
> @@ -86,21 +91,9 @@ timing-320x240 {
> clock-frequency = <9000000>;
> hsync-active = <0>;
> vsync-active = <0>;
> + pixelclk-active = <1>;
> };
> };
> - panel-info {
> - ac-bias = <255>;
> - ac-bias-intrpt = <0>;
> - dma-burst-sz = <16>;
> - bpp = <24>;
> - bus-width = <16>;
> - fdd = <0x80>;
> - sync-edge = <0>;
> - sync-ctrl = <1>;
> - raster-order = <0>;
> - fifo-th = <0>;
> - };
> -
> };
>
> guardian_beeper: pwm-7 {
> @@ -265,8 +258,8 @@ &lcdc {
> blue-and-red-wiring = "crossed";
> status = "okay";
> port {
> - lcdc_0: endpoint@0 {
> - remote-endpoint = <0>;
> + lcdc_out: endpoint@0 {
> + remote-endpoint = <&panel_in>;
> };
> };
> };
> diff --git a/arch/arm/boot/dts/ti/omap/am335x-pdu001.dts b/arch/arm/boot/dts/ti/omap/am335x-pdu001.dts
> index c9ccb9de21ad7..2c5229d05ade7 100644
> --- a/arch/arm/boot/dts/ti/omap/am335x-pdu001.dts
> +++ b/arch/arm/boot/dts/ti/omap/am335x-pdu001.dts
> @@ -50,20 +50,14 @@ lis3_reg: fixedregulator@1 {
> };
>
> panel {
> - compatible = "ti,tilcdc,panel";
> + compatible = "panel-dpi";
> status = "okay";
> pinctrl-names = "default";
> pinctrl-0 = <&lcd_pins_s0>;
> - panel-info {
> - ac-bias = <255>;
> - ac-bias-intrpt = <0>;
> - dma-burst-sz = <16>;
> - bpp = <16>;
> - fdd = <0x80>;
> - sync-edge = <0>;
> - sync-ctrl = <1>;
> - raster-order = <0>;
> - fifo-th = <0>;
> + port {
> + panel_in: endpoint {
> + remote-endpoint = <&lcdc_out>;
> + };
> };
>
> display-timings {
> @@ -395,6 +389,11 @@ &rtc {
>
> &lcdc {
> status = "okay";
> + port {
> + lcdc_out: endpoint {
> + remote-endpoint = <&panel_in>;
> + };
> + };
> };
>
> &elm {
> diff --git a/arch/arm/boot/dts/ti/omap/am335x-pepper.dts b/arch/arm/boot/dts/ti/omap/am335x-pepper.dts
> index e7d561a527fdd..2760c0eab50c2 100644
> --- a/arch/arm/boot/dts/ti/omap/am335x-pepper.dts
> +++ b/arch/arm/boot/dts/ti/omap/am335x-pepper.dts
> @@ -31,7 +31,7 @@ leds: user-leds-pins {
> };
>
> panel: lcd_panel {
> - compatible = "ti,tilcdc,panel";
> + compatible = "panel-dpi";
> };
>
> sound: sound_iface {
> @@ -189,16 +189,10 @@ &panel {
> status = "okay";
> pinctrl-names = "default";
> pinctrl-0 = <&lcd_pins>;
> - panel-info {
> - ac-bias = <255>;
> - ac-bias-intrpt = <0>;
> - dma-burst-sz = <16>;
> - bpp = <32>;
> - fdd = <0x80>;
> - sync-edge = <0>;
> - sync-ctrl = <1>;
> - raster-order = <0>;
> - fifo-th = <0>;
> + port {
> + panel_in: endpoint {
> + remote-endpoint = <&lcdc_out>;
> + };
> };
> display-timings {
> native-mode = <&timing0>;
> @@ -214,12 +208,18 @@ timing0: timing-480x272 {
> vsync-len = <10>;
> hsync-active = <1>;
> vsync-active = <1>;
> + pixelclk-active = <1>;
> };
> };
> };
>
> &lcdc {
> status = "okay";
> + port {
> + lcdc_out: endpoint {
> + remote-endpoint = <&panel_in>;
> + };
> + };
> };
>
> &am33xx_pinmux {
> diff --git a/arch/arm/boot/dts/ti/omap/am335x-sbc-t335.dts b/arch/arm/boot/dts/ti/omap/am335x-sbc-t335.dts
> index 2841e95d9a094..25ee855dd21a7 100644
> --- a/arch/arm/boot/dts/ti/omap/am335x-sbc-t335.dts
> +++ b/arch/arm/boot/dts/ti/omap/am335x-sbc-t335.dts
> @@ -13,23 +13,17 @@ / {
>
> /* DRM display driver */
> panel {
> - compatible = "ti,tilcdc,panel";
> + compatible = "panel-dpi";
> status = "okay";
> pinctrl-names = "default", "sleep";
> pinctrl-0 = <&lcd_pins_default>;
> pinctrl-1 = <&lcd_pins_sleep>;
> -
> - panel-info {
> - ac-bias = <255>;
> - ac-bias-intrpt = <0>;
> - dma-burst-sz = <16>;
> - bpp = <32>;
> - fdd = <0x80>;
> - sync-edge = <0>;
> - sync-ctrl = <1>;
> - raster-order = <0>;
> - fifo-th = <0>;
> + port {
> + panel_in: endpoint {
> + remote-endpoint = <&lcdc_out>;
> + };
> };
> +
> display-timings {
> /* Timing selection performed by U-Boot */
> timing0: lcd {/* 800x480p62 */
> @@ -44,6 +38,7 @@ timing0: lcd {/* 800x480p62 */
> vsync-len = <2>;
> hsync-active = <1>;
> vsync-active = <1>;
> + pixelclk-active = <1>;
> };
> timing1: dvi { /* 1024x768p60 */
> clock-frequency = <65000000>;
> @@ -57,6 +52,7 @@ timing1: dvi { /* 1024x768p60 */
> vsync-len = <6>;
> hsync-active = <0>;
> vsync-active = <0>;
> + pixelclk-active = <1>;
> };
> };
> };
> @@ -173,4 +169,9 @@ lcd-ena-hog {
> /* Display */
> &lcdc {
> status = "okay";
> + port {
> + lcdc_out: endpoint {
> + remote-endpoint = <&panel_in>;
> + };
> + };
> };
> diff --git a/arch/arm/boot/dts/ti/omap/am335x-sl50.dts b/arch/arm/boot/dts/ti/omap/am335x-sl50.dts
> index f3524e5ee43e2..b4b2b6d18d646 100644
> --- a/arch/arm/boot/dts/ti/omap/am335x-sl50.dts
> +++ b/arch/arm/boot/dts/ti/omap/am335x-sl50.dts
> @@ -123,22 +123,14 @@ audio_mclk: audio_mclk_gate@0 {
> };
>
> panel: lcd_panel {
> - compatible = "ti,tilcdc,panel";
> + compatible = "panel-dpi";
> pinctrl-names = "default";
> pinctrl-0 = <&lcd_pins>;
>
> - panel-info {
> - ac-bias = <255>;
> - ac-bias-intrpt = <0>;
> - dma-burst-sz = <16>;
> - bpp = <16>;
> - fdd = <0x80>;
> - tft-alt-mode = <0>;
> - mono-8bit-mode = <0>;
> - sync-edge = <0>;
> - sync-ctrl = <1>;
> - raster-order = <0>;
> - fifo-th = <0>;
> + port {
> + panel_in: endpoint {
> + remote-endpoint = <&lcdc_out>;
> + };
> };
>
> display-timings {
> @@ -157,6 +149,8 @@ timing0: 960x128 {
> vfront-porch = <8>;
> vsync-len = <4>;
> vsync-active = <0>;
> +
> + pixelclk-active = <1>;
> };
> };
> };
> @@ -711,6 +705,11 @@ &ehrpwm1 {
>
> &lcdc {
> status = "okay";
> + port {
> + lcdc_out: endpoint {
> + remote-endpoint = <&panel_in>;
> + };
> + };
> };
>
> &tscadc {
>
next prev parent reply other threads:[~2025-12-01 14:13 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-26 17:35 [PATCH 00/21] Clean and update tilcdc driver to support DRM_BRIDGE_ATTACH_NO_CONNECTOR Kory Maincent (TI.com)
2025-11-26 17:35 ` [PATCH 01/21] dt-bindings: display: tilcdc: Convert to DT schema Kory Maincent (TI.com)
2025-11-26 17:35 ` [PATCH 02/21] dt-bindings: display: tilcdc: Add fifo-threshold property Kory Maincent (TI.com)
2025-11-27 8:22 ` Krzysztof Kozlowski
2025-11-27 9:37 ` Kory Maincent
2025-11-26 17:35 ` [PATCH 03/21] drm/tilcdc: Remove simulate_vesa_sync flag Kory Maincent (TI.com)
2025-12-10 18:10 ` Luca Ceresoli
2025-12-11 9:40 ` Kory Maincent
2025-12-11 9:47 ` Luca Ceresoli
2025-11-26 17:35 ` [PATCH 04/21] drm/tilcdc: Add support for DRM bus flags and simplify panel config Kory Maincent (TI.com)
2025-12-10 18:13 ` Luca Ceresoli
2025-11-26 17:35 ` [PATCH 05/21] ARM: dts: omap: Bind panel to panel-dpi instead of ti,tilcdc,panel driver Kory Maincent (TI.com)
2025-12-01 14:13 ` Tomi Valkeinen [this message]
2025-12-01 21:46 ` Krzysztof Kozlowski
2025-12-02 9:42 ` Kory Maincent
2025-12-02 10:28 ` Krzysztof Kozlowski
2025-12-02 10:44 ` Kory Maincent
2025-12-02 10:47 ` Krzysztof Kozlowski
2025-12-02 11:18 ` Kory Maincent
2025-12-02 11:51 ` Tomi Valkeinen
2025-12-02 12:20 ` Krzysztof Kozlowski
2025-12-02 12:56 ` Kory Maincent
2025-12-03 8:30 ` Krzysztof Kozlowski
2025-12-02 12:19 ` Krzysztof Kozlowski
2025-11-26 17:35 ` [PATCH 06/21] dt-bindings: display: tilcdc: Remove panel binding Kory Maincent (TI.com)
2025-11-26 17:35 ` [PATCH 07/21] drm/tilcdc: Remove tilcdc panel driver Kory Maincent (TI.com)
2025-11-26 17:35 ` [PATCH 08/21] drm/tilcdc: Remove component framework support Kory Maincent (TI.com)
2025-12-11 9:42 ` Luca Ceresoli
2025-11-26 17:35 ` [PATCH 09/21] drm/tilcdc: Remove tilcdc_panel_info structure Kory Maincent (TI.com)
2025-12-11 9:44 ` Luca Ceresoli
2025-11-26 17:35 ` [PATCH 10/21] drm/tilcdc: Remove redundant #endif/#ifdef in debugfs code Kory Maincent (TI.com)
2025-12-10 18:22 ` Luca Ceresoli
2025-11-26 17:35 ` [PATCH 11/21] drm/tilcdc: Remove unused encoder and connector tracking arrays Kory Maincent (TI.com)
2025-11-26 17:35 ` [PATCH 12/21] drm/tilcdc: Rename external_encoder and external_connector to encoder and connector Kory Maincent (TI.com)
2025-11-26 17:35 ` [PATCH 13/21] drm/tilcdc: Rename tilcdc_external to tilcdc_encoder Kory Maincent (TI.com)
2025-11-26 17:35 ` [PATCH 14/21] drm/tilcdc: Remove the useless module list support Kory Maincent (TI.com)
2025-11-26 17:35 ` [PATCH 15/21] drm/tilcdc: Modernize driver initialization and cleanup paths Kory Maincent (TI.com)
2025-11-26 17:35 ` [PATCH 16/21] drm/tilcdc: Remove the use of drm_device private_data Kory Maincent (TI.com)
2025-11-26 17:35 ` [PATCH 17/21] drm/bridge: tda998x: Remove component support Kory Maincent (TI.com)
2025-11-26 17:36 ` [PATCH 18/21] drm/bridge: tda998x: Move tda998x_create/destroy into probe and remove Kory Maincent (TI.com)
2025-11-26 17:36 ` [PATCH 19/21] drm/bridge: tda998x: Remove useless tda998x_connector_destroy wrapper Kory Maincent (TI.com)
2025-11-26 17:36 ` [PATCH 20/21] drm/bridge: tda998x: Add support for DRM_BRIDGE_ATTACH_NO_CONNECTOR Kory Maincent (TI.com)
2025-11-26 17:36 ` [PATCH 21/21] drm/tilcdc: " Kory Maincent (TI.com)
2025-12-02 12:25 ` [PATCH 00/21] Clean and update tilcdc driver to support DRM_BRIDGE_ATTACH_NO_CONNECTOR Swamil Jain
2025-12-03 10:49 ` Kory Maincent
2025-12-03 12:13 ` Swamil Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=96b1b7bf-ddbe-4213-a201-dc89cf2998dd@ideasonboard.com \
--to=tomi.valkeinen@ideasonboard.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@gmail.com \
--cc=andrzej.hajda@intel.com \
--cc=brgl@bgdev.pl \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=jyri.sarha@iki.fi \
--cc=kory.maincent@bootlin.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=louis.chauvet@bootlin.com \
--cc=luca.ceresoli@bootlin.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=miguel.gazquez@bootlin.com \
--cc=mripard@kernel.org \
--cc=msp@baylibre.com \
--cc=neil.armstrong@linaro.org \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
--cc=simona@ffwll.ch \
--cc=thomas.petazzoni@bootlin.com \
--cc=tony@atomide.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®