From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752301AbdDNHdt (ORCPT ); Fri, 14 Apr 2017 03:33:49 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:51327 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752043AbdDNHdq (ORCPT ); Fri, 14 Apr 2017 03:33:46 -0400 X-AuditID: cbfec7f1-f796e6d00000116b-9e-58f07b51c340 Subject: Re: [PATCH 1/3] dt-bindings: Add support for samsung s6e3ha2 edge panel binding To: Hoegeun Kwon , thierry.reding@gmail.com, airlied@linux.ie, robh+dt@kernel.org, mark.rutland@arm.com, catalin.marinas@arm.com, will.deacon@arm.com, kgene@kernel.org, krzk@kernel.org Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, javier@osg.samsung.com, andi.shyti@samsung.com From: Andrzej Hajda Message-id: <96b2c957-35f3-ae73-1c92-d46fc81e2d16@samsung.com> Date: Fri, 14 Apr 2017 09:33:35 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-version: 1.0 In-reply-to: <1492147179-7824-2-git-send-email-hoegeun.kwon@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA01SWUwTURTN6yydVitjQb3BCkmjJhBFXD6e4pqIGX5U/DDVD6TCBIxlsRUj GiMqbq0WIyrYEKyArYGamkKoojZY0CIKpS5QTRQJlQhIyqbRDxfo1IS/c8859917bh5DyN9S 0cyB3MO8NletUdJSsvH5L+/y1OOjqkSveTG+3PlChJ2tAxQOWi4hfKu1k8JvvwdpHLTqafxt xCbCJf3DBPZ674uxo7+bwm+aKmhc7nWJ8J0enwiffdIqxr+aKkk8ONZGbmY5W6UNcQ9NH8Wc o/YizTl/fKa4XoNHxNXXnOQaSqZ4Y0Mt4iYcMTsle6XrM3nNgSO8dsXGdGl2p9VH5t9mj3pO +6kiVCnTIwkD7Bp496RCLOD50PXJTuuRlJGzdxC4a1zhYgJBwHmK/t/Rbz6HBMGCoKr3a9g1 gKDxegcx7Ypk98KEvTokRLF+BFb7cKgg2A8IjGeuhlw0Gwe/69+H3pWxG6Gl7nWIJ9klMBQw ktN4HquCnooGJHjmws/STyFewnJg/fsstDnBJkL5tRaRgGOh3jZCCLteZMBUvU2PmCm8CBzN YXorPK0zhENHwpCnIYwV8KbUQE7vCawBwXhJm1goriH4M1oe7k6CFo+PEobNgauNZYQwQAYX zskFCwfFfmf4XlsgMGwJn+g9gi+uG+gKijXNyGOakcE0I4MZEbUoii/Q5WTxulUJOnWOriA3 KyEjL8eBpv7ayz+esQco2LbOjVgGKWfLVCeCKjmlPqIrzHEjYAhllMx6aFQll2WqC4/x2rx9 2gINr3OjhQypXCCTtner5GyW+jB/kOfzee1/VcRIoouQ0buF05xfdhfvjo5v7wq80pzZ0eoZ Ho9ITv5e6nu1oW/D2Q9dSHwzzeXyrU2vGlROStstlqTmYkWi0t0Rk71++64LKY+NPVzBckod mbK/mhPp0+6N/+RSkvtm7Skq60ePFN0jnakZccXpMXa/OW6Tgi5rXPpxdV1HhEK6dfKYktRl q1fGE1qd+h+rZ8U3ZwMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrIIsWRmVeSWpSXmKPExsVy+t/xy7rp1R8iDBo+q1n0njvJZLH9yDNW i/fLehgt5h85x2px5et7Nov3y7vYLN68XcNk0f/4NbPF+fMb2C02Pb7GanF51xw2ixnn9zFZ LL1+kcmide8Rdoufu+axWLz8eILFQcBjzbw1jB47Z91l99i0qpPNY/u3B6we97uPM3lsXlLv saUfKN63ZRWjx+dNcgGcUW42GamJKalFCql5yfkpmXnptkqhIW66FkoKeYm5qbZKEbq+IUFK CmWJOaVAnpEBGnBwDnAPVtK3S3DLOLf8IkvBQoGK4003WBsY5/F2MXJySAiYSDxe0MYIYYtJ XLi3nq2LkYtDSGAJo8SHfwdYQRJCAs8YJf4fYQKxhQWiJD6vXwxWJCJwjVFi1qoFjBAdNxkl Xh1qBHOYBW4xSnxtX84M0sImoCnxd/NNNhCbV8BO4vDqS2BxFgFViVdP+lhAbFGBCImHnbvY IWoEJX5MvgcW5xTwkFj+/yhQnANoqJ7E/YtaIGFmAXmJzWveMk9gFJiFpGMWQtUsJFULGJlX MYqklhbnpucWG+kVJ+YWl+al6yXn525iBEb3tmM/t+xg7HoXfIhRgINRiYd3Q/37CCHWxLLi ytxDjBIczEoivMsLP0QI8aYkVlalFuXHF5XmpBYfYjQFemEis5Rocj4w8eSVxBuaGJpbGhoZ W1iYGxkpifNO/XAlXEggPbEkNTs1tSC1CKaPiYNTqoFRQmjjbNP8RQrJp9si4k5ti9oy8bbu ldzlNR0Vsm8jv52rmNR50qF8jQZbe/y0BkFW/scZql5bZwp6N+tdY3CR5FiU2C3a2Z74Zf7i CWn3BH7oVpUwpRxw2XR2greZ+o/9vttv2R3+2mS1bD4Db7TM18XztA8X+lQKzMzj8slMbjgm 6b6nQl6JpTgj0VCLuag4EQBJVIa1BAMAAA== X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170414073337eucas1p20b078c46d0110fd5d78ad9b340767f1e X-Msg-Generator: CA X-Sender-IP: 182.198.249.180 X-Local-Sender: =?UTF-8?B?QW5kcnplaiBIYWpkYRtTUlBPTC1LZXJuZWwgKFRQKRvsgrw=?= =?UTF-8?B?7ISx7KCE7J6QG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Global-Sender: =?UTF-8?B?QW5kcnplaiBIYWpkYRtTUlBPTC1LZXJuZWwgKFRQKRtTYW1z?= =?UTF-8?B?dW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 201P X-HopCount: 7 X-CMS-RootMailID: 20170414051959epcas5p3917fe7adbc17a42bf0450a46b2baf55d X-RootMTR: 20170414051959epcas5p3917fe7adbc17a42bf0450a46b2baf55d References: <1492147179-7824-1-git-send-email-hoegeun.kwon@samsung.com> <1492147179-7824-2-git-send-email-hoegeun.kwon@samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Hoegeun, On 14.04.2017 07:19, Hoegeun Kwon wrote: > The Samsung s6e3ha2 edge is a 5.65" 1600x2560 AMOLED panel connected > using MIPI-DSI interfaces. As I wrote in discussion about s6e3ha2, there is no edge version of s6e3ha2, it is just different panel: s6e3hf2, or more precisely IC driver. [1]: https://lkml.org/lkml/2017/1/9/159 > > Signed-off-by: Hoegeun Kwon > --- > .../bindings/display/panel/samsung,s6e3ha2-e.txt | 28 ++++++++++++++++++++++ > 1 file changed, 28 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/panel/samsung,s6e3ha2-e.txt > > diff --git a/Documentation/devicetree/bindings/display/panel/samsung,s6e3ha2-e.txt b/Documentation/devicetree/bindings/display/panel/samsung,s6e3ha2-e.txt > new file mode 100644 > index 0000000..09c65f6 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/samsung,s6e3ha2-e.txt > @@ -0,0 +1,28 @@ > +Samsung S6E3HA2 5.65" 1600x2560 AMOLED panel > + > +Required properties: > + - compatible: "samsung,s6e3ha2-e" I think "samsung,s6e3hf2" should be then used, I guess it could be even simpler to just add new compatible string to samsung,s6e3ha2.txt binding with some comments, as these panels are of the same family. Regards Andrzej > + - reg: the virtual channel number of a DSI peripheral > + - vdd3-supply: I/O voltage supply > + - vci-supply: voltage supply for analog circuits > + - reset-gpios: a GPIO spec for the reset pin (active low) > + - enable-gpios: a GPIO spec for the panel enable pin (active high) > + > +Optional properties: > + - te-gpios: a GPIO spec for the tearing effect synchronization signal > + gpio pin (active high) > + > +Example: > +&dsi { > + ... > + > + panel@0 { > + compatible = "samsung,s6e3ha2-e"; > + reg = <0>; > + vdd3-supply = <&ldo27_reg>; > + vci-supply = <&ldo28_reg>; > + reset-gpios = <&gpg0 0 GPIO_ACTIVE_LOW>; > + enable-gpios = <&gpf1 5 GPIO_ACTIVE_HIGH>; > + te-gpios = <&gpf1 3 GPIO_ACTIVE_HIGH>; > + }; > +};