From: "Arnd Bergmann" <arnd@arndb.de>
To: "Justin Stitt" <justinstitt@google.com>, "Jan Kara" <jack@suse.cz>
Cc: "Arnd Bergmann" <arnd@kernel.org>,
linux-fsdevel@vger.kernel.org,
"Mike Marshall" <hubcap@omnibond.com>,
"Alexander Viro" <viro@zeniv.linux.org.uk>,
"Christian Brauner" <brauner@kernel.org>,
"Martin Brandenburg" <martin@omnibond.com>,
devel@lists.orangefs.org, "Vlastimil Babka" <vbabka@suse.cz>,
"Kees Cook" <keescook@chromium.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [RESEND] orangefs: fix out-of-bounds fsid access
Date: Tue, 09 Apr 2024 07:54:47 +0200 [thread overview]
Message-ID: <96b55a64-2bcf-44da-a728-ae54e2a73343@app.fastmail.com> (raw)
In-Reply-To: <CAFhGd8ohK=tQ+_qBQF5iW10qoySWi6MsGNoL3diBGHsgsP+n_A@mail.gmail.com>
On Mon, Apr 8, 2024, at 23:21, Justin Stitt wrote:
> On Mon, Apr 8, 2024 at 7:36 AM Jan Kara <jack@suse.cz> wrote:
>> Frankly, this initializer is hard to understand for me. Why not simple:
>>
>> buf->f_fsid[0] = ORANGEFS_SB(sb)->fs_id;
>> buf->f_fsid[1] = ORANGEFS_SB(sb)->id;
>>
>
> +1 for this idea, seems easier to read for me.
Yes, good idea, I'll send this as v2 after my next round
of build testing.
Arnd
next prev parent reply other threads:[~2024-04-09 5:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-08 7:50 Arnd Bergmann
2024-04-08 14:36 ` Jan Kara
2024-04-08 21:21 ` Justin Stitt
2024-04-09 5:54 ` Arnd Bergmann [this message]
2024-04-09 16:26 ` Mike Marshall
2024-04-09 19:33 ` Arnd Bergmann
-- strict thread matches above, loose matches on Subject: below --
2024-03-20 18:05 Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=96b55a64-2bcf-44da-a728-ae54e2a73343@app.fastmail.com \
--to=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=brauner@kernel.org \
--cc=devel@lists.orangefs.org \
--cc=hubcap@omnibond.com \
--cc=jack@suse.cz \
--cc=justinstitt@google.com \
--cc=keescook@chromium.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin@omnibond.com \
--cc=vbabka@suse.cz \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®