mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: YueHaibing <yuehaibing@huawei.com>, dledford@redhat.com, jgg@ziepe.ca
Cc: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 -next] RDMA/srp: use DEVICE_ATTR_*() macro
Date: Fri, 28 May 2021 15:07:34 -0700	[thread overview]
Message-ID: <96b606c0-ba7b-ec6a-a95f-5c579b6d02e8@acm.org> (raw)
In-Reply-To: <20210528125750.20788-1-yuehaibing@huawei.com>

On 5/28/21 5:57 AM, YueHaibing wrote:
> -static ssize_t show_id_ext(struct device *dev, struct device_attribute *attr,
> -			   char *buf)
> +static ssize_t id_ext_show(struct device *dev,
> +			   struct device_attribute *attr, char *buf)

Please make better use of horizontal space by moving "struct
device_attribute *attr," to the end of the previous line. This advice
probably also applies to other changes in this patch.

Thanks,

Bart.

  reply	other threads:[~2021-05-28 22:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-28 12:57 YueHaibing
2021-05-28 22:07 ` Bart Van Assche [this message]
2021-05-28 23:42 ` Jason Gunthorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=96b606c0-ba7b-ec6a-a95f-5c579b6d02e8@acm.org \
    --to=bvanassche@acm.org \
    --cc=dledford@redhat.com \
    --cc=jgg@ziepe.ca \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=yuehaibing@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®