From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from canpmsgout01.his.huawei.com (canpmsgout01.his.huawei.com [113.46.200.216]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DCB9141BA74; Mon, 20 Jul 2026 12:53:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=113.46.200.216 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784552043; cv=none; b=ffVT4QFJsYc8qWas1Wlsau4XWfILT4hQOCCRZeBeD0LVGZfyL0sadRW9aJ+k+2IKN+Ro2ZiptQpQi29Ez1mBgggV7zsHOiydgemjDcTHdDuvS6kCFqxR5YXUGZcPG4MhSyg9muA7d+hL5h56N2gCxA+YLOUkmY6a/p3Tcfs1THY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784552043; c=relaxed/simple; bh=33guapbM98+bB8N886bWbu1ud8WqZaIM+sVnj6u/824=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=IjrPlvJhvZHCYdi3gnNhdCtj0b9kvSv68gI64o1llmGNDNArYcUtHPSJTwxVunbCdciEv2FrR+wJJhn1P4P+lwmQYtx1+5EHIUwChQxPcNLZ2Nnpi7zid4LYuwK5hyy04nAovOdPwctPfbac0dX7iCqH+1uVz5aUE1Q47w0xX8s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; dkim=pass (1024-bit key) header.d=huawei.com header.i=@huawei.com header.b=AXLpuQVJ; arc=none smtp.client-ip=113.46.200.216 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=huawei.com header.i=@huawei.com header.b="AXLpuQVJ" dkim-signature: v=1; a=rsa-sha256; d=huawei.com; s=dkim; c=relaxed/relaxed; q=dns/txt; h=From; bh=ZTRQsBX22eg7jssC8hp3kPHmh687pyKFp1r7BcZPzA8=; b=AXLpuQVJn32cIzGlsUg0yA6wN7G0iSmn5H/Xf1JyHwxYGF8RQijBXZ6TE2FS6IpQ0upVQfIWS E4u52T2d4oMupWvLfGR+eeXHlHY7Mnto+sD1ZKzKZov+LfAGdijHvW++CWCHao3PoXrv8gJicRV FZX/4zM4/2d7YIehOhZMbAY= Received: from mail.maildlp.com (unknown [172.19.162.197]) by canpmsgout01.his.huawei.com (SkyGuard) with ESMTPS id 4h3gFd3JDbz1T4GB; Mon, 20 Jul 2026 20:44:37 +0800 (CST) Received: from kwepemf100013.china.huawei.com (unknown [7.202.181.12]) by mail.maildlp.com (Postfix) with ESMTPS id 62A914057D; Mon, 20 Jul 2026 20:53:55 +0800 (CST) Received: from DESKTOP-62GVMTR.china.huawei.com (10.174.189.124) by kwepemf100013.china.huawei.com (7.202.181.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.36; Mon, 20 Jul 2026 20:53:54 +0800 From: Fan Gong To: Fan Gong , Wu Di , Teng Peisen , , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Andrew Lunn , Ioana Ciornei , Mohsin Bashir , Dimitri Daskalakis , Harshitha Ramamurthy CC: , , luosifu , Xin Guo , Zhou Shuai , Wu Like , Shi Jing , Zheng Jiezhen , Maxime Chevallier Subject: [PATCH net-next v11 5/5] hinic3: Remove unneeded coalesce parameters Date: Mon, 20 Jul 2026 20:53:38 +0800 Message-ID: <96bc71d55acb7d93f272ea25998c22b5aed693f7.1784538912.git.root@localhost.localdomain> X-Mailer: git-send-email 2.50.1.windows.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: kwepems200002.china.huawei.com (7.221.188.68) To kwepemf100013.china.huawei.com (7.202.181.12) Remove unneeded coalesce parameters in irq handling. Co-developed-by: Wu Di Signed-off-by: Wu Di Co-developed-by: Teng Peisen Signed-off-by: Teng Peisen Signed-off-by: Fan Gong --- drivers/net/ethernet/huawei/hinic3/hinic3_irq.c | 6 +----- drivers/net/ethernet/huawei/hinic3/hinic3_rx.h | 3 --- 2 files changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/net/ethernet/huawei/hinic3/hinic3_irq.c b/drivers/net/ethernet/huawei/hinic3/hinic3_irq.c index 94d0773ebf2c..a5013dd8ade2 100644 --- a/drivers/net/ethernet/huawei/hinic3/hinic3_irq.c +++ b/drivers/net/ethernet/huawei/hinic3/hinic3_irq.c @@ -149,13 +149,9 @@ static int hinic3_set_interrupt_moder(struct net_device *netdev, u16 q_id, nic_dev->intr_coalesce[q_id].resend_timer_cfg; err = hinic3_set_interrupt_cfg(nic_dev->hwdev, info); - if (err) { + if (err) netdev_err(netdev, "Failed to modify moderation for Queue: %u\n", q_id); - } else { - nic_dev->rxqs[q_id].last_coalesc_timer_cfg = coalesc_timer_cfg; - nic_dev->rxqs[q_id].last_pending_limit = pending_limit; - } return err; } diff --git a/drivers/net/ethernet/huawei/hinic3/hinic3_rx.h b/drivers/net/ethernet/huawei/hinic3/hinic3_rx.h index c11d080408a7..2ab691ed11a9 100644 --- a/drivers/net/ethernet/huawei/hinic3/hinic3_rx.h +++ b/drivers/net/ethernet/huawei/hinic3/hinic3_rx.h @@ -111,9 +111,6 @@ struct hinic3_rxq { dma_addr_t cqe_start_paddr; struct dim dim; - - u8 last_coalesc_timer_cfg; - u8 last_pending_limit; } ____cacheline_aligned; struct hinic3_dyna_rxq_res { -- 2.54.0