mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: ALOK TIWARI <alok.a.tiwari@oracle.com>
To: Nam Cao <namcao@linutronix.de>, Christian Brauner <brauner@kernel.org>
Cc: Shuah Khan <shuah@kernel.org>,
	John Ogness <john.ogness@linutronix.de>,
	linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] selftests: coredump: Properly initialize pointer
Date: Fri, 11 Apr 2025 20:57:06 +0530	[thread overview]
Message-ID: <96bd0364-3926-4aed-ad9d-d650c16e7440@oracle.com> (raw)
In-Reply-To: <4fb9b6fb3e0040481bacc258c44b4aab5c4df35d.1744383419.git.namcao@linutronix.de>



On 11-04-2025 20:39, Nam Cao wrote:
>   	/* Step 4: Make sure all stack pointer values are non-zero */
> +	line = NULL;

such case it should initialize at declaration time.
better to move up char *test_dir, *line = NULL;

>   	for (i = 0; -1 != getline(&line, &line_length, file); ++i) {
>   		stack = strtoull(line, NULL, 10);
>   		ASSERT_NE(stack, 0);
>   	}


Thanks,
Alok

  reply	other threads:[~2025-04-11 15:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-11 15:09 [PATCH v2 0/3] selftests: coredump: Some bug fixes Nam Cao
2025-04-11 15:09 ` [PATCH v2 1/3] selftests: coredump: Properly initialize pointer Nam Cao
2025-04-11 15:27   ` ALOK TIWARI [this message]
2025-04-11 15:09 ` [PATCH v2 2/3] selftests: coredump: Fix test failure for slow machines Nam Cao
2025-04-11 15:09 ` [PATCH v2 3/3] selftests: coredump: Raise timeout to 2 minutes Nam Cao
2025-04-14 11:08 ` [PATCH v2 0/3] selftests: coredump: Some bug fixes Christian Brauner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=96bd0364-3926-4aed-ad9d-d650c16e7440@oracle.com \
    --to=alok.a.tiwari@oracle.com \
    --cc=brauner@kernel.org \
    --cc=john.ogness@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=namcao@linutronix.de \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®