From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DFDDC48BE8 for ; Wed, 16 Jun 2021 08:39:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3C02C610A0 for ; Wed, 16 Jun 2021 08:39:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231744AbhFPImB (ORCPT ); Wed, 16 Jun 2021 04:42:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58390 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231318AbhFPImA (ORCPT ); Wed, 16 Jun 2021 04:42:00 -0400 Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com [IPv6:2a00:1450:4864:20::12e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AE3C4C061574; Wed, 16 Jun 2021 01:39:53 -0700 (PDT) Received: by mail-lf1-x12e.google.com with SMTP id p7so2978330lfg.4; Wed, 16 Jun 2021 01:39:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=6YpVa0+q2Eocwluyky2FGEKu1f+VgEpX5T1fuuU2+uE=; b=dJOVRj2ZEWQ7cxt2SkiE47Prb//6AoCzTina/QehwYubPpmPxEMItVLdStvydhXm35 dJP97otG9TIkarIptGxLacxgLnUp0djzWcu3xBeuK5ehvGlqalZ70F4uMfnGt8HmLnbS qncyWVSv75bBpoKNsJ6jojmQdPMNQErj/uHUChHiH1O/YPS5OCizRzCcSjax5zJ/6XfN aEzz/LKRtP2Wv3VNzR4n2JP2RcDxP4SY42fpxrb1fqKoMU3O6f47rkkn6dBh0S5vMfUc fUhYkVol1TCvOqSHLejUDhVrjsnriBrKoHOn+AZqcF1/jBQjggK/NZC/rvpTkyNgq1/Q Ej8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=6YpVa0+q2Eocwluyky2FGEKu1f+VgEpX5T1fuuU2+uE=; b=jZl9PJBQGf55JH1X3Wu8eMJYwMw1qE9dzcuffpeJKSfX0JA3n0kBiBXXVhIdJALBg9 a+1IR3UoWieJ/Ks8QWeiyfnCRXARYmls8nx7RHgyVo1PkemIxNKfW3Atcee/OPYLQrUA YfmKIsfxa4tWBr51fQLH2dsSQQeWpECFDCIyWKgcPWLd+Xgkblu1+mSBwW6Y3MWJ2RBm FiqQLRSEqskUTLbfGw7AFfTNBAsf1qCMoGa71GRUDd5yciqEhdA2e36SmZvPs7PeSiEc XeDU7L43AP06M2ZMxReB5foqQ4XGWXzvJIBnAUAJ0L/+Wqun8FbNtPPLsFg5aTlNRAp0 NzZA== X-Gm-Message-State: AOAM532K3b70OnFy3hdoOUIkL6tbhW5UcneBUANOHbbMHUNBTwfR7P29 GJwh5oXB6uU1Ld206W9S7rwbFTCB5gk= X-Google-Smtp-Source: ABdhPJzTk9wKIGkG7m04OdTwoeo1mFBz4o5KFFJj71YQDsV99L/4sFss0gOpN05WFw8rk1asAksAMA== X-Received: by 2002:ac2:47eb:: with SMTP id b11mr2938549lfp.455.1623832791520; Wed, 16 Jun 2021 01:39:51 -0700 (PDT) Received: from [192.168.2.145] (94-29-31-25.dynamic.spd-mgts.ru. [94.29.31.25]) by smtp.googlemail.com with ESMTPSA id k19sm175246lfe.25.2021.06.16.01.39.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Jun 2021 01:39:51 -0700 (PDT) Subject: Re: [PATCH v3 4/7] thermal/drivers/tegra: Add driver for Tegra30 thermal sensor To: Vincent Guittot , Viresh Kumar Cc: Daniel Lezcano , Thara Gopinath , Thierry Reding , Jonathan Hunter , Zhang Rui , Amit Kucheria , Andreas Westman Dorcsak , Maxim Schwalm , Svyatoslav Ryhel , Ihor Didenko , Ion Agorria , Matt Merhar , Peter Geis , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-kernel , linux-tegra@vger.kernel.org, "open list:THERMAL" References: <20210529170955.32574-1-digetx@gmail.com> <20210529170955.32574-5-digetx@gmail.com> <6f2b6290-095a-bd39-c160-1616a0ff89b1@linaro.org> <20210615102626.dja3agclwzxv2sj4@vireshk-i7> <595f5e53-b872-bcc6-e886-ed225e26e9fe@gmail.com> <4c7b23c4-cf6a-0942-5250-63515be4a219@gmail.com> <20210616080310.vhvauvo5y6m2sekz@vireshk-i7> From: Dmitry Osipenko Message-ID: <96bf59af-20b6-b706-5ff0-fe70f9eba827@gmail.com> Date: Wed, 16 Jun 2021 11:39:49 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 16.06.2021 11:30, Vincent Guittot пишет: > On Wed, 16 Jun 2021 at 10:03, Viresh Kumar wrote: >> >> +Vincent. >> >> On 15-06-21, 22:32, Dmitry Osipenko wrote: >>> IIUC, the cpufreq already should be prepared for the case where firmware >>> may override frequency. Viresh, could you please clarify what are the >>> possible implications of the frequency overriding? >> >> The only implication is software would think hardware is running at >> some other frequency, while it is not. Not sure if something may break >> as a result of this. >> >> The scheduler's view of CPUs will not be same though, i.e. scheduler >> will see capacity as X, while in reality it has changed to Y. > > thermal_pressure is used by scheduler to balance the load between CPUs > according to the actual max frequency. If the thermal pressure doesn't > reflect reality, scheduler will end up enqueuing too many tasks on a > throttle CPU. What if all CPUs are throttled equally and running on the same frequency, will throttling have any effect on the scheduler decisions?