From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out30-124.freemail.mail.aliyun.com (out30-124.freemail.mail.aliyun.com [115.124.30.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5B6382517AA for ; Thu, 18 Dec 2025 07:15:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=115.124.30.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766042133; cv=none; b=hViEjX2haPLOcs1PV4pCywNmeiC940xGtPvRzIlKTY4KdzgZRPC49gYUGWvybWzvDQ2Dw9ofuWSmT0F6V2+cd+n0J5U7ZieRZEz01QJJBjcg/NPB3wbVLblGWvRiks77eXopNM7i9Ig7QRdH8aTzjMx2EUxXGpVnP6yTkhM33Og= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766042133; c=relaxed/simple; bh=YIDXQ4DqcfmQ59bjYvRy+xdZ98ODe+2jlH+8o8qdIf4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=WTNBYWc4KT5F9Pdy3zWHfR9vgyVBJlBeaSk80o3s4rN7KjYuvQ1qqA6cFZzywD1zBsuJRoBByMmvWxs3VCpfYmKsj7hzFoQ++YvQAKKDAq/TTi/JFcXpEJ7By2E+NfnpYhKnfSGVkwPtNvtWyC+MtCNkjagbxlBWOzYYwxzVa+M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com; spf=pass smtp.mailfrom=linux.alibaba.com; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b=Z5joIWri; arc=none smtp.client-ip=115.124.30.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b="Z5joIWri" DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1766042119; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=uauTuHRqpfPJlC4EeGuuyBYgKP0qHs1Wgk0vfO6QTvs=; b=Z5joIWriMfA9Ui9fXMNOJMahLeYJOE7gP7th9lIMnS+9lkzH9Ln1WX31a9pfg3/7oPlpwK/Of94jK1PNaCAGkMUxEFxAyL7DJtFyIMN5aE2R56F3kbtGaIM4jo4xruxdBcQqfAA10XrOwKX7qXoiNSxjFrI4zhqA+CIV/ClOA4w= Received: from 30.74.144.118(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0Wv7ehcK_1766042116 cluster:ay36) by smtp.aliyun-inc.com; Thu, 18 Dec 2025 15:15:17 +0800 Message-ID: <96c0adcc-abfd-4a44-be93-1c6bd7942d6d@linux.alibaba.com> Date: Thu, 18 Dec 2025 15:15:16 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/3] arm64: mm: support batch clearing of the young flag for large folios To: Ryan Roberts , akpm@linux-foundation.org, david@kernel.org, catalin.marinas@arm.com, will@kernel.org Cc: lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, vbabka@suse.cz, rppt@kernel.org, surenb@google.com, mhocko@suse.com, riel@surriel.com, harry.yoo@oracle.com, jannh@google.com, willy@infradead.org, baohua@kernel.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <1beaa7de-4b31-4f19-abee-83872f868e28@arm.com> From: Baolin Wang In-Reply-To: <1beaa7de-4b31-4f19-abee-83872f868e28@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2025/12/17 23:43, Ryan Roberts wrote: > Sorry I'm a bit late to the party... Never mind. It's not late and comments are always welcome :) > On 11/12/2025 08:16, Baolin Wang wrote: >> Currently, contpte_ptep_test_and_clear_young() and contpte_ptep_clear_flush_young() >> only clear the young flag and flush TLBs for PTEs within the contiguous range. >> To support batch PTE operations for other sized large folios in the following >> patches, adding a new parameter to specify the number of PTEs. >> >> While we are at it, rename the functions to maintain consistency with other >> contpte_*() functions. >> >> Signed-off-by: Baolin Wang >> --- >> arch/arm64/include/asm/pgtable.h | 12 ++++----- >> arch/arm64/mm/contpte.c | 44 ++++++++++++++++++++++---------- >> 2 files changed, 37 insertions(+), 19 deletions(-) >> >> diff --git a/arch/arm64/include/asm/pgtable.h b/arch/arm64/include/asm/pgtable.h >> index 0944e296dd4a..e03034683156 100644 >> --- a/arch/arm64/include/asm/pgtable.h >> +++ b/arch/arm64/include/asm/pgtable.h >> @@ -1679,10 +1679,10 @@ extern void contpte_clear_full_ptes(struct mm_struct *mm, unsigned long addr, >> extern pte_t contpte_get_and_clear_full_ptes(struct mm_struct *mm, >> unsigned long addr, pte_t *ptep, >> unsigned int nr, int full); >> -extern int contpte_ptep_test_and_clear_young(struct vm_area_struct *vma, >> - unsigned long addr, pte_t *ptep); >> -extern int contpte_ptep_clear_flush_young(struct vm_area_struct *vma, >> - unsigned long addr, pte_t *ptep); >> +extern int contpte_test_and_clear_young_ptes(struct vm_area_struct *vma, >> + unsigned long addr, pte_t *ptep, unsigned int nr); >> +extern int contpte_clear_flush_young_ptes(struct vm_area_struct *vma, >> + unsigned long addr, pte_t *ptep, unsigned int nr); > > The "contpte_" functions are intended to be private to the arm64 arch and should > be exposed via the generic APIs. But I don't see any generic batched API for > this, so you're only actually able to pass CONT_PTES as nr. Perhaps you're > planning to define "test_and_clear_young_ptes()" and "clear_flush_young_ptes()" > in later patches? Right. This is a preparation patch, and will be used in patch 2. >> extern void contpte_wrprotect_ptes(struct mm_struct *mm, unsigned long addr, >> pte_t *ptep, unsigned int nr); >> extern int contpte_ptep_set_access_flags(struct vm_area_struct *vma, >> @@ -1854,7 +1854,7 @@ static inline int ptep_test_and_clear_young(struct vm_area_struct *vma, >> if (likely(!pte_valid_cont(orig_pte))) >> return __ptep_test_and_clear_young(vma, addr, ptep); >> >> - return contpte_ptep_test_and_clear_young(vma, addr, ptep); >> + return contpte_test_and_clear_young_ptes(vma, addr, ptep, CONT_PTES); >> } >> >> #define __HAVE_ARCH_PTEP_CLEAR_YOUNG_FLUSH >> @@ -1866,7 +1866,7 @@ static inline int ptep_clear_flush_young(struct vm_area_struct *vma, >> if (likely(!pte_valid_cont(orig_pte))) >> return __ptep_clear_flush_young(vma, addr, ptep); >> >> - return contpte_ptep_clear_flush_young(vma, addr, ptep); >> + return contpte_clear_flush_young_ptes(vma, addr, ptep, CONT_PTES); >> } >> >> #define wrprotect_ptes wrprotect_ptes >> diff --git a/arch/arm64/mm/contpte.c b/arch/arm64/mm/contpte.c >> index c0557945939c..19b122441be3 100644 >> --- a/arch/arm64/mm/contpte.c >> +++ b/arch/arm64/mm/contpte.c >> @@ -488,8 +488,9 @@ pte_t contpte_get_and_clear_full_ptes(struct mm_struct *mm, >> } >> EXPORT_SYMBOL_GPL(contpte_get_and_clear_full_ptes); >> >> -int contpte_ptep_test_and_clear_young(struct vm_area_struct *vma, >> - unsigned long addr, pte_t *ptep) >> +int contpte_test_and_clear_young_ptes(struct vm_area_struct *vma, >> + unsigned long addr, pte_t *ptep, >> + unsigned int nr) >> { >> /* >> * ptep_clear_flush_young() technically requires us to clear the access >> @@ -500,39 +501,56 @@ int contpte_ptep_test_and_clear_young(struct vm_area_struct *vma, >> * having to unfold. >> */ >> >> + unsigned long start = addr; > > Personally I wouldn't bother defining start - just reuse addr. You're > incrementing start in the below loop, so it's more appropriate to call it addr > anyway. OK. >> + unsigned long end = start + nr * PAGE_SIZE; >> int young = 0; >> int i; >> >> - ptep = contpte_align_down(ptep); >> - addr = ALIGN_DOWN(addr, CONT_PTE_SIZE); >> + if (pte_cont(__ptep_get(ptep + nr - 1))) >> + end = ALIGN(end, CONT_PTE_SIZE); >> >> - for (i = 0; i < CONT_PTES; i++, ptep++, addr += PAGE_SIZE) >> - young |= __ptep_test_and_clear_young(vma, addr, ptep); >> + if (pte_cont(__ptep_get(ptep))) { >> + start = ALIGN_DOWN(start, CONT_PTE_SIZE); >> + ptep = contpte_align_down(ptep); >> + } >> + >> + nr = (end - start) / PAGE_SIZE; >> + for (i = 0; i < nr; i++, ptep++, start += PAGE_SIZE) > > Given you're now defining end, perhaps we don't need nr? > > for (; addr != end; ptep++, addr += PAGE_SIZE) > young |= __ptep_test_and_clear_young(vma, addr, ptep); Yes, good point. >> + young |= __ptep_test_and_clear_young(vma, start, ptep); >> >> return young; >> } >> -EXPORT_SYMBOL_GPL(contpte_ptep_test_and_clear_young); >> +EXPORT_SYMBOL_GPL(contpte_test_and_clear_young_ptes); >> >> -int contpte_ptep_clear_flush_young(struct vm_area_struct *vma, >> - unsigned long addr, pte_t *ptep) >> +int contpte_clear_flush_young_ptes(struct vm_area_struct *vma, >> + unsigned long addr, pte_t *ptep, >> + unsigned int nr) >> { >> int young; >> >> - young = contpte_ptep_test_and_clear_young(vma, addr, ptep); >> + young = contpte_test_and_clear_young_ptes(vma, addr, ptep, nr); >> >> if (young) { >> + unsigned long start = addr; >> + unsigned long end = start + nr * PAGE_SIZE; >> + >> + if (pte_cont(__ptep_get(ptep + nr - 1))) >> + end = ALIGN(end, CONT_PTE_SIZE); >> + >> + if (pte_cont(__ptep_get(ptep))) >> + start = ALIGN_DOWN(start, CONT_PTE_SIZE); >> + > > We now have this pattern of expanding contpte blocks up and down in 3 places. > Perhaps create a helper? Sounds reasonable. How about the following helper? static pte_t *contpte_align_addr_ptep(unsigned long *start, unsigned long *end, pte_t *ptep, unsigned int nr) { unsigned long end_addr = *start + nr * PAGE_SIZE; if (pte_cont(__ptep_get(ptep + nr - 1))) *end = ALIGN(end_addr, CONT_PTE_SIZE); if (pte_cont(__ptep_get(ptep))) { *start = ALIGN_DOWN(*start, CONT_PTE_SIZE); ptep = contpte_align_down(ptep); } return ptep; }