From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B09D2D9796 for ; Tue, 23 Jun 2026 13:08:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782220122; cv=none; b=FfZ+2G/Gsgp0tgMUnktXMZJR6n0AXtluOTmfXOlsVlKcgOHlkrMMwD64nsJIaXllTV6kLN1U01VjEh4ZjNudS779xZCZD2dUT1U/+xqahvq/meYl9dyPYV54K6TIbH8hifPwlcd4ss3DwNW0ZbeWH4B6gSiznJ1jjDMh/dqpYY4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782220122; c=relaxed/simple; bh=dX3M0lxFvDhCVyZaJikvZU/6GknByqMsbJzElYPQrBo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=TfzJIxYX7ovEB7obJAVzEszieYQy5x+XKioHZ94sfB7DJP/slXlZzse8npwfm32IbiyjPDz/B3My/IKv7VZGFNq2tRwdMAmREyLFuG1R2v21hWFgEQe3JpExELXHu8WF9L9uAqrTYaKB4fjBShu6bZ7w1r54xt8cJNL0GbXmHtk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=nWGiDuI7; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=S2OWOIb5; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="nWGiDuI7"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="S2OWOIb5" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65NBZ98F030781 for ; Tue, 23 Jun 2026 13:08:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= kq3/D/BC/RvOm7IrhRgaq8LAkg0fMyEGRtGKjug4xjU=; b=nWGiDuI7hd3h1Nh2 sxaEBVJy8ctBKiiuBV9D5MC0Io66Xnz2xV7kbS8yEW/t8cgvqt5+p1au4bDfBuNa O2IoDpUk5DiZXOc+9Dk5WvRdfX3jf8hHpSfbNqbCPkYvmJCekvjrYCERCgVfTius ZV4ulqiLMPXyDFWS923F/IBLHvTQkPkcSEZGYYWs05jPejAlAAZHFzTGhykPVgmS kRUVwhITGmJia/1Lb4lSmqDC9zLq6WlkdXlewUtzW0M4hZU3WeLfep44bbeYCqlu KsBQfv1TlNK2oRQISW3MQHXjf4aCWnuBC6eLmxbTqG9QJVNA6NV9jb6bRWM6+FpS idZ39Q== Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eyqe68vg0-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 23 Jun 2026 13:08:37 +0000 (GMT) Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-8423f3e4728so3611280b3a.2 for ; Tue, 23 Jun 2026 06:08:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782220117; x=1782824917; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=kq3/D/BC/RvOm7IrhRgaq8LAkg0fMyEGRtGKjug4xjU=; b=S2OWOIb5VQqJ8RhOLmiYZgzSFKmIP61wYOvHK/vdQ63RFYuq6bZ4iK/7qOsEJoWcsG ZQyQ2SdmZUAy7md/Q0FwirFOovy/2HEsOLfUL+pIFnNYJ24ZoFsVqwJo3w87vgj4XHdN azafZjakBY9lkkyKk8zH0dUJDgtgaJ38BRaQ7KOCAgTYtgZewyVHaHCE1gJ3rkPB3Kw0 bLhhI4wstYo3KI1tfJcXn1sCGzjEOcP+LzOWXipLi9rXD/u1HSQLzf2QVIVVwG+ZV/37 P0WTefh18apwn0Bq2sJqJiQOhcw271+s0gswQqX+eXQBRrAd9+vpVdbcKuVZ24Biz3Nt uZOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782220117; x=1782824917; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=kq3/D/BC/RvOm7IrhRgaq8LAkg0fMyEGRtGKjug4xjU=; b=VAGcjLL0fM2NF95O46+iBdP2IPiml+71/LERAsacftCXtyCw+9aUfAHx0HgBJGWFAL m/b+MMe4ffQDwcx5jfQ6Q7VbLYXsa+IXt/3VG55Z8yo4uicm5Numd+OuRRZa7DMspl6N VoZG8qzSJlkIIf3p7I8zKzzDY0iSID/A9aCpy4fAvJPxKWWps6ZJ0NLfaQKfMYsKAmZG D8BC7r/wL+zMoHDUxyrt36rZASfVOIWxnBkkjM/SlVK2IN0+6bYUmHPBBNmufXzB2b+V cPB310epuJ5/bwXEVSbtekv7l8bRbtkLShyh8teMxU1onnc1IYgPfVkRgd37EoQUStRo 56hw== X-Forwarded-Encrypted: i=1; AHgh+Ro6spbzxqdKo9MX/6BRKctSTCYcBkx8U1HWXyG9xkEKD87BOmmtzKHUzbHqg7i3WAtp9XPPwJ3Fp9f7Sgs=@vger.kernel.org X-Gm-Message-State: AOJu0Yyodv9xLVdvB+bHmDUGm3O0EhQG4bRt140k1MWxABgQ+noDWzDQ eJBJz5bXyvB7Z4PNCrK9sPfiEjns/jirBrJf+vUGQR+H5tkZnVLKZUrlvc8Po8Kr11+9gcaOtia o1smBvXD6py9uo+6sH9ypLWCgOkMxkeItMHPlmd8v1QmQvaoFCm0AHMM8l6+GK6vvkls= X-Gm-Gg: AfdE7cmLC364/aVr+YYXNWsHpqYDT1HNgjkCvSMGbNGQBbwWEkS+vZdps8Y5+PG+0fF 579xdKp881FeVdkcs1jnE9ZvYi6/BTbLAe47fr7UpqcMp70eSaIr4axRUJIclloTPqpCY9rKIOM Alx8GuZFY+wBl/20rLbmgZzR975DM7cVG/RZnTXes2vf5xhD8RHwWQb5s8hVKMpKeHvXd0vwkcy J8gfR3UM9/NQfBRRHXutJWO6dDAKKC55mDRW2hN5vILDWSWMmZ2Wa0brFI1O5nUbVgmyN2hMNgl 6h13B0yuZFoREgyOvy37yzApkC1juj/LsATd2nI65/XI4btqwNtf6Pe0yRbxGJZwZ/+A55iEb4S NS4nBN2NbjkvHsvZO+VG7WqkQ1JysfbBuh3W6F3km+81ufQYQZi1G15VBWm/dapN2XNVP38wFDi Yp X-Received: by 2002:a05:6a00:950b:b0:82f:9985:d4a1 with SMTP id d2e1a72fcca58-845952fa1a0mr3520959b3a.24.1782220117031; Tue, 23 Jun 2026 06:08:37 -0700 (PDT) X-Received: by 2002:a05:6a00:950b:b0:82f:9985:d4a1 with SMTP id d2e1a72fcca58-845952fa1a0mr3520921b3a.24.1782220116574; Tue, 23 Jun 2026 06:08:36 -0700 (PDT) Received: from [10.133.33.180] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84564e745cfsm10655846b3a.31.2026.06.23.06.08.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Jun 2026 06:08:36 -0700 (PDT) Message-ID: <96c0d9d2-d902-4e07-9854-2ca5ddcc5eaa@oss.qualcomm.com> Date: Tue, 23 Jun 2026 21:08:31 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] scsi: ufs: core: Tolerate RX_FOM read failures in TX EQTR To: =?UTF-8?B?UGV0ZXIgV2FuZyAo546L5L+h5Y+LKQ==?= , "beanhuo@micron.com" , "mani@kernel.org" , "bvanassche@acm.org" , "martin.petersen@oracle.com" Cc: "linux-scsi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "alim.akhtar@samsung.com" , "avri.altman@wdc.com" , "James.Bottomley@HansenPartnership.com" References: <20260620080322.3765210-1-can.guo@oss.qualcomm.com> <20260620080322.3765210-3-can.guo@oss.qualcomm.com> Content-Language: en-US From: Can Guo In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: NqaGu7xYUU-1t_r6f33teiB10r2-gI1L X-Proofpoint-ORIG-GUID: NqaGu7xYUU-1t_r6f33teiB10r2-gI1L X-Proofpoint-Spam-Info: AW1haW4tMjYwNjIzMDEwOCBTYWx0ZWRfX5+0CwFvOJDq3 T4d8sMLkz54mqAaEbytNjnyVC1ZcEhrncceKS67++PTQcatkTuF5PBPrSXeR2QvWxMuXnJ3j5zK 5Cl2BZtv6hM8xjwNZePUoHzvvBCfS9M= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjIzMDEwOCBTYWx0ZWRfX1ppQqqnjYLfU K7elASzgbzxXIwLedoeDGaBBTgjEsglnWSRyflaRuaz6NcrmzpUAlSpRR6M35E5nyajbm0pFjuv cHvGAQ9hNWedV9BXuAbaf6AeTped8QDxxHAwPEb2bt7EftUVClpioGRAJjfU0kOf2/oeibYjAAI llYI+VsVoAPQ1io9P4o2/dGbgK/1qYdXVVAX8kgRoyyGgEPTSWgbKL2rHc9qRvj0tK4cL+mvY+W r1GTVfvAxLfp0gozvTGKAs2nU4OPLrl1UoKX+5lmYDqgbE0dyZw6Q6KuMHcUkorqNCpAD3CeRT+ DQaRkaIRsDWgsYNI73H3ASmXWlgiogdEv7AMfitbp/DbkrM2bDZInKJbVj9dgiwrrwHUujDi35A jh3quTp9ZoOeevQMkOQ9umUAqlQRW5jmZYIYahVg+eCX3R33dTCKuxBrxZQOemyL+QQ6YYUm4AL x8SMR9uDDJqh+lEfS8A== X-Authority-Analysis: v=2.4 cv=OeKoyBTY c=1 sm=1 tr=0 ts=6a3a8555 cx=c_pps a=rEQLjTOiSrHUhVqRoksmgQ==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=Muby7z2g3K1BkzpCY48A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=2VI0MkxyNR6bbpdq8BZq:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-23_03,2026-06-23_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 impostorscore=0 spamscore=0 malwarescore=0 adultscore=0 suspectscore=0 clxscore=1015 priorityscore=1501 lowpriorityscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606230108 On 6/23/2026 5:05 PM, Peter Wang (王信友) wrote: > > On Sat, 2026-06-20 at 01:03 -0700, Can Guo wrote: > > @@ -494,22 +496,30 @@ static int ufshcd_get_rx_fom(struct ufs_hba > > *hba, > > > >         /* Get FOM of host's TX lanes from device's RX_FOM. */ > >         for (lane = 0; lane < pwr_mode->lane_tx; lane++) { > > +               h_iter->fom[lane] = 0; > >                 ret = ufshcd_dme_peer_get(hba, > > UIC_ARG_MIB_SEL(RX_FOM, > > > > UIC_ARG_MPHY_RX_GEN_SEL_INDEX(lane)), > >                                           &fom); > > -               if (ret) > > -                       return ret; > > +               if (ret) { > > +                       dev_dbg(hba->dev, "Failed to get FOM for Host > > TX Lane %d: %d\n", > > +                               lane, ret); > > +                       continue; > > +               } > > > > Hi Can, > > I suggest setting h_iter->fom[lane] = 0 when an error occurs, > as this approach is clearer and improves code efficiency, > for example: > if (ret) { > h_iter->fom[lane] = 0; > ... > continue; > } Thanks for suggestion, and I like it, let me adopt in next version. Thanks, Can Guo. > > > >                 h_iter->fom[lane] = (u8)fom; > >         } > > > >         /* Get FOM of device's TX lanes from host's RX_FOM. */ > >         for (lane = 0; lane < pwr_mode->lane_rx; lane++) { > > +               d_iter->fom[lane] = 0; > >                 ret = ufshcd_dme_get(hba, UIC_ARG_MIB_SEL(RX_FOM, > > > > UIC_ARG_MPHY_RX_GEN_SEL_INDEX(lane)), > >                                      &fom); > > -               if (ret) > > -                       return ret; > > +               if (ret) { > > +                       dev_dbg(hba->dev, "Failed to get FOM for > > Device TX Lane %d: %d\n", > > +                               lane, ret); > > +                       continue; > > +               } > > > > The same applies as above. > > Thanks > Peter > > ************* MEDIATEK Confidentiality Notice > ******************** > The information contained in this e-mail message (including any > attachments) may be confidential, proprietary, privileged, or otherwise > exempt from disclosure under applicable laws. It is intended to be > conveyed only to the designated recipient(s). Any use, dissemination, > distribution, printing, retaining or copying of this e-mail (including its > attachments) by unintended recipient(s) is strictly prohibited and may > be unlawful. If you are not an intended recipient of this e-mail, or believe > > that you have received this e-mail in error, please notify the sender > immediately (by replying to this e-mail), delete any and all copies of > this e-mail (including any attachments) from your system, and do not > disclose the content of this e-mail to any other person. Thank you!