mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Pei Xiao <xiaopei01@kylinos.cn>
To: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev,
	openbmc@lists.ozlabs.org, linux-rockchip@lists.infradead.org,
	linux-riscv@lists.infradead.org,
	linux-mediatek@lists.infradead.org,
	linux-stm32@st-md-mailman.stormreply.com, broonie@kernel.org
Cc: Pei Xiao <xiaopei01@kylinos.cn>
Subject: [PATCH v3 11/17] spi: st: Use helper function devm_clk_get_enabled()
Date: Tue, 17 Mar 2026 15:41:53 +0800	[thread overview]
Message-ID: <96c8fbf6840c71f29ebcf37d7ffc68f297601c8a.1773733017.git.xiaopei01@kylinos.cn> (raw)
In-Reply-To: <cover.1773733017.git.xiaopei01@kylinos.cn>

devm_clk_get() and clk_prepare_enable() can now be replaced by
devm_clk_get_enabled() when driver enables the clocks. Moreover, it is no
longer necessary to unprepare and disable the clocks explicitly.
Simplify code.

Signed-off-by: Pei Xiao <xiaopei01@kylinos.cn>
---
 drivers/spi/spi-st-ssc4.c | 16 ++++------------
 1 file changed, 4 insertions(+), 12 deletions(-)

diff --git a/drivers/spi/spi-st-ssc4.c b/drivers/spi/spi-st-ssc4.c
index b173ef70d77e..0d653986499c 100644
--- a/drivers/spi/spi-st-ssc4.c
+++ b/drivers/spi/spi-st-ssc4.c
@@ -293,24 +293,20 @@ static int spi_st_probe(struct platform_device *pdev)
 	host->use_gpio_descriptors	= true;
 	spi_st				= spi_controller_get_devdata(host);
 
-	spi_st->clk = devm_clk_get(&pdev->dev, "ssc");
+	spi_st->clk = devm_clk_get_enabled(&pdev->dev, "ssc");
 	if (IS_ERR(spi_st->clk)) {
 		dev_err(&pdev->dev, "Unable to request clock\n");
 		ret = PTR_ERR(spi_st->clk);
 		goto put_host;
 	}
 
-	ret = clk_prepare_enable(spi_st->clk);
-	if (ret)
-		goto put_host;
-
 	init_completion(&spi_st->done);
 
 	/* Get resources */
 	spi_st->base = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(spi_st->base)) {
 		ret = PTR_ERR(spi_st->base);
-		goto clk_disable;
+		goto put_host;
 	}
 
 	/* Disable I2C and Reset SSC */
@@ -333,14 +329,14 @@ static int spi_st_probe(struct platform_device *pdev)
 	if (!irq) {
 		dev_err(&pdev->dev, "IRQ missing or invalid\n");
 		ret = -EINVAL;
-		goto clk_disable;
+		goto put_host;
 	}
 
 	ret = devm_request_irq(&pdev->dev, irq, spi_st_irq, 0,
 			       pdev->name, spi_st);
 	if (ret) {
 		dev_err(&pdev->dev, "Failed to request irq %d\n", irq);
-		goto clk_disable;
+		goto put_host;
 	}
 
 	/* by default the device is on */
@@ -359,8 +355,6 @@ static int spi_st_probe(struct platform_device *pdev)
 
 rpm_disable:
 	pm_runtime_disable(&pdev->dev);
-clk_disable:
-	clk_disable_unprepare(spi_st->clk);
 put_host:
 	spi_controller_put(host);
 	return ret;
@@ -373,8 +367,6 @@ static void spi_st_remove(struct platform_device *pdev)
 
 	pm_runtime_disable(&pdev->dev);
 
-	clk_disable_unprepare(spi_st->clk);
-
 	pinctrl_pm_select_sleep_state(&pdev->dev);
 }
 
-- 
2.25.1


  parent reply	other threads:[~2026-03-17  7:42 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-17  7:41 [PATCH v3 00/17] cleanup in spi by use devm_clk_get_enabled Pei Xiao
2026-03-17  7:41 ` [PATCH v3 01/17] spi: axiado: Use helper function devm_clk_get_enabled() Pei Xiao
2026-03-17 13:19   ` Mark Brown
2026-03-18 15:05   ` kernel test robot
2026-03-17  7:41 ` [PATCH v3 02/17] spi: bcm63xx-hsspi: " Pei Xiao
2026-03-17  7:41 ` [PATCH v3 03/17] spi: bcmbca-hsspi: " Pei Xiao
2026-03-17  7:41 ` [PATCH v3 04/17] spi: img-spfi: " Pei Xiao
2026-03-17  7:41 ` [PATCH v3 05/17] spi: imx: " Pei Xiao
2026-03-17  7:41 ` [PATCH v3 06/17] spi: npcm-pspi: " Pei Xiao
2026-03-17  7:41 ` [PATCH v3 07/17] spi: orion: " Pei Xiao
2026-03-18 17:04   ` kernel test robot
2026-03-17  7:41 ` [PATCH v3 08/17] spi: rockchip-sfc: " Pei Xiao
2026-03-17  7:41 ` [PATCH v3 09/17] spi: sifive: " Pei Xiao
2026-03-17  7:41 ` [PATCH v3 10/17] spi: slave-mt27xx: " Pei Xiao
2026-03-17  7:41 ` Pei Xiao [this message]
2026-03-18 19:02   ` [PATCH v3 11/17] spi: st: " kernel test robot
2026-03-17  7:41 ` [PATCH v3 12/17] spi: stm32-qspi: " Pei Xiao
2026-03-17  7:41 ` [PATCH v3 13/17] spi: stm32: " Pei Xiao
2026-03-17  7:41 ` [PATCH v3 14/17] spi: sunplus-sp7021: " Pei Xiao
2026-03-17  7:41 ` [PATCH v3 15/17] spi: uniphier: " Pei Xiao
2026-03-17  7:41 ` [PATCH v3 16/17] spi: zynq-qspi: " Pei Xiao
2026-03-17  7:41 ` [PATCH v3 17/17] spi: zynqmp-gqspi: " Pei Xiao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=96c8fbf6840c71f29ebcf37d7ffc68f297601c8a.1773733017.git.xiaopei01@kylinos.cn \
    --to=xiaopei01@kylinos.cn \
    --cc=broonie@kernel.org \
    --cc=imx@lists.linux.dev \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=openbmc@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®