mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Yang Yingliang <yangyingliang@huawei.com>
To: Alexey Firago <a.firago@yadro.com>, <linux-kernel@vger.kernel.org>
Cc: <alsa-devel@alsa-project.org>, <zhuning0077@gmail.com>,
	<yangxiaohua@everest-semi.com>, <broonie@kernel.org>,
	<tiwai@suse.com>
Subject: Re: [PATCH] ASoC: codecs: es8326: Fix DTS properties reading
Date: Mon, 6 Feb 2023 16:42:34 +0800	[thread overview]
Message-ID: <96c99731-a5e9-778d-24f5-cb42a5c2d840@huawei.com> (raw)
In-Reply-To: <20230204195106.46539-1-a.firago@yadro.com>

Hi,

On 2023/2/5 3:51, Alexey Firago wrote:
> Seems like properties parsing and reading was copy-pasted,
> so "everest,interrupt-src" and "everest,interrupt-clk" are saved into
> the es8326->jack_pol variable. This might lead to wrong settings
> being saved into the reg 57 (ES8326_HP_DET).
>
> Fix this by using proper variables while reading properties.
>
> Signed-off-by: Alexey Firago <a.firago@yadro.com>

Fix tag is needed, it should be 5c439937775d ("ASoC: codecs: add support 
for ES8326")

Reviewed-by: Yang Yingliang <yangyingliang@huawei.com


  reply	other threads:[~2023-02-06  8:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-04 19:51 Alexey Firago
2023-02-06  8:42 ` Yang Yingliang [this message]
2023-02-06 21:37 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=96c99731-a5e9-778d-24f5-cb42a5c2d840@huawei.com \
    --to=yangyingliang@huawei.com \
    --cc=a.firago@yadro.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tiwai@suse.com \
    --cc=yangxiaohua@everest-semi.com \
    --cc=zhuning0077@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®