From: Andi Kleen <ak@linux.intel.com>
To: Chen Zhongjin <chenzhongjin@huawei.com>,
"x86@kernel.org" <x86@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "tglx@linutronix.de" <tglx@linutronix.de>,
"mingo@redhat.com" <mingo@redhat.com>,
"bp@alien8.de" <bp@alien8.de>,
"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
"hpa@zytor.com" <hpa@zytor.com>
Subject: Re: [PATCH] x86: profiling: Using generic unwinding in profile_pc
Date: Mon, 3 Apr 2023 11:29:52 -0700 [thread overview]
Message-ID: <96d44033-3bfd-840b-15d7-80dd3a1a5313@linux.intel.com> (raw)
In-Reply-To: <dc0625d2-edaf-22fe-5eea-3088e95a2998@huawei.com>
On 4/2/2023 6:24 PM, Chen Zhongjin wrote:
> Just ping... Or has profile code already been obsoleted?
I think it would be reasonable to remove the locked functions hack since
lock profiling can be handled with much better other tools these days.
I wouldn't make it depend on the generic unwinder since such a low level
facility is likely better off without complex dependencies that could break.
-Andi
next prev parent reply other threads:[~2023-04-03 18:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-24 2:18 Chen Zhongjin
2023-04-03 1:24 ` Chen Zhongjin
2023-04-03 18:29 ` Andi Kleen [this message]
2023-04-04 2:03 ` Chen Zhongjin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=96d44033-3bfd-840b-15d7-80dd3a1a5313@linux.intel.com \
--to=ak@linux.intel.com \
--cc=bp@alien8.de \
--cc=chenzhongjin@huawei.com \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®