From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-m15596.qiye.163.com (mail-m15596.qiye.163.com [101.71.155.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 79915168BD; Tue, 17 Mar 2026 00:41:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=101.71.155.96 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773708074; cv=none; b=DgmpRKtpWCqFM8xYu3SUT2lUnjbfIqkuj9Wu3lm/B9tTpyIqDStzLW29LZYbMiwnj4E6gCB+nS3UtvRw+6osPPEjfgqIq9pHJYhPlFmnsJQp/muy5euEBJIsklVjx12m43e3p7F2jO6gfmHW6lzFEECLkewjPvX9PArCEhWGFY4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773708074; c=relaxed/simple; bh=lilTe0bvS3Uc+NqmL9ZMXFwkYh1qGomQvuDOl1Vm6vo=; h=Cc:Subject:To:References:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=Wnvks9LEsk6br8iJjLKA71p+8i1WpgHqWoXd8X+P6mULQNnuD+xiHvzWwh4W7oN6dLw1ONqJFuJqunZjGaTsPydgQLY6vGN9ghWqvLDxw5OoELo2N1TQh2wcibh1prhas5kV7Phyqx/12BVNjXgrlqKMSOKQzuYdP2ume4g3lng= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rock-chips.com; spf=pass smtp.mailfrom=rock-chips.com; dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com header.b=cUT7gP9v; arc=none smtp.client-ip=101.71.155.96 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rock-chips.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rock-chips.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com header.b="cUT7gP9v" Received: from [172.16.12.17] (unknown [58.22.7.114]) by smtp.qiye.163.com (Hmail) with ESMTP id 372d36eb6; Tue, 17 Mar 2026 08:35:52 +0800 (GMT+08:00) Cc: shawn.lin@rock-chips.com Subject: Re: [PATCH v2] arm64: dts: rockchip: Enable PCIe CLKREQ# for RK3588 on Rock 5b-5bp-5t series To: Anand Moon , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , FUKAUMI Naoki , Nicolas Frattaroli , Sebastian Reichel , Diederik de Haas , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/Rockchip SoC support" , "open list:ARM/Rockchip SoC support" , open list References: <20260316073621.39027-1-linux.amoon@gmail.com> From: Shawn Lin Message-ID: <96d6664a-5d6d-64b3-1999-b15579ff1aa4@rock-chips.com> Date: Tue, 17 Mar 2026 08:35:49 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: <20260316073621.39027-1-linux.amoon@gmail.com> Content-Type: text/plain; charset=gbk; format=flowed Content-Transfer-Encoding: 8bit X-HM-Tid: 0a9cf938725f09cckunma9077e0e407f16 X-HM-MType: 1 X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFDSUNOT01LS0k3V1ktWUFJV1kPCRoVCBIfWUFZGUweGlYZGBpOTRhNSBlKTU5WFRQJFh oXVRMBExYaEhckFA4PWVdZGBILWUFZTkNVSUlVTFVKSk9ZV1kWGg8SFR0UWUFZT0tIVUpLSEpKQk xVSktLVUpCS0tZBg++ DKIM-Signature: a=rsa-sha256; b=cUT7gP9v69WpsBFTtIuAAaSFK2LHAQxbA+b2qLMh5V3b08DXBWksI99YAkTl4qAKFBFgbF3BMx24jBTLDkK4x7kJuBAzLSuzOJaLT4auWIChio3RSuJQwLnGfhpRvmREAh7bdr4wWNjm8e3D1rKTonbw4iTmRWLDThf3hVqLJdk=; s=default; c=relaxed/relaxed; d=rock-chips.com; v=1; bh=uFg8XXcHtxFALcYZA+0V2jzBhaeA7BFfLpChxVZJYMw=; h=date:mime-version:subject:message-id:from; ÔÚ 2026/03/16 ÐÇÆÚÒ» 15:33, Anand Moon дµÀ: > Add supports-clkreq and the corresponding pinmux configurations for PCIe > ASPM L1 substates on the Rock 5B, 5B+ and 5T. > The supports-clkreq flag informs the PCIe controller that the hardware > routing for the CLKREQ# sideband signal is present. This enables support > for PCIe ASPM (Active State Power Management) L1 substates, allowing for > better power efficiency. > > Cc: Shawn Lin > Signed-off-by: Anand Moon > --- > Rock5b schematics. > [1] https://dl.radxa.com/rock5/5b+/docs/hw/radxa_rock5bp_v1.2_schematic.pdf > v2: drop the clkreq pinctrl for pcie3x4 as suggeested by Shwan Lin. > [2] https://lore.kernel.org/all/20260311115502.7353-1-linux.amoon@gmail.com/ > --- > arch/arm64/boot/dts/rockchip/rk3588-rock-5b-5bp-5t.dtsi | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b-5bp-5t.dtsi b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b-5bp-5t.dtsi > index b3e76ad2d8694..bf4a1d2e55ca3 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b-5bp-5t.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b-5bp-5t.dtsi Reviewed-by: Shawn Lin Thanks. > @@ -468,7 +468,8 @@ map1 { > > &pcie2x1l0 { > pinctrl-names = "default"; > - pinctrl-0 = <&pcie2_0_rst>; > + pinctrl-0 = <&pcie2_0_rst>, <&pcie30x1m1_0_clkreqn>; > + supports-clkreq; > reset-gpios = <&gpio4 RK_PA5 GPIO_ACTIVE_HIGH>; > vpcie3v3-supply = <&vcc3v3_pcie2x1l0>; > status = "okay"; > @@ -476,7 +477,8 @@ &pcie2x1l0 { > > &pcie2x1l2 { > pinctrl-names = "default"; > - pinctrl-0 = <&pcie2_2_rst>; > + pinctrl-0 = <&pcie2_2_rst>, <&pcie20x1m0_clkreqn>; > + supports-clkreq; > reset-gpios = <&gpio3 RK_PB0 GPIO_ACTIVE_HIGH>; > vpcie3v3-supply = <&vcc3v3_pcie2x1l2>; > status = "okay"; > > base-commit: f338e77383789c0cae23ca3d48adcc5e9e137e3c >