From: Markus Elfring <Markus.Elfring@web.de>
To: Henry Martin <bsdhenrymartin@gmail.com>,
linux-perf-users@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Cc: LKML <linux-kernel@vger.kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Will Deacon <will@kernel.org>
Subject: Re: [PATCH v2] driver: tx2: Add NULL check in tx2_uncore_pmu_register
Date: Mon, 31 Mar 2025 16:07:04 +0200 [thread overview]
Message-ID: <96d7676a-ade7-4250-be3f-fd11728c23ee@web.de> (raw)
In-Reply-To: <20250331135128.11881-1-bsdhenrymartin@gmail.com>
> devm_kasprintf() return NULL if memory allocation fails. Currently,
call returns? failed?
> tx2_uncore_pmu_register() does not check for this case, leading to a
> possible NULL pointer dereference.
…
You may omit the word “possible” in such a change description.
Is any automated source code analysis involved here?
https://cwe.mitre.org/data/definitions/252.html
Regards,
Markus
next prev parent reply other threads:[~2025-03-31 14:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-31 13:51 Henry Martin
2025-03-31 14:07 ` Markus Elfring [this message]
2025-03-31 14:32 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=96d7676a-ade7-4250-be3f-fd11728c23ee@web.de \
--to=markus.elfring@web.de \
--cc=bsdhenrymartin@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®