From: Jens Axboe <axboe@kernel.dk>
To: Christoph Hellwig <hch@infradead.org>,
"Wang Jianchao (Kuaishou)" <jianchao.wan9@gmail.com>
Cc: Bart Van Assche <bvanassche@acm.org>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] blk: do rq_qos_exit in blk_cleanup_queue
Date: Thu, 17 Feb 2022 06:34:02 -0700 [thread overview]
Message-ID: <96deb063-f4ef-fadd-543b-e905495898f6@kernel.dk> (raw)
In-Reply-To: <Yg392sqFydj9p3My@infradead.org>
On 2/17/22 12:48 AM, Christoph Hellwig wrote:
> On Wed, Feb 16, 2022 at 07:32:12PM +0800, Wang Jianchao (Kuaishou) wrote:
>> From: Wang Jianchao <wangjianchao@kuaishou.com>
>>
>> When __alloc_disk_node() failed, there will not not del_gendisk()
>> any more, then resource in rqos policies is leaked. Add rq_qos_exit()
>> into blk_cleanup_queue(). rqos is removed from the list, so needn't
>> to worry .exit is called twice.
>>
>> Fixes: commit 8e141f9eb803 ("block: drain file system I/O on del_gendisk")
>> Suggested-by: Bart Van Assche <bart.vanassche@wdc.com>
>> Signed-off-by: Wang Jianchao <wangjianchao@kuaishou.com>
>
> Ming had a pending patch to move it into disk_release instead, which
> I think is the right place.
I missed that patch and can't seem to find it, do you have a link?
--
Jens Axboe
next prev parent reply other threads:[~2022-02-17 13:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-16 11:32 Wang Jianchao (Kuaishou)
2022-02-16 18:25 ` Bart Van Assche
2022-02-17 2:40 ` Jens Axboe
2022-02-17 7:48 ` Christoph Hellwig
2022-02-17 13:34 ` Jens Axboe [this message]
2022-02-17 14:03 ` Christoph Hellwig
2022-02-17 14:55 ` Jens Axboe
2022-02-17 15:48 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=96deb063-f4ef-fadd-543b-e905495898f6@kernel.dk \
--to=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=hch@infradead.org \
--cc=jianchao.wan9@gmail.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®