From: Mark Brown <broonie@kernel.org>
To: Yu-Chun Lin <eleanor.lin@realtek.com>
Cc: gregkh@linuxfoundation.org, rafael@kernel.org, dakr@kernel.org,
baolin.wang@linux.alibaba.com, cylee12@realtek.com,
linux-kernel@vger.kernel.org, james.tai@realtek.com,
cy.huang@realtek.com, stanley_chang@realtek.com
Subject: Re: [PATCH v2] regmap: Fix race condition in hwspinlock irqsave routine
Date: Wed, 7 Jan 2026 11:28:34 +0000 [thread overview]
Message-ID: <96e4fa72-b9cf-4c7c-9485-a95f4903cdb6@sirena.org.uk> (raw)
In-Reply-To: <20260107032610.13166-1-eleanor.lin@realtek.com>
[-- Attachment #1: Type: text/plain, Size: 529 bytes --]
On Wed, Jan 07, 2026 at 11:26:10AM +0800, Yu-Chun Lin wrote:
> v2:
> - Initialize 'flags' to 0. This fixes a -Werror build failure when
> CONFIG_HWSPINLOCK is disabled, as the stub function in that case does
> not initialize the pointer.
> {
> struct regmap *map = __map;
> + unsigned long flags;
>
> hwspin_lock_timeout_irqsave(map->hwlock, UINT_MAX,
> - &map->spinlock_flags);
> + &flags);
> + map->spinlock_flags = flags;
I'm not seeing that initialisation in the actual patch?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-01-07 11:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-07 3:26 Yu-Chun Lin
2026-01-07 11:28 ` Mark Brown [this message]
2026-01-09 3:12 ` Yu-Chun Lin
2026-01-12 21:59 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=96e4fa72-b9cf-4c7c-9485-a95f4903cdb6@sirena.org.uk \
--to=broonie@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=cy.huang@realtek.com \
--cc=cylee12@realtek.com \
--cc=dakr@kernel.org \
--cc=eleanor.lin@realtek.com \
--cc=gregkh@linuxfoundation.org \
--cc=james.tai@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=stanley_chang@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®