From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752321AbdFPQ1t (ORCPT ); Fri, 16 Jun 2017 12:27:49 -0400 Received: from mail-he1eur01on0112.outbound.protection.outlook.com ([104.47.0.112]:47712 "EHLO EUR01-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750797AbdFPQ1r (ORCPT ); Fri, 16 Jun 2017 12:27:47 -0400 Authentication-Results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=virtuozzo.com; Subject: Re: [PATCH v3 7/7] asm-generic, x86: add comments for atomic instrumentation To: Dmitry Vyukov , mark.rutland@arm.com, peterz@infradead.org, mingo@redhat.com, will.deacon@arm.com, hpa@zytor.com References: <658c169bdc4d486b19d161579168a425b064b6f5.1496743523.git.dvyukov@google.com> Cc: Andrew Morton , kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, x86@kernel.org From: Andrey Ryabinin Message-ID: <96e64715-20b7-0aba-6bf8-ede926c804fb@virtuozzo.com> Date: Fri, 16 Jun 2017 19:29:28 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <658c169bdc4d486b19d161579168a425b064b6f5.1496743523.git.dvyukov@google.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Originating-IP: [195.214.232.6] X-ClientProxiedBy: HK2PR04CA0064.apcprd04.prod.outlook.com (10.170.154.32) To DB5PR0801MB2726.eurprd08.prod.outlook.com (10.166.176.22) X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB5PR0801MB2726: X-MS-Office365-Filtering-Correlation-Id: 7c4b981e-4aff-4fee-36cc-08d4b4d49d1b X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(201703131423075)(201703031133081);SRVR:DB5PR0801MB2726; X-Microsoft-Exchange-Diagnostics: 1;DB5PR0801MB2726;3:Nr/YgsTB4WE2tzKrKPBWZlDmxV+SOoDF8Ml6rAVpI4ku/RhZclGzZSnVyrwGaXhZGb3fkHyweeEGt5UfSC1rJEzY2K/my08TuFkkXaxzOTgoQIw5syfDlaf2//1DsEUYLa7kCbaJfq3CVT/tcKuc2tVjIp7BXHCSRsZHROtm8a1asbPUxxEt7goW2whluHZbcB95HO1ytp4ZhEhL10PS1PmFBNmOnNB1u/yEcXynjtekPaRnGQUhMzJ4d8BVSio11lhu3+elK+AuoM2z1pZAbxvu8LNYyjmuUo3U2YF2B+4PyA4V0DCrk7j9JQXGS970KrEEuDKqVEL5ea4BxMM4yQ== X-Microsoft-Exchange-Diagnostics: 1;DB5PR0801MB2726;25:FkrC7EpFjUE+1XRTWGyJDpBRK7zRnI8uEf7gspARynEa6ZPBSP4h9KaRIpgFEqFo/El9adh3ACrtnfrvazDnHFh1K26Cf72PfuN1k7EKGaXeDpGQJ2R4U7k20VraTiT4WxYsA4GvFx974YM7QWptKlRzQSGxZNh1Fsj3Cy9mXpK2AQhgxqlYfjbqlQX8T+WaRTZ0pcCBJRh7TUoShZ2seMe9qxKkJeegJCi6h8PnTphiUAg1aDyJKakkUEV3zKDU93/XJxJzZVh+uFhzMrFg1YXEyv457lhb8Rn9v0hrJktS0AUcMR727I8PHvOZpyXER8YAtWTACVnh3v12CvhjPork3vEYq635/KEZzSb/F4sVDS69J4xLbG7h9klgaMojteDOzhTD1DesgnDG3DWkpKurFNWAF77ushZipSn+5IlXb93XX94bUDBOWPPwV4fXdnZpyZfdyrQRdfIalJSd5+35hm2q/LIS/s0oBZriqoJrVGizkIFIFphPPG24MsW8OtyUYZzXKqdA1g25KLf8gEI9WCF9aBsDcKHdeUliPs3hPAvjswK3KA5Lv9a9Foeg28m4+3bNfmLlM8M9IULcDLBULXTFiXu6pPbKtZ1a4EiVz87k/pGSDJYg/KB8raXvvjz42zDAw1J2RM0u8m/qWXHu1XI4c+Eqv479ZSsArjPE0bsBJaux3Lc3oiovSAVEktiB61AP/WfaLW9bqZIs1UCu6OLgdBCiWCEMv7fJa74zuA+2pIW1Y1YCWAfS+3oWV8aG7F6BrdBSXov7TuN430UogDEm8Oul3b/AyaTR7NoYbqEqrMJEJgjUebVj6L7YxRyh6BDDh/+YdvGL3gTYfgHBC+gwejX3LCJ4t6RMaiLsSF5xRbN4R1BIHhLwQVs6iAv1Ei/RaPdNSnAGxKVpBvixZST7rHN9221yz74aqSk= X-Microsoft-Exchange-Diagnostics: 1;DB5PR0801MB2726;31:q/pE2VBaYEFnC8TdaVr5J2zF+EC42Plfl12OQlyb5M377MgJupva0H7utiop/N0runu7f5HoBIjccebxUcb1c/pCN84xoUXYrv64Y1hCL8bp0m+oHTAacWR8mvqAiaIoUuSuM9RVpL8jXesDh7he/wWSe/det8cO5cihZJcJUlF2WxyjcuPRNIHf66yKfiTudq/rxF4j0ZqanWU6ZKXuoB9+skBOmqPiIzfBpsyJxUEwxk11BextNVNRahfvjQn3H5Bop5JHJILdTAKyUycw8Pkj9Ml5fUlxaOx0t1EWoGp862W+0bPWn/dJucD1G0LJ+u4AZWOpxGdbsBnFFhd8iq/FmUz+QfPY8VZzNtb/u0xVrvpSyF0Fm30xXBy3AA6Opk2z80LrQOKA9N08PXMfau/G1GaG44KMdoxLJcF01jhvzDedrr2nJI0UEJvVOybkN3T9XECsUFqG6LZQrohNPQhfBf0ZR/5cxqK1XZTKd78moINpCsZSSIuDBu10RfoyiOc3Uk2jKCugAMh5iSwzj3LU/1sLOQlF+L8yqcW9cOauAoGCPJcGmB564K77LOtMlPYIXAB6RYRAOLwkOflrHCgdcLXHJeVJVW6Nxs4+3oI1r4fG8L8B4qcb7EPdDMsdsBXSd/ezEvxDUhJIif9H6YMZ9Yx6qx+61wKeAK/95FZ+pIZux1BcMDb8Y2jnWLxg97TbD0ohSZIfAIB6aNuOcw== X-Microsoft-Exchange-Diagnostics: 1;DB5PR0801MB2726;20:YxjKEHhOtJ0KIMcSQ311xnZJBUDZjt5Eekka9jCck7ZsdrnqGvE1MH6hTKWvuGoU7+tQFh40azxYrcfWw64kr31GVDn49pqTRjaei8MAW/zg5Z0KR5sAQjOqsZXHN85keVaGTSKOQX3e8lejdCabILtUc5L7733A23Fn7KTm6cl+D0UMacs3102l1ySkuh+tBQw3nsLVEzjVuLObUSING8n//GwZ4NfW7Wulkad2id8M2Ew5j6MHpGlfcshkR9OIgK2aPxTTZBrTFySanqvk2pCWqAIDpFlo1i9guZ5AZB1zMzoXBVCJO4QIxqxAlIvMweLF6ejVHPLhnaF1PjJQXeE9/rqD1ztSVGzq/o76Mz1euWEYavraHmTfR9rZ3csWCeGbTkUSzD20j1x+8Xn36sHuHbqnOa782w97RAUf67Q= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(215639381216008)(180628864354917)(9452136761055)(211936372134217); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(10201501046)(100000703101)(100105400095)(6041248)(20161123558100)(20161123564025)(20161123562025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(6072148)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:DB5PR0801MB2726;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:DB5PR0801MB2726; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;DB5PR0801MB2726;4:uQ/nryGgETzK1sWK10lVLAo1dPR2EekoRKP+?= =?Windows-1252?Q?yse0mkRa9leBtFqzgZZrwdME7fsNQpO3WbFMAPK1jp6Td4kJyo+Vf5HM?= =?Windows-1252?Q?uH3ZoFa0RR9aAjolQMG57yUF1fUoOSpIfOm+N04CDoDUZwUqqXUOMxkP?= =?Windows-1252?Q?aQvz4PSgtFZ6FwMbCRA16RdU2fCS2ShZqPheGfMHErqOAwPTZCRx4lGA?= =?Windows-1252?Q?vYU+QZKljZwSa/dlrOqdz7Bc5oy/svlQQzVmP1B+sNp+KVg7FuA3MV9R?= =?Windows-1252?Q?5PLpEes23Pl+8t56KXQEZZI3PCO6KDN1CJJ9p5STUHkxniNAB4PvJqyj?= =?Windows-1252?Q?9xTou4XNO/fz8Ud7L8OjkJojrYlZEDB+T3Zv8pDFllWWncGcX6tEdGt5?= =?Windows-1252?Q?lwRzzy8ApXm5gQzgOeAwa4L5ECEJec9dLsMlOy3NzzLbYJ2bauRpiugK?= =?Windows-1252?Q?nAc/aAWupAYGK6T/3s8DCi7CYZkSZgI0fTg4mqsP2Ut1D3NYzRjWX6Mx?= =?Windows-1252?Q?GQ+PUtZXNKrF/UksMJ/btlpe2IdP6vsMDqaA2FEfcXVAAbt7VNa4z/s7?= =?Windows-1252?Q?ZiL5mXQUpEsvdKcS/FKCwf7OnTkRgUOAMpFv28xcTZ/NzGffo3a8vR31?= =?Windows-1252?Q?PcrZW1/G6Ja1VdXqlPX4EqKTPWK+XLDMfGwE8fRmYmCWhyqpwFO7BiJS?= =?Windows-1252?Q?y85QCCZu+eD+QzEfMGfM5mCXyIeFVA8fhkojZyxBoP32zionqrqalhVa?= =?Windows-1252?Q?ZwjLAtSmYbMjQn7nchmOTVrKpo+4RjemaerEG+NA3+c7tAdc6+Q5uyN4?= =?Windows-1252?Q?avc4jKT9nrw/H4ELLI8yYoQRgPCEUlG/HEqdLfoG9X71AskuD2Uxpve1?= =?Windows-1252?Q?+vkcHo+V75Uw2G1UgGFG0biDHfGYW2ewJeUztDJi4toS0NF74feboo/A?= =?Windows-1252?Q?LX+9tkUURMttr4qCtbTuTfH1qIjKbo9gTopaynhPEXPxVlmHpuWJaZNw?= =?Windows-1252?Q?yfI7XryW9z4sKrVEDEelH8Ml+UOa1XhazJyYjEoGUSa91HeCWNOAi3az?= =?Windows-1252?Q?zD7DVBZ21iMy7OcP2IjZS+p6JxbLGlkFEpqtZaEAv28Z4elsETo2ZR2p?= =?Windows-1252?Q?ZCfCkTu+CDl0ydFx3HwRgozqjZw4LFdGsD7uXbp4rEleNH+BoVq/Oc5h?= =?Windows-1252?Q?3LBlDnNZxb3Na1YKhsRXN+pBSeN3MNbhyPJz3v+X3yXDtOi2+Kw6jn0O?= =?Windows-1252?Q?lttEtPTPoFXgDVUt5n43K9yHGqPWE2KSIGXazMte/FwZY7NNhD5D+txJ?= =?Windows-1252?Q?MOehsNuCTdfuKBPSTbdqUp3Nj8f/dI91s8SHFpfhD/Sku7JEPfHMwMwl?= =?Windows-1252?Q?+mEeqjXgLBbtmjtovySr5hxrPnj5eHu4Vw=3D=3D?= X-Forefront-PRVS: 0340850FCD X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(6049001)(39450400003)(39410400002)(39400400002)(39830400002)(377454003)(24454002)(229853002)(7736002)(64126003)(83506001)(2906002)(23746002)(50466002)(110136004)(38730400002)(6246003)(6666003)(2950100002)(305945005)(36756003)(53936002)(77096006)(478600001)(189998001)(7416002)(31686004)(47776003)(50986999)(4001350100001)(31696002)(53546009)(25786009)(66066001)(6116002)(76176999)(3846002)(4326008)(65826007)(54356999)(33646002)(230700001)(5660300001)(42186005)(81166006)(86362001)(8676002)(6486002);DIR:OUT;SFP:1102;SCL:1;SRVR:DB5PR0801MB2726;H:[172.16.25.12];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;DB5PR0801MB2726;23:OxZpoX68aQhwfNCNl+x2aPcoY3Q4dgPrazq?= =?Windows-1252?Q?ZUGGB8tqqQTY6i1hO0GkVRpI5jLOv3C5J131pB4lGx1jlbCdNLAEaQs3?= =?Windows-1252?Q?DTf8FP4cdTo7Pp65aJIbUS6kFaHNQRzbqjEgr4Wxsb1DszCLRP0sQ2/C?= =?Windows-1252?Q?VHYxh6J+KNzTx18W5hqoTLIGKqcWf5qVW/e9rldcm5KdyWQ6GqvNcxss?= =?Windows-1252?Q?0As7nXH743OnebXbNQhYrtk3ZvMhEgyNQL1jYhGoWBKxi8GQaw3X+H9Z?= =?Windows-1252?Q?pZeqaE2lWinI7CO/VRxKYPvmpU/6hiC3I1e9iKz0QE+qLziBOJ0e97Fy?= =?Windows-1252?Q?RLRBzSie328+Rw/Mn/PTYV6hQK+olVkZm84xkD8sUXBQjIWAw1KkEUv8?= =?Windows-1252?Q?YSQyDcYTUGlXkhOA0eaXX0PssDzvRYnKqiJOHPWfB5igk472a0VvErNS?= =?Windows-1252?Q?2s1NOj8CIFFWfp+fK4qDH36LJlS0CkEp33U0lwb9/nNWLRTLmR0xDJL0?= =?Windows-1252?Q?OY/yON5a8MLBaj6TgfXe3doPVTOtxcqUl6f0KyYL8rVXfPNUqetq8NoI?= =?Windows-1252?Q?1sngLaI0kyrTXMi+AnO4xtV15GjWfiVgZnhKx21TBhQ9mFWln1+ZU3lJ?= =?Windows-1252?Q?21BVLNunfyyCSekI3MNKCRNdtA7FGGtrXyvlrrVIWXm2wpdLjf2D3HUA?= =?Windows-1252?Q?263ZdhKADayJWNb1h63vxnZgrWPXA93OyoyL80KCqLYJzD5ZAch6J/1n?= =?Windows-1252?Q?qzjpJlUhB0xM+7klTDmpbgQ/aDCMJm3d/ac/lHyEwBiDfesQw4dTqLvQ?= =?Windows-1252?Q?SNeR4DdxuVv7OPLvbmPfhz/XGI27FF/AeHY0qdbhA0gZge6KOW4nVS78?= =?Windows-1252?Q?tY/pHHW9eq/akQBgBVTPVjUU/8y9Nrp49/M4yh/EYQXAV7+iex5RDneM?= =?Windows-1252?Q?DWJijxUgbMODYo8MheVDLlJr/jG5qqwZQfpdxiWbFfQdWR+ZmYdjJVBg?= =?Windows-1252?Q?iXQpwrQ1e+m67/OKxDmlE7jqUgTLD5kLStifhMAM+qDrhHiiSvKexB+W?= =?Windows-1252?Q?9Cbso1DwNqQbyWH0FeYuGcDNFsnLwvf+CT0Oo+LCsmJgf2WLcZ4JomJ8?= =?Windows-1252?Q?vZ5aVk2Umg1mLJtgGFRVE4kay/7l91EjfAc1ELwMJSc/2WBTAtZRrGYJ?= =?Windows-1252?Q?SBnbsnNZnlOjISe1PevsdKjdd6N+X2/Cu6XaB01RaXj+SPnGcshEGGrI?= =?Windows-1252?Q?NA7mLjr+EBTRRbQqn5zX/qMDrarnvE2H/ebGenhKGRVG9l7sal+H2+J/?= =?Windows-1252?Q?WtNDbGerGoC8fBZfAVzF7OhjN9WV0ahszHgcNRUN8Vapxd+8=3D?= X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;DB5PR0801MB2726;6:X3UO9BN8eM1vLIsHHT+lDuJi4giAoG6EmZCq?= =?Windows-1252?Q?MI3bmVIXJJu24JE59l3KKL+Gq93ZmXz9hENtTzrBNR5Q/qWRBX0eiTx7?= =?Windows-1252?Q?nsynqRY6M4uYVP5+D7nzdo42YaSj7b6+wqNNcXnjYIe4Wfy0Vpr0FlVS?= =?Windows-1252?Q?cD41IRL6zwtF0/GplvvTnarF32AoN6Lh3xlejYlwwYu2XAqt5+EDYDlU?= =?Windows-1252?Q?yQ28kYTb2HDyipHfZr+etpm8kAUlcF0v7UEHgT2SRfXhkSePkuraBgaM?= =?Windows-1252?Q?C4FT/5kS0OsNQuELOtOfiuvqrtJh7OUQf7JKlGwK1fMwpTh4wddQaYHw?= =?Windows-1252?Q?8WyP5fQB4HU2xpmuwHbgJPicnKhYZDA/8mPJQw/DYE9bKQwsf6tjESxq?= =?Windows-1252?Q?Jvyc0UIgDo14NgKhzdjBemNTh6Qas62UX5dJ+cx09Yo4cFVhXTw4o/ll?= =?Windows-1252?Q?K2mj8K/RP2d0AW07qWvGRqhciQZd5TbR+FzEjMdz9SvuQBM1SKbT/0Ue?= =?Windows-1252?Q?Y3tM2E1xRsvoT069QtkZoUDByjk/z9U7v+vm/k5qR8VKDVPfu2ZEInfm?= =?Windows-1252?Q?CNaQ+R8Vj6ugHI8Y0lZCGjgPlTxPBP2v/lfWoebN98a2b8luGqW3DA0v?= =?Windows-1252?Q?vTRqNWwCsnmPtn0ucYLdXeppcZ1lBx3/wlPgp7yjfQ49aotOIhuvbiA8?= =?Windows-1252?Q?V32+BYTYsQYL2sn8yJ8byv/696KLf5BgBf6U/auGNEkOKwgB/Y6l7g42?= =?Windows-1252?Q?Vo+2ECESJA8wh1Ri74LRBAJZX2AFUAYM7Tvb3YIBmhX1VaLh9VHKHUGb?= =?Windows-1252?Q?1SjnXumHkJdMH2fXJcSyzyPmrToj8b9IMVHA4lyozJ02mZXvbsHI4MbC?= =?Windows-1252?Q?/ul06JYrqCzifqnhFqOt4Ka/CPWe/Rjw3V6bfdVBQjnhEgg3s8YCY6GT?= =?Windows-1252?Q?0pgNc/mNNxb+TyO8Fl13OgjjL3c9AIrL2ARmOqeWEmqiWuS08b9fuwVW?= =?Windows-1252?Q?7WxNmr3qVGXsDQL+ZZpDI0leNvvM66TR1FkNsuvbUPXXb7LOUumjtdnD?= =?Windows-1252?Q?dpPRWaPLloMGXoI=3D?= X-Microsoft-Exchange-Diagnostics: 1;DB5PR0801MB2726;5:G46xBqTHupZ5Rf8v/oksLpk289kp+2cHuYVcls6xH/sM/MkS9TQ/oC67QqUBYWXO/IPVVDMdw+nzxsA/16LFDNo1AlF1a4xMEy+so0LECcAlqkFU6dTPOEN9VYzVy/M/tfTlI5gRUOxlzgzW1WU/odO9/ZOPNlYW9AUP338NQfULkd8BNdldyt6AuStBpHNBYahNUucuwcXPeOgjI6MLE7TBx7zKPiRNKaauxp2hMakgIa40nlMTgy2EJrW7sZhY7aUD9mvGFSXaVaprAHYSsfOUw8ZWVF3M+D8TKZWEHsQzBvZFHTJQqbKs26IWsu6mKo6O8MR3Y0JLCoQqLW7WEfBEKzmJtJzmy6IDCsgD2t6jorrOgF9FOSjK35fFeH+jOiNJSc7tVwfN7fK1FLCKxiTssQSKiKW1EM448Xwp38ViOTX24NAkZTmyRdfaSUS80YvJUU3NaeneTPzJHi5LIBwfJU4fHxp4mFqo3yQBtXD9NaME9Fvmi4HbyXJeSf1i;24:HuZWaHt+D/puyCnZGNo0zr/QwbfyPk1CfrAgepYfu/jsQO+qIWr95qAPS78QiiLMCmsEzrR7lSh0bp4h96hM3nDlwidX+m3s6RJCN9WMrAM= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DB5PR0801MB2726;7:rTdbCp1nItesQZ4+AK+x3JHjDACRbhV+fVtOf/+XIhZ8dZzON+T2Ohv3PqRn3vOWRHWHPrEV43MkmQc56Ldjfz/tZMau6LTnPAXyNzWaUtNinqMauCJziiYG2wqAkGPsguF+thhivn0PGZBnCzzXSDY9gwtL2iwWozQyverJ7xeLOsDq07/ZUQChWl4+Nck5xMSFc9ticWLhMrczQXLqzrmQj1Sy2SnvqxlR4Lg9WJqEMYNRHydeFpfErILNkgHSec3pxYOdG46x9H2txuyfTtuGu0GOKic9P/ksTf2c20og7jjkfiimMmyIc3qcSQwdhXv8ZSoWk9LXou9XrXKk5rPvgGFXcOeIvN81ilyifz+j07+Ul2dEX8yILkeGljNa3axHjMi1DVSSXhb+NGX0bfwOJlwOFaW/PIIt6rpl7+koRaPrrj5Aqk9bH+nO6fwYhY7BYp/SHb3LREh5+WkSJ5wNj/agPHZsmEGL6rAqg0K6i7mvPfY6Icr7tZpLUiH6CPYDf+83fvNKrDuUgsKNRT5bVEdJpawWXrxOF2jnQsaLg169v9Sr9RSJHJWDVwBbKRPUZTGppbBwTwSmB+9lmVQJH09Ph5u5Sem3fyjlpeBB0cbn/prnMmo6yQ4xwB5RoyYtcYdJAHqzWFXH3BEq4GGN9Xl5n3KyZ7BcDp+vvTKBWqubfxEVYE3213b8FfUbO4s+NmDOs6ZKSYWNQkVRYDJJ5DteNAWBqAYxtxMB1iU2Yajbxxa0wDN90wDy/l/ttQ4mwo3zKYIy8Myyt0gCVgTq6EMyVcePpn/UT6yg6Gg= X-Microsoft-Exchange-Diagnostics: 1;DB5PR0801MB2726;20:pqKuMj/m9IAj+BR2QmxUXw1ggKR1D31UkmJ3KgnyL3u40TZuqgo/Ejs9u8WH+FOXtr5BGdPw6nFHsbN2+qq9bkakvY7Cucxq6zOrjGfsMch37I0j3Y8PqiKqzlq1NIS2lMS6Re+CInRSSsqhd3LvmFrznBwgVqzlaIdLl6RNMkI= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jun 2017 16:27:36.2171 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR0801MB2726 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/06/2017 01:11 PM, Dmitry Vyukov wrote: > The comments are factored out from the code changes to make them > easier to read. Add them separately to explain some non-obvious > aspects. > > Signed-off-by: Dmitry Vyukov > Cc: Mark Rutland > Cc: Peter Zijlstra > Cc: Will Deacon > Cc: Andrew Morton > Cc: Andrey Ryabinin > Cc: Ingo Molnar > Cc: kasan-dev@googlegroups.com > Cc: linux-mm@kvack.org > Cc: linux-kernel@vger.kernel.org > Cc: x86@kernel.org > --- > arch/x86/include/asm/atomic.h | 7 +++++++ > include/asm-generic/atomic-instrumented.h | 30 ++++++++++++++++++++++++++++++ > 2 files changed, 37 insertions(+) > > diff --git a/arch/x86/include/asm/atomic.h b/arch/x86/include/asm/atomic.h > index b7900346c77e..8a9e65e585db 100644 > --- a/arch/x86/include/asm/atomic.h > +++ b/arch/x86/include/asm/atomic.h > @@ -23,6 +23,13 @@ > */ > static __always_inline int arch_atomic_read(const atomic_t *v) > { > + /* > + * Note: READ_ONCE() here leads to double instrumentation as > + * both READ_ONCE() and atomic_read() contain instrumentation. > + * This is a deliberate choice. READ_ONCE_NOCHECK() is compiled to a > + * non-inlined function call that considerably increases binary size > + * and stack usage under KASAN. > + */ Not sure that this worth commenting. Whoever is looking into arch_atomic_read() internals probably don't even think about KASAN instrumentation, so I'd remove this comment. > return READ_ONCE((v)->counter); > } >