From: "Thomas Weißschuh" <linux@weissschuh.net>
To: Tzung-Bi Shih <tzungbi@kernel.org>
Cc: Benson Leung <bleung@chromium.org>,
Guenter Roeck <groeck@chromium.org>,
Sebastian Reichel <sre@kernel.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Len Brown <lenb@kernel.org>,
Robert Moore <robert.moore@intel.com>,
chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org,
Mario Limonciello <mario.limonciello@amd.com>,
Dustin Howett <dustin@howett.net>,
Stephen Horvath <s.horvath@outlook.com.au>,
Rajas Paranjpe <paranjperajas@gmail.com>,
linux-acpi@vger.kernel.org, acpica-devel@lists.linux.dev,
Matt Hartley <matt.hartley@gmail.com>
Subject: Re: [PATCH v3 3/5] platform/chrome: cros_ec_proto: Introduce cros_ec_cmd_versions()
Date: Tue, 11 Jun 2024 14:14:33 +0200 [thread overview]
Message-ID: <96f0d632-7fdd-4fca-9528-449440d72f5d@t-8ch.de> (raw)
In-Reply-To: <Zmg2iwOWRZdCybxw@google.com>
On 2024-06-11 11:35:39+0000, Tzung-Bi Shih wrote:
> On Mon, Jun 10, 2024 at 05:51:08PM +0200, Thomas Weißschuh wrote:
> > +/**
> > + * cros_ec_cmd_versions - Get supported version mask.
>
> I guess we would like to call it something like "cros_ec_get_cmd_versions".
Ack.
> > + *
> > + * @ec_dev: EC device
> > + * @cmd: Command to test
> > + *
> > + * Return: version mask on success, negative error number on failure.
> > + */
> > +int cros_ec_cmd_versions(struct cros_ec_device *ec_dev, u16 cmd)
>
> Could it support a "version" parameter as existing EC_CMD_GET_CMD_VERSIONS
> usages use both versions? An `u16 cmd` parameter and down-cast to u8 for v0
> should be fine. (ec_params_get_cmd_versions vs. ec_params_get_cmd_versions_v1)
Ack.
Or we could automatically use v0 if cmd <= U8_MAX?
next prev parent reply other threads:[~2024-06-11 12:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-10 15:51 [PATCH v3 0/5] ChromeOS Embedded Controller charge control driver Thomas Weißschuh
2024-06-10 15:51 ` [PATCH v3 1/5] ACPI: battery: add devm_battery_hook_register() Thomas Weißschuh
2024-06-13 19:33 ` Rafael J. Wysocki
2024-06-10 15:51 ` [PATCH v3 2/5] platform/chrome: Update binary interface for EC-based charge control Thomas Weißschuh
2024-06-10 15:51 ` [PATCH v3 3/5] platform/chrome: cros_ec_proto: Introduce cros_ec_cmd_versions() Thomas Weißschuh
2024-06-11 6:32 ` Tzung-Bi Shih
2024-06-11 7:23 ` Thomas Weißschuh
2024-06-11 10:14 ` Tzung-Bi Shih
2024-06-11 11:35 ` Tzung-Bi Shih
2024-06-11 12:14 ` Thomas Weißschuh [this message]
2024-06-12 2:25 ` Tzung-Bi Shih
2024-06-10 15:51 ` [PATCH v3 4/5] power: supply: add ChromeOS EC based charge control driver Thomas Weißschuh
2024-06-10 15:51 ` [PATCH v3 5/5] power: supply: cros_charge-control: don't probe if Framework control is present Thomas Weißschuh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=96f0d632-7fdd-4fca-9528-449440d72f5d@t-8ch.de \
--to=linux@weissschuh.net \
--cc=acpica-devel@lists.linux.dev \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=dustin@howett.net \
--cc=groeck@chromium.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=matt.hartley@gmail.com \
--cc=paranjperajas@gmail.com \
--cc=rafael@kernel.org \
--cc=robert.moore@intel.com \
--cc=s.horvath@outlook.com.au \
--cc=sre@kernel.org \
--cc=tzungbi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®