From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 060D8CA0EC3 for ; Tue, 12 Sep 2023 07:20:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231521AbjILHUd (ORCPT ); Tue, 12 Sep 2023 03:20:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44912 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231316AbjILHUc (ORCPT ); Tue, 12 Sep 2023 03:20:32 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id E8DBFE79 for ; Tue, 12 Sep 2023 00:19:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1694503183; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UcEya9HqsW3o+5ldQKv7HTPg9J+Z7fGPS0QxHHzAjY0=; b=Llhd2xeNnpjLByHP4tUI6MoGML/jPRat3EwY7wLIXtprvvu4h7/2H+3gAL3Q5N4ETSiiBw 6RVrXqFnPstkSiuz34AzxLExKlOmL8dVbhtAmMfqsP4F7gBPv+KF5CJ8Efov725ygPnhYJ y9Pq1x87EWk1IwFQEUpB4KSbJtVvWxg= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-269-WWxy7iiLMsOOy7XJdFh8Qg-1; Tue, 12 Sep 2023 03:19:41 -0400 X-MC-Unique: WWxy7iiLMsOOy7XJdFh8Qg-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-401ea9bf934so41666735e9.2 for ; Tue, 12 Sep 2023 00:19:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694503180; x=1695107980; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=UcEya9HqsW3o+5ldQKv7HTPg9J+Z7fGPS0QxHHzAjY0=; b=X3Uyn2C579Px5FWuk2NXVAhnlmJ8nk66h67KC9mWFtOvHsC9EGJqMHIpI7BTad+o12 FGEc9e5Kg0Oe+DiCkN+QG8CsYvRtuZSBMSZZZo+ukg5y4SDS8exJX0IdFGXa+TKIMYQ+ 8QhUkWPBjq0Ue9/b9DYqn/UkgRRxEYyLrSOo4kscWcflhOWuYGw0rHL8gpqQ90xkp4uv J/Xqt45CP3fsEyEZi9xz6XCvRUMgSnc7qq5vYQ8wtvjO9R+kDvyIuKGOfHshtf8pGowv HN39qcluzfBicHpB6pMKH/S/Ffm3QwBIUVS6A8Ruw1MqBoEWxRFFKzGy7Ejymo0lAssU 8I1g== X-Gm-Message-State: AOJu0YyJGnRNghnyV5owmyZqxfpjUdjauoFgEnmUv/69aFpzmdkkqXZM Kw85dhU7Y6cVkS3/GpubzoTsCmp598KXxID27pLSk5qFb8tOMjONqQIz4YxDnWOukavFwJoga/y oAbgBgMeZBvhkzyoVoVo2RJKN X-Received: by 2002:a1c:7c0e:0:b0:401:6800:703c with SMTP id x14-20020a1c7c0e000000b004016800703cmr11272009wmc.21.1694503180596; Tue, 12 Sep 2023 00:19:40 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFBHMbRtiRZlVheP6qVSb8MqZ6oMl+4dwmRZR30fLEhp0pib6sKRWhTtFCZOTZU2I6KyZfYPg== X-Received: by 2002:a1c:7c0e:0:b0:401:6800:703c with SMTP id x14-20020a1c7c0e000000b004016800703cmr11271987wmc.21.1694503180236; Tue, 12 Sep 2023 00:19:40 -0700 (PDT) Received: from ?IPV6:2003:cb:c74f:d600:c705:bc25:17b2:71c9? (p200300cbc74fd600c705bc2517b271c9.dip0.t-ipconnect.de. [2003:cb:c74f:d600:c705:bc25:17b2:71c9]) by smtp.gmail.com with ESMTPSA id g17-20020a7bc4d1000000b003fc02e8ea68sm15188204wmk.13.2023.09.12.00.19.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 Sep 2023 00:19:39 -0700 (PDT) Message-ID: <96f124d6-c1f2-adb3-1d3b-8329e85ff099@redhat.com> Date: Tue, 12 Sep 2023 09:19:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH V2 1/2] efi/unaccepted: Do not let /proc/vmcore try to access unaccepted memory Content-Language: en-US To: Adrian Hunter , "Kirill A. Shutemov" , Borislav Petkov , Andrew Morton , Ard Biesheuvel Cc: Dave Hansen , Vlastimil Babka , Mike Rapoport , Lorenzo Stoakes , Tom Lendacky , Baoquan He , Vivek Goyal , Dave Young , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-coco@lists.linux.dev, linux-efi@vger.kernel.org, kexec@lists.infradead.org References: <20230911112114.91323-1-adrian.hunter@intel.com> <20230911112114.91323-2-adrian.hunter@intel.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230911112114.91323-2-adrian.hunter@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11.09.23 13:21, Adrian Hunter wrote: > Support for unaccepted memory was added recently, refer commit dcdfdd40fa82 > ("mm: Add support for unaccepted memory"), whereby a virtual machine may > need to accept memory before it can be used. > > Do not let /proc/vmcore try to access unaccepted memory because it can > cause the guest to fail. Oh, hold on. What are the actual side effects of this? Once we're in the kdump kernel, any guest is already dead. So failing a guest doesn't apply, no? -- Cheers, David / dhildenb