From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com [209.85.167.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F00CA154BFE for ; Thu, 11 Jul 2024 12:19:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720700367; cv=none; b=JvpJhePDDzON1knRejc+FXrMtuOaoWrTPTDHWryCH/nwaLOjDUFOtEhgEM1FDdtIQgoiBombo4SJrdN5SBpHSAS1TPhWv9uRGvwR9WwIaFbeHtqklfUqFEogZ94tWEYe5vhQPgeqm+ATmxMYvhU936S33aEhe4/Dnlqx4hkP//w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720700367; c=relaxed/simple; bh=ShoApCPFJ8OT++92dM4/QSOnjbYm8rOtDQtsUkF0IDs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=t7HPR+aAvTVPzjhLgQb0H8zO8qkYH3Q//PSf/RSHsxvqjfMTx70a28RMIOmY9IzmSPeURggUjDQiaYB5P0EcBVejj/qZqrsI8I5/Kjq7GnwtT7s/I36u+/5yp4B/ACgBIO6oyVCGvMTO4O11jN8bcq2jeX43nfkzpZYdH55qHGA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=qWuobwHA; arc=none smtp.client-ip=209.85.167.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="qWuobwHA" Received: by mail-lf1-f50.google.com with SMTP id 2adb3069b0e04-52e9a920e73so882198e87.2 for ; Thu, 11 Jul 2024 05:19:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1720700363; x=1721305163; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=3+9tg0Li/AqyrMmzIO9QGRt9whheokHUzC6WmLohbNQ=; b=qWuobwHAB/UQxev8J6cFDYyE4w7/ImR98tP/glecydPVFUpcIJF3dwe3aKBWm9dYMo itgldbEvkShKCjZihHUMlNJg24fYf/4y4ZXQlVNM8wjDIhD+d2GYmE0A5XVa1Ex9kRgW OzdKaEoRTHcyhkT7HuTrOX5EaVm9zn9WPAbwDYFwqLokv8vi69ahQqD5rmgy+zej1gf/ qVWxOqURCTRUpm80qNKsJJWdCrmXyC0Wrlq/clxF7sHM1E+P8k6GSIMQRKIaJnR+MEwM micVf+Uequzf/p9ey/Nq1xolMnzwlSijW3fesrMdeRJUQFG2VTM1HlWFQ4RG36do3+BE n2KQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720700363; x=1721305163; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3+9tg0Li/AqyrMmzIO9QGRt9whheokHUzC6WmLohbNQ=; b=s8ykeiMPubs2Jarhw/2QBElQ8nNwY5HA4kujU2A9kSalieEHJfgB0le56dsPy+GnWQ hSop8eqiaXxQd7y/ffOQ6XBO1dkcdXnWgClP7S+aKhU3ahfEAggHbWCzXRQm6DcTyuwY fWEawAnFFy61dnqnoe79R54PsjTUqradiftAXnHnu0ERGIkKw97NN2xvkD30WRSj0fIB 6fP0CIuy0CCHcOaBv1J6qi6n6UjCMBHjkgKL2NuCWiZzzECRAl2dNVJI2rBsPrZdd6QG NozqbxDlBUOw+cJLOrIXZeYhBM2zTbv5KIte0t8HcfX5soABZhC6Zw/dQleKl9z2o91y qaDQ== X-Forwarded-Encrypted: i=1; AJvYcCUeX2CjXOHNeZGU5DszDOG0lenc0i/pP9ijv1Jqj/6KdXcF/4Q9NgRWay9n6KUjRT1rUEUoNkzsootmZ6lSEYefVCZwkPmA4+rIbvt0 X-Gm-Message-State: AOJu0Yz4BpToSEt+oS1KFftEMtYwhLhk7uoVB6cpX2BivnxptS+4T3Hf nMZI4GCgkhcuEJrqVyhwkq3u25MSowny7hTuJIBZTM7ZxkOFUOqD/CnIo7qkSR2ksI3fXme/r37 9oRY= X-Google-Smtp-Source: AGHT+IH8XJ9x1TRFe6JiT4Wf3t1Tb6DvI9x+xL3YAtfaHFGDRg1d0VfdwZDgWq5WbIZ0C/RWbk2mjg== X-Received: by 2002:a05:6512:15a0:b0:52c:d750:bd19 with SMTP id 2adb3069b0e04-52eb998fc7cmr6784566e87.8.1720700363175; Thu, 11 Jul 2024 05:19:23 -0700 (PDT) Received: from [192.168.0.3] ([176.61.106.227]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42651531f1fsm250412815e9.0.2024.07.11.05.19.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Jul 2024 05:19:22 -0700 (PDT) Message-ID: <96f14a07-0b82-45b4-8c72-edeb1e2e52af@linaro.org> Date: Thu, 11 Jul 2024 13:19:21 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] media: venus: hfi_cmds: struct hfi_session_release_buffer_pkt: Replace 1-element array with flexible array To: Kees Cook , Stanimir Varbanov Cc: Vikash Garodia , Mauro Carvalho Chehab , "Gustavo A. R. Silva" , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240710230728.work.977-kees@kernel.org> <20240710230914.3156277-1-kees@kernel.org> Content-Language: en-US From: Bryan O'Donoghue In-Reply-To: <20240710230914.3156277-1-kees@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 11/07/2024 00:09, Kees Cook wrote: > Replace the deprecated[1] use of a 1-element array in > struct hfi_session_release_buffer_pkt with a modern flexible array. > > No binary differences are present after this conversion. > > Link: https://github.com/KSPP/linux/issues/79 [1] > Signed-off-by: Kees Cook > --- > Cc: Stanimir Varbanov > Cc: Vikash Garodia > Cc: "Bryan O'Donoghue" > Cc: Mauro Carvalho Chehab > Cc: "Gustavo A. R. Silva" > Cc: linux-media@vger.kernel.org > Cc: linux-arm-msm@vger.kernel.org > Cc: linux-hardening@vger.kernel.org > --- > drivers/media/platform/qcom/venus/hfi_cmds.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/platform/qcom/venus/hfi_cmds.h b/drivers/media/platform/qcom/venus/hfi_cmds.h > index 20acd412ee7b..42825f07939d 100644 > --- a/drivers/media/platform/qcom/venus/hfi_cmds.h > +++ b/drivers/media/platform/qcom/venus/hfi_cmds.h > @@ -227,7 +227,7 @@ struct hfi_session_release_buffer_pkt { > u32 extradata_size; > u32 response_req; > u32 num_buffers; > - u32 buffer_info[1]; > + u32 buffer_info[]; > }; > > struct hfi_session_release_resources_pkt { Reviewed-by: Bryan O'Donoghue