From: Joe Perches <joe@perches.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>
Cc: linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] xfs: Use fallthrough pseudo-keyword
Date: Tue, 07 Jul 2020 18:48:29 -0700 [thread overview]
Message-ID: <96f58df8a489093fb239cea8d36768b921269056.camel@perches.com> (raw)
In-Reply-To: <20200707205036.GL7606@magnolia>
On Tue, 2020-07-07 at 13:50 -0700, Darrick J. Wong wrote:
> On Tue, Jul 07, 2020 at 03:05:04PM -0500, Gustavo A. R. Silva wrote:
> > Replace the existing /* fall through */ comments and its variants with
> > the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary
> > fall-through markings when it is the case.
[]
> I don't get it, what's the point? Are gcc/clang
> refusing to support -Wimplicit-fallthrough=[1-4] past a certain date?
clang doesn't support comments
next prev parent reply other threads:[~2020-07-08 1:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-07 20:05 Gustavo A. R. Silva
2020-07-07 20:50 ` Darrick J. Wong
2020-07-08 1:48 ` Joe Perches [this message]
2020-07-08 6:55 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=96f58df8a489093fb239cea8d36768b921269056.camel@perches.com \
--to=joe@perches.com \
--cc=darrick.wong@oracle.com \
--cc=gustavoars@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®