From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756387Ab3AOKlT (ORCPT ); Tue, 15 Jan 2013 05:41:19 -0500 Received: from mx1.redhat.com ([209.132.183.28]:57357 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754485Ab3AOKlS (ORCPT ); Tue, 15 Jan 2013 05:41:18 -0500 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <1358210328-16726-1-git-send-email-dinggnu@gmail.com> References: <1358210328-16726-1-git-send-email-dinggnu@gmail.com> To: Cong Ding Cc: dhowells@redhat.com, David Airlie , Ben Skeggs , Dave Airlie , "Paul E. McKenney" , Thomas Gleixner , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] gpu: drm/nouveau/nouveau_fence.c: remove unnecessary null pointer check Date: Tue, 15 Jan 2013 10:39:23 +0000 Message-ID: <9706.1358246363@warthog.procyon.org.uk> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Cong Ding wrote: > the variable sender is dereferenced in line 190, so it is no reason to check > null again in line 198. Did you mean "The variable 'chan'"? David