mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Shuah Khan <shuahkh@osg.samsung.com>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: linux-kselftest@vger.kernel.org, emilio.lopez@collabora.co.uk,
	gustavo.padovan@collabora.com, linux-kernel@vger.kernel.org,
	fathi.boudra@linaro.org, Shuah Khan <shuah@kernel.org>,
	Shuah Khan <shuahkh@osg.samsung.com>
Subject: Re: [PATCH] selftests: sync: Skip the test if kernel support is not found
Date: Fri, 2 Jun 2017 15:43:53 -0600	[thread overview]
Message-ID: <970cc692-8702-dabf-a6eb-d004d9280a2f@osg.samsung.com> (raw)
In-Reply-To: <1496227215-16371-1-git-send-email-mpe@ellerman.id.au>

On 05/31/2017 04:40 AM, Michael Ellerman wrote:
> The "Sync framework" test doesn't work if the kernel has no support,
> obviously. Rather than reporting a failure, check for the kernel support
> by looking for /sys/kernel/debug/sync/sw_sync, and if not found skip the
> test.
> 
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>

Thanks. Applied to linux-kselftest next for 4.13-rc1

-- Shuah

> ---
>  tools/testing/selftests/sync/sync_test.c | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/tools/testing/selftests/sync/sync_test.c b/tools/testing/selftests/sync/sync_test.c
> index 9ea08d9f0b13..62fa666e501a 100644
> --- a/tools/testing/selftests/sync/sync_test.c
> +++ b/tools/testing/selftests/sync/sync_test.c
> @@ -29,6 +29,7 @@
>  #include <unistd.h>
>  #include <stdlib.h>
>  #include <sys/types.h>
> +#include <sys/stat.h>
>  #include <sys/wait.h>
>  
>  #include "synctest.h"
> @@ -52,10 +53,22 @@ static int run_test(int (*test)(void), char *name)
>  	exit(test());
>  }
>  
> +static int sync_api_supported(void)
> +{
> +	struct stat sbuf;
> +
> +	return 0 == stat("/sys/kernel/debug/sync/sw_sync", &sbuf);
> +}
> +
>  int main(void)
>  {
>  	int err = 0;
>  
> +	if (!sync_api_supported()) {
> +		printf("SKIP: Sync framework not supported by kernel\n");
> +		return 0;
> +	}
> +
>  	printf("[RUN]\tTesting sync framework\n");
>  
>  	err += RUN_TEST(test_alloc_timeline);
> 

      parent reply	other threads:[~2017-06-02 21:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-31 10:40 Michael Ellerman
2017-05-31 14:44 ` Gustavo Padovan
2017-05-31 14:57   ` Shuah Khan
2017-06-02 21:43 ` Shuah Khan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=970cc692-8702-dabf-a6eb-d004d9280a2f@osg.samsung.com \
    --to=shuahkh@osg.samsung.com \
    --cc=emilio.lopez@collabora.co.uk \
    --cc=fathi.boudra@linaro.org \
    --cc=gustavo.padovan@collabora.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=mpe@ellerman.id.au \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®