From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 38D0937757D
	for <linux-kernel@vger.kernel.org>; Tue, 25 Aug 2026 06:37:36 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1787639857; cv=none; b=pcZW4gvYJReYBwvwtqiTGYuns5fKlFtQytSYzQ9azoMRVbquU0jYT+pD25vHoB6ie9I5tm40l7HaLyIJo1nqCc9ZQeGVcAxSTW1teH3/17RlHYAsl9ROzPEmJH4Wwz65Fvx1nwzFmJPtVNyM/XMVTasYPinjiew8v8l6x/bQ6w4=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1787639857; c=relaxed/simple;
	bh=7uocbOxURNYex/7WjH31I8m9lQ9ybvKFvZjy3wrKTxg=;
	h=Message-ID:Date:MIME-Version:Cc:Subject:To:References:From:
	 In-Reply-To:Content-Type; b=BbUHGwmNcLxVMqtxGqmZWIYNX9pzSJN4ExIOsgUsG6wvtfCywHdJZ+MzpnTvWHb8oSCZ7vhOLVSCXLjzlwx2B2JD7gMFzIxzbEXq5TmAYqUKYG5ZuJAwgp/K/Acn6fAUe7Sv/D7u27kjum4JKHN9w4w6iyyT6zdiGybxcqEvHgU=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Bs0/2QPF; arc=none smtp.client-ip=100.103.45.18
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Bs0/2QPF"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1DD751F000E9;
	Tue, 25 Aug 2026 06:37:34 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org;
	s=k20260515; t=1787639856;
	bh=l7Ee1JZBIyLORgFg9NlUUL8nKnpoMSsHscV834uYwoQ=;
	h=Date:Cc:Subject:To:References:From:In-Reply-To;
	b=Bs0/2QPFaU34Sfa4ENEzHuF/Qo0HzPHEuY24758V52CHUR7GmGE9cjt0qBpQAg7Pr
	 bTXjx5m9Gww0rQK4uNh6rd1sTlqxfOuqc2d/+wNb9AznKN/Z60wuqqPYdPbHW3X9kK
	 DyMRas2guM3dDHst8S9PxDuW5Ie4K2q2UJllg4RUDlpcYwRmehBbceZN61eUoUQto8
	 GM4lM9QvQTyew4GCnvQ61P/yboRc7TKPv43qzs4pUfUekNH9ndWbfGsXcEIKmzmsf0
	 ukmYyDapwa/w7TyJA4XLftL7/mrfN2VI8W5AIQBEVYp12lPSzx4d7AJhaqoBCJ2n+H
	 COwh0gbvlMqww==
Message-ID: <970e87b6-23e1-4d34-9a13-68567692294e@kernel.org>
Date: Tue, 25 Aug 2026 14:37:33 +0800
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Cc: chao@kernel.org, Jaegeuk Kim <jaegeuk@kernel.org>, qiwenjie@xiaomi.com,
 linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [PATCH v2 05/12] f2fs: cache: use meta cache
To: Wenjie Qi <qwjhust@gmail.com>
References: <20260824134731.3704352-1-chao@kernel.org>
 <20260824134731.3704352-6-chao@kernel.org>
 <20260825054248.399693-1-qiwenjie@xiaomi.com>
Content-Language: en-US
From: Chao Yu <chao@kernel.org>
In-Reply-To: <20260825054248.399693-1-qiwenjie@xiaomi.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

will fix, thanks,

On 8/25/26 13:42, Wenjie Qi wrote:
> Hi Chao,
> 
>> case META:
>> 	nr_to_write = BIO_MAX_VECS;
>> 	break;
> 
> and in `f2fs_sync_meta_caches()`:
> 
>> nwritten += sbi->blocksize;
>> prev = entry->index;
>> if (unlikely(nwritten >= nr_to_write))
>> 	break;
> 
> `adjust_flush_cache_number()` returns `BIO_MAX_VECS` for META, while
> `nwritten` advances by `sbi->blocksize` for each entry before the comparison.
> 
> Are `nr_to_write` and `nwritten` intended to be entry counts or byte counts in
> this path?