From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 208A93DB65A for ; Mon, 15 Jun 2026 09:46:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781516784; cv=none; b=fCT+0itSbefnZ0Gx2EiZnmHImr4ZdB+gOgXJFBbSca4eoTcmVtt1fedzc6wrl7AU0z1SUd5zfn57XPMcB/7n0BegEB0hALDYQ+c3zH2Qn0RwtGcTVXAYE5r74zl/gdG4CsX1wLLll7/+KEWY6l13cu/Ee3Yme3NQ3lnbnIaRXus= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781516784; c=relaxed/simple; bh=RfHlJyVY3qOQ1gvEl60Xwl3FcvFNo2dgj1KhjcIFKxU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=rO09oohN7DhiFA23l5BAJ0fy8wQZMiw0HGOjyXkl5iHdIOFI78Sbu2uyTOaeakTL0xiOG7CMBWmmipgitEIB0bF6bdkBNIPcexOEgrQ0zMWxNQnUVsslUlTTVPqWge6KJb9XVzix0CmbTn5G3VEcfFuBMApk9Sn1GCX+G216Wf4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=UymCYjNc; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=YPYqjjW1; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="UymCYjNc"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="YPYqjjW1" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65F9Z0qb3818779 for ; Mon, 15 Jun 2026 09:46:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= x7cxzz2bMuaIGQXwrnW+Ls6KtkN6+BZuFlXPJCuStfM=; b=UymCYjNcWzxqFDi9 tF0Dk421TzOUACQRVE/wKL7m0+ifqJ//5FDRjG4cHfwIF14ZbFEVJJSuYweeLNbG aIeq0qaFAnRUTJwxE6eGggfC8QKBIsSNBc0jkVdXzIkyqttrShDP9bK3A0/rOenI a0fWei7+NviBNAKwlD3F13oyxEfKxmu6J1g0OrTsQg1t4yKA+qaSV/Siup0zSzYb 52uhAUpkY7HFKXkOFXBZlVmIOHkcPnWmsURr+wLbuPlCLkB/sCMQrtHw9b7yCq01 6/oA5pBYYb9qBAHnyimGMwefPT10coRmA4B+xSGMDHzK4ifCrXwSonnmUqErhccb zxddeg== Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4etew0g16s-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 15 Jun 2026 09:46:22 +0000 (GMT) Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-c85a298cd62so2197969a12.0 for ; Mon, 15 Jun 2026 02:46:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781516782; x=1782121582; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=x7cxzz2bMuaIGQXwrnW+Ls6KtkN6+BZuFlXPJCuStfM=; b=YPYqjjW1VxI3e4KSSqegI86duuwceFORdG9dm14cfVO0gjV20kZ7ByhFL57EPLY3h0 RbQb66vmTlbpX+jB9TgEbc8VZ9yWp9UU1tXYA60/TQ9bamEI0foMALr/wmy1GwZwDCBl xbTYoccOJrYYSfYRJ/rW54xWG/G+etCmaAkbdRglaoyEadLpFNQq7HBNUPYFqwRtnlEO odnfEoStzxlS1V27NVJDcGS/tbXrMlKXBYw+ElRDPNFnaPz0kyeledmr2Dk+QkJ8Q/q1 p7Qv0H39NLHKoezoMCP/AjjporkMwN5GNFBpLMf41k0bcCZ7POWJxnqrq8bT7Wb3DONO vbCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781516782; x=1782121582; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=x7cxzz2bMuaIGQXwrnW+Ls6KtkN6+BZuFlXPJCuStfM=; b=LRij8jdugVC/N28oVScF6616C7QF3IAsIdwZ8LwK/0jxqZtQVnaoHrwjARxEi5UyP5 oDCYEB0Xtvu32ohuMqr7GPUBLu3S/HfF2OJZEX2ebE4RZsXN3u1ak1MA+knGOSTJSOQx sth01LglJtPuDz71Zps8pw8TdthYqsK3qbzlSZAb8QMOKH/DIsGA1fPrMJJg0SfCgXF3 He2mEdGMMCdMRqAfBYu3TAn4fuVaO/+kd4DZ22a8mLk11UH1aIQFaAFI8m+kFz2i3bhX 0jUslCItwO3IEpZmD7rvLd44FNNjP3pUnZs97/LCPw8bYMoxV8r8hx0U9XVthAVU6wMG /kbw== X-Forwarded-Encrypted: i=1; AFNElJ/4hj9PD3RQWnqFm7VpP+Eh/IBIGCe9IIlEgiQhixAMvKmqx+lNuXR8d4oQAXZcsPmwqhh1bCj+CTZc9HQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yw4wZBfwdOMPWcZGyBjGyLJFG1GBluh5AXggoWIvagAnLc9Xjy9 ecggJDOunfgqUlCYnaXojKYjOFoForxmk7B9prvsgqizhLioCCY1VJqNbzMDO/U2mbJv2VD4FDU N0jLFiwnjU1bLl62IPz3YEL35g8T65jT2y+MnqtPQxqRyBOx2OxP3zwS8JqI5BDkWygU= X-Gm-Gg: Acq92OGEXKWOtybOosGozHtdwhga1aXw5oUBXN9wVSz/RWds8AKV78eCBKineuuYYpA vJaXftMU3Ehap43oQq9BEzizUtkJRR7VVGUnskfZ6YrRdvZP/MVBBfSiewiVPzzjohlD2nRdyXw lpQTZ5EEiIWQ2YA7jWNLvSLXQ0gchZzhoXx80dzKZYx92rIl2D0q+D4oMo/y14VpvLSB29OKDBi 7LGsuppZo7Dj2L9nZfdkdlLC0tEnAdL19aK3MUn0nVQDwcGA/TKTezvCDhzaLifom7QSmn6gT6v q6rTFgsd2FSzYiSxH+061abvTxuOe7gBQd/v1zDC6s9Z7kjaBLNqD4fWF954mTbMZ2YrEkAxDWr AFvWdEpvz3C4HLBcibq85WEm40b366PEYeQhIvnE1jW86dXvAvCQsg2LASlKs X-Received: by 2002:a05:6a00:1f04:b0:843:497e:b392 with SMTP id d2e1a72fcca58-844e1939fdbmr9893050b3a.9.1781516781501; Mon, 15 Jun 2026 02:46:21 -0700 (PDT) X-Received: by 2002:a05:6a00:1f04:b0:843:497e:b392 with SMTP id d2e1a72fcca58-844e1939fdbmr9893005b3a.9.1781516780914; Mon, 15 Jun 2026 02:46:20 -0700 (PDT) Received: from [10.218.21.154] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8434b05921bsm9597116b3a.59.2026.06.15.02.46.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Jun 2026 02:46:20 -0700 (PDT) Message-ID: <970e9449-ef38-47d2-8e77-9f406722afa9@oss.qualcomm.com> Date: Mon, 15 Jun 2026 15:16:14 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/3] ASoC: qcom: q6apm-lpass-dais: Add MI2S clock control To: Val Packett , Srinivas Kandagatla , Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jaroslav Kysela , Takashi Iwai Cc: Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, linux-sound@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Srinivas Kandagatla References: <20260608023011.942228-1-mohammad.rafi.shaik@oss.qualcomm.com> <20260608023011.942228-3-mohammad.rafi.shaik@oss.qualcomm.com> <8b2318ff-d07c-4c2d-9c2d-ef7c5c763096@packett.cool> Content-Language: en-US From: Mohammad Rafi Shaik In-Reply-To: <8b2318ff-d07c-4c2d-9c2d-ef7c5c763096@packett.cool> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNjE1MDEwMiBTYWx0ZWRfX0D3svjXM8NFF 8u41MWLsZsttjuN6ZgsxVop7j9LlRZalRh8PsH88hXB5fPhBvPuwiC0IMszX/B4oxOLbwsvNzcE vtO76zZeGpiDS18htlfG91SnqGQA0R8= X-Authority-Analysis: v=2.4 cv=QLlYgALL c=1 sm=1 tr=0 ts=6a2fc9ee cx=c_pps a=oF/VQ+ItUULfLr/lQ2/icg==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=wLQ3rIZANEYmN962rggA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=3WC7DwWrALyhR5TkjVHa:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjE1MDEwMiBTYWx0ZWRfXx2g4dC2WI310 Pj+VFPe4vhQylTKP/aTGXhsg6al1FUtyRdldmmmg4sNBddyYG9MgD2/2Gs+XiNrdtIIBOPQHX1i BHHEa2VxrW2kk62BaW1BxVZXl2u3Gm5eox/yY0duTiGM9QlvqS7722+08Yoc6GxN4EBvrw3EQMJ 98TigB585ZYJLv0lTzz/g+mankEzCHs3zzOJEygvMpcZhJJxxH/iAzVmahEil29hKB2ku4XR8Cl +P8poCScw1MBAa0yQv7jCbBpdFW6tGi0S0zVOmEqja/iJuY/vaSTAlA3HImgE5SsOmMo37sO/Mp bo88dsOuzFk6+kJ2cQJTAsLc0/+cwA/WUC5836DV3d0yDGHVhgubJBv+AI9biAYxY6aOYADoEft DlDMZhSW37ji53oSYbDMS53vujUdeDO4soHCoGv88e9fW2njtaQsfeJHp7FUc4Z00ThDDyjxYsV 944+Q7XtMaBgGVIxZzA== X-Proofpoint-GUID: FKYgB4cX9L6wheRdfIfkjcwco3AAJbd6 X-Proofpoint-ORIG-GUID: FKYgB4cX9L6wheRdfIfkjcwco3AAJbd6 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-15_02,2026-06-12_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 clxscore=1011 priorityscore=1501 adultscore=0 spamscore=0 bulkscore=0 suspectscore=0 impostorscore=0 phishscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606040000 definitions=main-2606150102 On 6/8/2026 8:19 AM, Val Packett wrote: > > On 6/7/26 11:30 PM, Mohammad Rafi Shaik wrote: >> Add support for MI2S clock control within q6apm-lpass DAIs, including >> handling of MCLK, BCLK, and ECLK via the DAI .set_sysclk callback. >> Each MI2S port now retrieves its clock handles from the device tree, >> allowing per-port clock configuration and proper enable/disable during >> startup and shutdown. >> [..] >> @@ -297,6 +373,59 @@ static const struct snd_soc_component_driver >> q6apm_lpass_dai_component = { >>       .remove_order   = SND_SOC_COMP_ORDER_FIRST, >>   }; >> +static int of_q6apm_parse_dai_data(struct device *dev, >> +                   struct q6apm_lpass_dai_data *data) >> +{ >> +    struct device_node *node; >> +    int ret; >> + >> +    for_each_child_of_node(dev->of_node, node) { >> +        struct q6apm_dai_priv_data *priv; >> +        int id; >> + >> +        ret = of_property_read_u32(node, "reg", &id); >> +        if (ret || id < 0 || id >= APM_PORT_MAX) { >> +            dev_err(dev, "valid dai id not found:%d\n", ret); >> +            continue; >> +        } >> + >> +        switch (id) { >> +        /* MI2S specific properties */ >> +        case PRIMARY_MI2S_RX ... QUATERNARY_MI2S_TX: >> +        case QUINARY_MI2S_RX ... QUINARY_MI2S_TX: > > SENARY is also a thing these days btw.. > Ack, will include SENARY dai also. Thanks & Regards, Rafi. > > ~val >