From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751698AbdF1PbF (ORCPT ); Wed, 28 Jun 2017 11:31:05 -0400 Received: from resqmta-po-11v.sys.comcast.net ([96.114.154.170]:53584 "EHLO resqmta-po-11v.sys.comcast.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751611AbdF1Pa5 (ORCPT ); Wed, 28 Jun 2017 11:30:57 -0400 Reply-To: shuah@kernel.org Subject: Re: [PATCH] selftests: ftrace: Use md5sum to take less time of checking logs To: Steven Rostedt Cc: Masami Hiramatsu , linux-kselftest@vger.kernel.org, Ingo Molnar , linux-kernel@vger.kernel.org, Shuah Khan References: <149855930170.10335.7114289594738299220.stgit@devbox> <20170628101728.5a41bed0@gandalf.local.home> <8f6497e7-8236-f0e0-0f51-87d691b9df8b@kernel.org> <20170628105923.6bdaa9a3@gandalf.local.home> From: Shuah Khan Message-ID: <97100897-9bd4-11e0-79a5-faea8ba22a09@kernel.org> Date: Wed, 28 Jun 2017 09:30:55 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <20170628105923.6bdaa9a3@gandalf.local.home> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-CMAE-Envelope: MS4wfJpw9uxp79M40b2537ppHXu7YUCXfDYANBUPhryBzrIYmuOacGv02s2qKUo1n6sB1Tx1rQm/Uc3dfy9P87Ahmyf9uamfrfCeZ9pMaSatDa9AUJjwHofp kbeHvyDEJrCEldR+UDagHka+wrZCUY+yKsDjzg2maW7GB+lL0OYIa8ChVk9ZUeyFidQGroZUV/qhuXBctaD3SWWolsRAzfkDJloC0pzUncCXF7NQDGsKz9YD tSxxtOw1VK+m6rjOs94kLvAOyqONtcs7UfmeduNzFIc4BNHz42NWI78YUw255gIpuCY6xJ+ACbV8Ouljw0nVxOEcGVjaCInd8NpBXXHRRbc= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/28/2017 08:59 AM, Steven Rostedt wrote: > On Wed, 28 Jun 2017 08:30:24 -0600 > Shuah Khan wrote: > >> On 06/28/2017 08:17 AM, Steven Rostedt wrote: >>> On Tue, 27 Jun 2017 19:28:32 +0900 >>> Masami Hiramatsu wrote: >>> >>>> Use md5sum so that it takes less time of checking >>>> trace logs update. Since busybox tail/cat takes too >>>> long time to read the trace log, this uses md5sum >>>> to check whether trace log is updated or not. >>> >>> How much faster is md5sum? I can see this causing issues in other >>> environments. >>> >>> -- Steve >> >> Sorry Steve. I pulled this into linux-ksefltest next. Are you concerned >> about any specific environments? I can try this out and see if it is a >> problem. > > Yes please. I should probably do some playing too. I would like to fix > that test anyway, as it is one of the longer ones as I do a lot of > "paranoid checks". That is, I may go overboard in testing if tracing is > off or not, by checking to make sure its off using different tactics. > Please let me know how your trials go. I have a few things I have to get to before I get around to trying this patch. thanks, -- Shuah