From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f180.google.com (mail-lj1-f180.google.com [209.85.208.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 583CC381AF4 for ; Fri, 19 Jun 2026 13:16:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781875003; cv=none; b=RorIyAx8gZfe+FhklPx7gfUe89danPd/SmN1AQuWqMPfS4sweDeEkiW+8fiFahrXNKk9tRswfP1QDZsAPtDMogGbvqkH8dm59GUFVezqqsSm04JmESgCfdrIJvYRuFpdgH2O96H9DSCxtFRPtF5aOtan9ShJQS9rX6EWJMv9F6E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781875003; c=relaxed/simple; bh=4sgAZRMpN+E4EFV/WjC2hK1lLof0TXc2GUU3wBWck9w=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Ymz9FBxDHetVbE84DI+3x8klCn5U8sLZXRsAjZpiiSG9Ra9KuedTLS455qEPGQZeFZLAqkYpFmuZzBNT0oXbMT7MysYaIe9qAGABnKnwPEMU01gBRIYIvcocw72fWlcVeTT7taa/ujD0NtHEMkLXqOJhD8M5w08v7T6dPfeEWCc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Hv2I2P55; arc=none smtp.client-ip=209.85.208.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Hv2I2P55" Received: by mail-lj1-f180.google.com with SMTP id 38308e7fff4ca-3997679cf39so1420771fa.2 for ; Fri, 19 Jun 2026 06:16:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1781875001; x=1782479801; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=pgcSYa5jaMnEPZ3HUYjkicq09TjBCnm74Jqw35loCI4=; b=Hv2I2P55R9TuDnUNArOg0uQyLd83K1vnyVWf4tWVfcdqhO91rIZqXRpTw7z2y7e4Xg zSmK039nzfVrmXwJN4bWbNLEE04bcfRh0oyNmgIGQ1bzPiHkGRjobojbTx931T6Cz5TA Wbjqx/iVipc0shqSCGRqVGLrDnhHpEr2AklKGyNWOK9W9fWYwSl+EX0tVx7enTFCNHtG 560f/Re5c0NbctZdZjixz9hDpHCokh99FggpZVu+cGz/3BuSjs4QAy/E8jUcqoFAjE90 J5rrUIUmcivQMRSsrJ7AutdMZXKfIL0iVhRNAatF/cOqClhuYpbGr/bmqaGcOvowvdIw 2TKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781875001; x=1782479801; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=pgcSYa5jaMnEPZ3HUYjkicq09TjBCnm74Jqw35loCI4=; b=bNv90+6RaQQF/ew9miHdQhxYpM1Up6kFGp+h5Hu1IfBRM9PKEOYEkSq2xsK2IbOV71 v3Q4RbEccd2QL0mijQ2fqi5BTuIVIYbbV8HRlWYP0zRkTvhBipu1mkV4G3jEUv3y6LQD 0p7LUzonkd2ESEXenSRkweDpmCIbxtJPK5jfz2WQv3VdAgQbnqv24flbdz6Nw5CGxApC +pTIbKvw1XD6ZmQtG7miW+1AM80L6W0ABkkGxL9R0AXu02RpBOltx0zzhO2rZcAzzsJb 2ioYrxRo7VMVfLYRZvkEl16hVXv81MnE7QZH2H2QWTftmU2BbXUpOWeeIH3QX4SA5C/z +gTA== X-Forwarded-Encrypted: i=1; AFNElJ9P40zwnplOHlsL11CnLVpohNUrhuI9vza2+rZMD5lAGGzOLvKKKgtZ/oR4KsujJ6ayIfl9WH9rI2J5sgo=@vger.kernel.org X-Gm-Message-State: AOJu0YwNZF0KiPsi+nMJvATsVgnLR5bAbZgRzzbL7KDCAuRgm6ZFdcNT CIhilvMMkjeIVwBIj872jfhMkf4QHtwW1fYn63oizC8Ir3Dmwx1qRXmGMyv1g+z7C6M= X-Gm-Gg: AfdE7ckbrU7oLx6VGCjTbPPjRZ7ftqIAabTuUSNUnercJWJqRQfboQi1R/Tv6mts3rq yR/d0ZarxCaW7gGhFQKcCre8BqovrDq4A3oMzgEoedtXCFxj4EO4D316SHfENvgXs08kHIvIj+z c+Wx1mGs/jB41pIUHl4vLdZMRCYhKIxUnZuneBd5xZnCkBG21pv2jNcZUG8FVEiPZLXdLUjkNU/ ZjDycOr2Qd3dIyQL/WCdRnONTdCcbbYEDalAIE9TKJ1k9ayvlG48ANrLOXzxWCEwmrjqaQt96yg BcvbcPNzT/2y3baDsXFbYXp7sE5mLA2zKzoa258D38Lv7MvlkmWkz8StCRfOfuwQZtYoLzVgQwI tHjSF8mlPJ7QoN7YF+iQHPva4Dr90GEUJDaej3fVvFArStJ7ZhXcq4pPrHs4tg3UnbZm6e7im1g Uz7Z0pn+gjI1aGr7n/Ac08x8JhhaNQTlsDb2xsywVQfpe/ZN64pfLEfRzUPYIFIXjKLEw= X-Received: by 2002:a05:6512:118d:b0:5a8:7317:540b with SMTP id 2adb3069b0e04-5ad562e8a19mr557862e87.7.1781875000383; Fri, 19 Jun 2026 06:16:40 -0700 (PDT) Received: from [192.168.1.100] (91-159-24-186.elisa-laajakaista.fi. [91.159.24.186]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5ad57246020sm583518e87.21.2026.06.19.06.16.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 Jun 2026 06:16:39 -0700 (PDT) Message-ID: <97105c63-4e6d-4bde-9053-6f795c2477d1@linaro.org> Date: Fri, 19 Jun 2026 16:16:38 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] arm64: dts: qcom: sc8280xp: Add camera MCLK pinctrl To: Konrad Dybcio , Pengyu Luo Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260607160435.36546-1-mitltlatltl@gmail.com> <280402c0-57bd-46a3-b95c-f9ae02122a09@oss.qualcomm.com> <423b4e86-3837-4d69-8f56-d8259be53ff5@oss.qualcomm.com> <12a89ab8-dc43-4b55-9c95-36d44c75dcab@linaro.org> <162da512-1142-48fa-bf7d-0b2393467a75@oss.qualcomm.com> From: Vladimir Zapolskiy In-Reply-To: <162da512-1142-48fa-bf7d-0b2393467a75@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 6/19/26 16:03, Konrad Dybcio wrote: > On 6/19/26 2:59 PM, Vladimir Zapolskiy wrote: >> On 6/19/26 15:35, Konrad Dybcio wrote: >>> On 6/11/26 7:29 AM, Pengyu Luo wrote: >>>> On Tue, Jun 9, 2026 at 8:17 PM Konrad Dybcio >>>> wrote: >>>>> >>>>> On 6/7/26 6:04 PM, Pengyu Luo wrote: >>>>>> Define pinctrl definitions to enable camera master clocks on sc8280xp. >>>>>> >>>>>> Suggested-by: Vladimir Zapolskiy >>>>>> Signed-off-by: Pengyu Luo >>>>>> --- >>>>>>   arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 56 ++++++++++++++++++++++++++ >>>>>>   1 file changed, 56 insertions(+) >>>>>> >>>>>> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi >>>>>> index a2bd6b10e475..0dbcd3069a3b 100644 >>>>>> --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi >>>>>> +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi >>>>>> @@ -5484,6 +5484,62 @@ tlmm: pinctrl@f100000 { >>>>>>                        gpio-ranges = <&tlmm 0 0 230>; >>>>>>                        wakeup-parent = <&pdc>; >>>>>> >>>>>> +                     cam_mclk0_default: cam-mclk0-default-state { >>>>>> +                             pins = "gpio119"; >>>>>> +                             function = "cam_mclk"; >>>>>> +                             drive-strength = <6>; >>>>> >>>>> Other platforms set this to 2 by default. >>>>> >>>>> What's the value set on Windows when the camera is in use? >>>>> >>>> >>>> It is 6mA. >>>> >>>> Let us get ctl_reg first on Windows >>>> >>>> lkd> !dd f111000 L8 >>>> # f111000 00000284 00000002 000000e2 00000000 >>>> # f111010 00000001 00000801 00000000 00000000 >>>> >>>> ctl_reg => 0x284 >>>> >>>> in msm_gpio_dbg_show_one() >>>> ... >>>> drive = (ctl_reg >> g->drv_bit) & 7; // (0x284 >> 6) & 7 == 2 >>>> ... >>>> seq_printf(s, " %dmA", msm_regval_to_drive(drive)); // (drive + 1) * 2 == 6; >>>> ... >>>> >>>> x13s should be the same as gaokun3 in this part. >>> >>> I confirmed as much and I'm willing to believe this is a default for >>> all 8280 devices >>> >>> Reviewed-by: Konrad Dybcio >>> >>> for the second patch, please mention in the commit message that the value >>> will now match windows and please add a fixes tag >>> >> >> I believe the second change cannot be tagged as Fixes in sense that it >> strictly depends on a not going to be backported non-fix commit, and thus >> backporting of just 2/2 change as is will break the matter. Reordering of >> the commits placing the fix commit as the first one should be fine though. > > The Fixes tag makes the patch eligible for backporting through AUTOSEL > but is itself not the same as "please backport" > That's correct, and due Documentation/process/stable-kernel-rules.rst it would make sense to add Cc: to the next version of the change to help stable tree maintainers, since it is known in advance that the unmodified and Fixes tagged 2/2 change shall not be considered as a candidate change to the stable tree. Or is it excessive? IMHO here it might be better to properly arrange the changes and backport the fix. -- Best wishes, Vladimir