From: Stefan Wahren <stefan.wahren@i2se.com>
To: Matthias Kaehlcke <mka@chromium.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
stable@vger.kernel.org, Douglas Anderson <dianders@chromium.org>,
Ravi Chandra Sadineni <ravisadineni@chromium.org>
Subject: Re: [PATCH v2 2/2] usb: misc: onboard_hub: Fail silently when there is no platform device
Date: Thu, 22 Dec 2022 13:21:16 +0100 [thread overview]
Message-ID: <97138f56-3915-b7d6-73f6-e8eceaa0ca63@i2se.com> (raw)
In-Reply-To: <20221222022605.v2.2.I0c5ce35d591fa1f405f213c444522585be5601f0@changeid>
Am 22.12.22 um 03:26 schrieb Matthias Kaehlcke:
> Some boards with an onboard USB hub supported by the onboard_hub
> driver have a device tree node for the hub, but the node doesn't
> specify all properties needed by the driver (which is not a DT
> error per se). For such a hub no onboard_hub platform device is
> created. However the USB portion of the onboard hub driver still
> probes and uses _find_onboard_hub() to find the platform device
> that corresponds to the hub. If the DT node of the hub doesn't
> have an associated platform device the function looks for a
> "peer-hub" node (to get the platform device from there), if
> that doesn't exist either it logs an error and returns -EINVAL.
>
> The absence of a platform device is expected in some
> configurations, so drop the error log and fail silently with
> -ENODEV.
>
> Fixes: 8bc063641ceb ("usb: misc: Add onboard_usb_hub driver")
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> ---
>
Tested-by: Stefan Wahren <stefan.wahren@i2se.com>
next prev parent reply other threads:[~2022-12-22 12:21 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-22 2:26 [PATCH v2 1/2] usb: misc: onboard_usb_hub: Don't create platform devices for DT nodes without 'vdd-supply' Matthias Kaehlcke
2022-12-22 2:26 ` [PATCH v2 2/2] usb: misc: onboard_hub: Fail silently when there is no platform device Matthias Kaehlcke
2022-12-22 5:50 ` Greg Kroah-Hartman
2022-12-22 12:21 ` Stefan Wahren [this message]
2022-12-22 5:50 ` [PATCH v2 1/2] usb: misc: onboard_usb_hub: Don't create platform devices for DT nodes without 'vdd-supply' Greg Kroah-Hartman
2022-12-22 12:19 ` Stefan Wahren
2022-12-22 19:26 ` Doug Anderson
2022-12-23 7:46 ` Icenowy Zheng
2023-01-02 9:20 ` Alexander Stein
2023-01-02 11:44 ` Stefan Wahren
2023-01-02 14:38 ` Alexander Stein
2023-01-03 17:31 ` Matthias Kaehlcke
2023-01-03 17:24 ` Matthias Kaehlcke
2023-01-03 17:12 ` Matthias Kaehlcke
2023-01-04 9:00 ` Alexander Stein
2023-01-04 19:37 ` Matthias Kaehlcke
2023-01-05 1:42 ` Matthias Kaehlcke
2023-01-05 7:50 ` Stefan Wahren
2023-01-05 19:41 ` Matthias Kaehlcke
2023-01-05 20:45 ` Matthias Kaehlcke
2022-12-23 14:01 ` Johan Hovold
2023-01-03 17:42 ` Matthias Kaehlcke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=97138f56-3915-b7d6-73f6-e8eceaa0ca63@i2se.com \
--to=stefan.wahren@i2se.com \
--cc=dianders@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mka@chromium.org \
--cc=ravisadineni@chromium.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®