From: Tiezhu Yang <yangtiezhu@loongson.cn>
To: Huacai Chen <chenhuacai@kernel.org>
Cc: Xi Zhang <zhangxi@kylinos.cn>,
Xianglai Li <lixianglai@loongson.cn>,
loongarch@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] LoongArch: Handle special PC in unwind_next_frame()
Date: Wed, 26 Nov 2025 13:36:14 +0800 [thread overview]
Message-ID: <97155bf2-591c-2d5f-b26f-c0532fe2e3d5@loongson.cn> (raw)
In-Reply-To: <CAAhV-H77duX-WiYsJzkJChmGHdGh5y_k6YEvLQdpDys5iLctgw@mail.gmail.com>
On 2025/11/25 下午5:05, Huacai Chen wrote:
> On Tue, Nov 25, 2025 at 4:54 PM Tiezhu Yang <yangtiezhu@loongson.cn> wrote:
...
>> They are different code paths, the current path is "goto err", it will
>> set state->error as true, then arch_stack_walk_reliable() will return
>> -EINVAL.
>>
>> With this patch, the code path is "goto end" for this case, it will
>> not set state->error as true, then arch_stack_walk_reliable() will
>> return 0.
> Then can we replace "goto err" with "goto end" at __kernel_text_address()?
No, this "goto err" path is useful to indicate that there is
something wrong.
Thanks,
Tiezhu
next prev parent reply other threads:[~2025-11-26 5:36 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-25 6:33 Tiezhu Yang
2025-11-25 8:08 ` Huacai Chen
2025-11-25 8:54 ` Tiezhu Yang
2025-11-25 9:05 ` Huacai Chen
2025-11-26 5:36 ` Tiezhu Yang [this message]
2025-11-25 10:52 ` Jinyang He
2025-11-26 6:08 ` Tiezhu Yang
2025-11-26 6:28 ` Tiezhu Yang
2025-11-26 9:09 ` Tiezhu Yang
2025-11-26 9:27 ` Huacai Chen
2025-11-27 1:32 ` Tiezhu Yang
2025-11-26 9:56 ` Bibo Mao
2025-11-27 1:39 ` Tiezhu Yang
2025-11-27 1:53 ` Bibo Mao
2025-11-27 2:53 ` Jinyang He
2025-11-27 2:58 ` Bibo Mao
2025-12-09 2:08 ` Tiezhu Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=97155bf2-591c-2d5f-b26f-c0532fe2e3d5@loongson.cn \
--to=yangtiezhu@loongson.cn \
--cc=chenhuacai@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lixianglai@loongson.cn \
--cc=loongarch@lists.linux.dev \
--cc=zhangxi@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®