From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756548AbcE0Ubf (ORCPT ); Fri, 27 May 2016 16:31:35 -0400 Received: from nat-hk.nvidia.com ([203.18.50.4]:38156 "EHLO hkmmgate101.nvidia.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754696AbcE0Ube (ORCPT ); Fri, 27 May 2016 16:31:34 -0400 X-PGP-Universal: processed; by hkpgpgate102.nvidia.com on Fri, 27 May 2016 13:31:30 -0700 Subject: Re: [PATCH] mfd: max77620: Fix FPS switch statements To: Laxman Dewangan , Lee Jones References: <1463075104-26924-1-git-send-email-rklein@nvidia.com> <5734C2C2.2060207@nvidia.com> CC: , From: Rhyland Klein Message-ID: <9716c1c8-dd2b-8444-6ec9-567d07fe8971@nvidia.com> Date: Fri, 27 May 2016 16:31:25 -0400 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: <5734C2C2.2060207@nvidia.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/12/2016 1:52 PM, Laxman Dewangan wrote: > > On Thursday 12 May 2016 11:15 PM, Rhyland Klein wrote: >> When configuring FPS during probe, assuming a DT node is present for >> FPS, the code can run into a problem with the switch statements in >> max77620_config_fps() and max77620_get_fps_period_reg_value(). Namely, >> in the case of chip->chip_id == MAX77620, it will set >> fps_[mix|max]_period but then fall through to the default switch case >> and return -EINVAL. Returning this from max77620_config_fps() will >> cause probe to fail. >> > > Thanks for fixes. > Missed when converting if-else to switch. > > Reviewed-by: Laxman Dewangan > Lee, I noticed this hasn't been merged yet, but without it platforms using the max77620 can easily (if it has FPS nodes) fail to probe. Is there anything blocking it? -rhyland -- nvpublic