From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC0E01ADC63 for ; Thu, 23 Jan 2025 19:48:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737661715; cv=none; b=FwjUKC5KH6zWFdB8NpLzh+wksn6cYRxrPntqWhdREzmRr91tibPRO17pWFm0vFWBqORvVthX/EzdpgKniEXvyN4Abd8aacZQR8WSrWESoRiXSfJRZDwgmWLdAgk70KKiG+bI8kVQ15O1wxC8hsDL/UMAwvXiZ/8aIbpdz+/+M4c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737661715; c=relaxed/simple; bh=MrZdOfIrJAXOsLPBGF6einOYAQ9GwImx93xKqEcUlbE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=g0nHhLty94SfyrxwXsFm5sfKRMhHZStHmmmtj+ToYkhcylnlMQzMhehaIopXYDLpNcF1tn5OlglOY76F0C2fASWdME+hXzsLbzcPVSKWi/fOoR2vkEnHe3ADa0zUQG8BtoRmbagBVL9FVDO+GlJNxW3FpfnIYqEy0Wkd9mNVOyM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=RqBw+EEy; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="RqBw+EEy" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-4361e89b6daso8866615e9.3 for ; Thu, 23 Jan 2025 11:48:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1737661711; x=1738266511; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=UEzQx5EKwKnXykiE3C9S4XHeCQPE3yQLJe/q7xEl0UI=; b=RqBw+EEyxk/O6HF6aSsY0lqxSL76QgDSTEc21vkAy8HHOw3tgvK9EoFGTyPnzyxaJS G9mJfgjxIAdkMPYzIgC+kxsPSbddvJBVVnu7CDQlmTUWtbf/u97rZslpfkBgGoHP23VZ uZjy0xZmbMTV1bjA0fG3XANavv+oSKc4aUcFxR+hNSnQxU9RYVcJPDBwi9YbwPG8vIyJ BkZuqsp3fZVZqWeaufyMCvAkVpQTR9x7J+nAsUjg4ZgqKDa7gGdDOx+hubRVGmsJFZqF rp9mC95lSBWCNmi693E8t1nQB094zedbiywDPypN3ZJlXbKlcYZNCCL22BkRvJIZtApj AeoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737661711; x=1738266511; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UEzQx5EKwKnXykiE3C9S4XHeCQPE3yQLJe/q7xEl0UI=; b=QN29ZUayF2CMSjTgiMOd6CIRWzXZTcyVT4PCfwTGMUhRxC0ps3atmsAlS7No0D45SJ w32zs4Wgn+XZ3b2HbG0RlnzhREyLg9WVIO32Ttyc1PtDGRcjyundXW82RO5tR4NQDmFR PubTirA/lgX5qoH+Ll4KhVajQnrDCpXXSj1Klw4Kh+0UbbJxjW4htmIyBFYfMWo7wlJW 7VnYxDy8lSPWXDnBB+u1QovEkiAFZ9jGvW8thP8Y3wl3YGiTb/C0sDIudiYPVXXxsOnk F47k9vtrFJz3mW8rCnSznzNZ4DzgObeJbEoqixswMRBC10HMOhkUs3JLlTbdtkNLqUFG tDIA== X-Forwarded-Encrypted: i=1; AJvYcCWF/F1uTfzwqqDrgKTgxDL3128JTJ0yKUTeBwG2iItp0ybc4pVwHLK2zEE6v8FoiuPBLIKNEJfXeGixp4Q=@vger.kernel.org X-Gm-Message-State: AOJu0YzJ7T/Aw2bBqLKONvNqckqWCVcjYoDUkKOWtfIEO7EehCoR3lPU TJXiM8DT5DuNcBQ1jPq2aJPiXw1k085MtKncIMLLtAe7jZ42VD9mzUQDbQD/zX4= X-Gm-Gg: ASbGnctwqF5/XLyNuVcNBjiFK6wxvjG4bpjutCc7j3k3EnLSW9itDa0+O9G4C1flI6X AeGWgSbFxinyh+Kbk6c4dA8HwV0kBYai0f/qZqxZL9Zrym4NUYYO9dlgter4Fvdc0vFm+vdzl0E OV5BDW/RKqBBNE/JmEFvX+c5eZZHkSYjqffoO+zs/ii/JTP4iFUZ8IPZkFO+GDDG+EB+dJt+p4E CchfWyn2gojgoQoVV6qxtA89kEYy4OpB+LKkINwqVuNFrkSLdlR1FijfWCEkOTf8w137lkDfR7Z 5AMqabIvQ/kQZFPQv73DC7oTI8sBrK/F1UzBf/SNLeluUeVlJMRZ X-Google-Smtp-Source: AGHT+IFCmuRcO2q+WkCuoyE4umxs3Q8grgYjAGWaKRdiWeb/qlKv81TNKgwodg4lbmq0iUf3Z/pwAw== X-Received: by 2002:a05:6000:156c:b0:386:1cd3:8a05 with SMTP id ffacd0b85a97d-38bf57ce963mr27366273f8f.54.1737661710999; Thu, 23 Jan 2025 11:48:30 -0800 (PST) Received: from ?IPV6:2001:861:d40:ed60:308f:ce31:765f:bf21? ([2001:861:d40:ed60:308f:ce31:765f:bf21]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38c2a1c3f5dsm556090f8f.92.2025.01.23.11.48.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Jan 2025 11:48:30 -0800 (PST) Message-ID: <971868a3-2dc4-4623-b979-4e722658f6a1@baylibre.com> Date: Thu, 23 Jan 2025 20:48:30 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4] arm64: arch_k3: Replace select with imply for TI mailbox and TI SCI To: Andrew Davis , Catalin Marinas , Will Deacon , nm@ti.com Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, khilman@baylibre.com, Mattijs Korpershoek , vishalm@ti.com, Nicolas Frayer References: <20250123-timodulemailboxsci-v4-1-b1a31b56f162@baylibre.com> Content-Language: en-US From: Guillaume La Roque In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Andrew, thanks for review. Le 23/01/2025 à 16:29, Andrew Davis a écrit : > On 1/23/25 6:12 AM, Guillaume La Roque wrote: >> In order to build TI mailbox and TI SCI as modules, replace >> select with imply. >> >> Signed-off-by: Nicolas Frayer >> Signed-off-by: Guillaume La Roque >> --- >> Changes in v4: >> - rebase on master branch >> - Link to v3: >> https://lore.kernel.org/r/20241016-timodulemailboxsci-v3-1-0e7f7a6de97d@baylibre.com >> >> Changes in v3: >> - rebase with master >> >> Changes in v2: >> - Use imply instead of removing select altogether and dropped >> patches 2/3 and 3/3 from previous series as using imply makes >> them redundant >> --- >>   arch/arm64/Kconfig.platforms | 4 ++-- >>   1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms >> index 02007256709e..a6e4bfffc09d 100644 >> --- a/arch/arm64/Kconfig.platforms >> +++ b/arch/arm64/Kconfig.platforms >> @@ -133,8 +133,8 @@ config ARCH_K3 >>       select PM_GENERIC_DOMAINS if PM >>       select MAILBOX >>       select SOC_TI >> -    select TI_MESSAGE_MANAGER >> -    select TI_SCI_PROTOCOL >> +    imply TI_MESSAGE_MANAGER >> +    imply TI_SCI_PROTOCOL > > I really don't like "imply" in general, and this will be the only > instance of it now in the whole file.. > > Your v1 of this series was the right way to do this IMHO. The only > issue was patches 2/3 and 3/3 should have been first in the series to > prevent bisect issues. And they had to go to two different maintainers > so it shouldn't have been a single series in the first place. ok for me ,i will reuse v1 , split and resend. Thanks Guillaume > > Andrew > >>       select TI_K3_SOCINFO >>       help >>         This enables support for Texas Instruments' K3 multicore SoC >> >> --- >> base-commit: 21266b8df5224c4f677acf9f353eecc9094731f0 >> change-id: 20241016-timodulemailboxsci-412e2a6458fc >> >> Best regards,