From: KY Srinivasan <kys@microsoft.com>
To: Olaf Hering <olaf@aepfle.de>
Cc: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devel@linuxdriverproject.org" <devel@linuxdriverproject.org>,
"apw@canonical.com" <apw@canonical.com>,
"jasowang@redhat.com" <jasowang@redhat.com>
Subject: RE: [PATCH V2 1/1] Drivers: hv: Implement the file copy service
Date: Tue, 14 Jan 2014 23:12:25 +0000 [thread overview]
Message-ID: <9727e8776e9542b0bc4576cb9f9a6248@BY2PR03MB299.namprd03.prod.outlook.com> (raw)
In-Reply-To: <20140114221323.GA16960@aepfle.de>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 1329 bytes --]
> -----Original Message-----
> From: Olaf Hering [mailto:olaf@aepfle.de]
> Sent: Tuesday, January 14, 2014 2:13 PM
> To: KY Srinivasan
> Cc: gregkh@linuxfoundation.org; linux-kernel@vger.kernel.org;
> devel@linuxdriverproject.org; apw@canonical.com; jasowang@redhat.com
> Subject: Re: [PATCH V2 1/1] Drivers: hv: Implement the file copy service
>
> On Tue, Jan 14, K. Y. Srinivasan wrote:
>
>
> > +static ssize_t fcopy_write(struct file *file, const char __user *buf,
> > + size_t count, loff_t *ppos)
> > +{
> > + int error = 0;
> > +
> > + if (count != sizeof(int))
> > + return 0;
> > +
> > + if (copy_from_user(&error, buf, sizeof(int)))
> > + return -EFAULT;
> > +
> > + if (in_hand_shake) {
> > + fcopy_handle_handshake();
> > + return 0;
> > + }
>
>
> > + /*
> > + * Register with the kernel.
> > + */
> > + write(fcopy_fd, &version, sizeof(int));
>
>
> Shouldnt there be some version check already even in this initial
> implementation? What if there will be a newer daemon running on an older
> kernel?
Currently, the daemon registers with the kernel passing its version number. I will make the
version check "real".
Thanks,
K. Y
>
> Olaf
ÿôèº{.nÇ+·®+%Ëÿ±éݶ\x17¥wÿº{.nÇ+·¥{±þG«éÿ{ayº\x1dÊÚë,j\a¢f£¢·hïêÿêçz_è®\x03(éÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?¨èÚ&£ø§~á¶iOæ¬z·vØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?I¥
next prev parent reply other threads:[~2014-01-14 23:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-14 19:35 K. Y. Srinivasan
2014-01-14 22:13 ` Olaf Hering
2014-01-14 23:12 ` KY Srinivasan [this message]
2014-01-15 16:33 ` Olaf Hering
2014-01-15 19:11 ` KY Srinivasan
2014-01-16 9:42 ` Olaf Hering
2014-01-16 15:52 ` KY Srinivasan
2014-01-17 7:31 ` Dan Carpenter
2014-01-16 10:16 ` Olaf Hering
2014-01-16 15:51 ` KY Srinivasan
2014-01-16 10:48 ` Olaf Hering
2014-01-16 15:50 ` KY Srinivasan
2014-01-20 22:13 ` KY Srinivasan
2014-01-20 22:16 ` Olaf Hering
2014-01-20 22:23 ` KY Srinivasan
2014-01-16 11:26 ` Olaf Hering
2014-01-16 15:49 ` KY Srinivasan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9727e8776e9542b0bc4576cb9f9a6248@BY2PR03MB299.namprd03.prod.outlook.com \
--to=kys@microsoft.com \
--cc=apw@canonical.com \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=olaf@aepfle.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®