From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD6D8C43381 for ; Wed, 20 Mar 2019 20:05:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B2F1A21841 for ; Wed, 20 Mar 2019 20:05:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="JplPzbTJ"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="KHgXKJzR" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726907AbfCTUFr (ORCPT ); Wed, 20 Mar 2019 16:05:47 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:43264 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726023AbfCTUFr (ORCPT ); Wed, 20 Mar 2019 16:05:47 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 88E8760FE9; Wed, 20 Mar 2019 20:05:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1553112346; bh=J4dZuMKJKUnbEpzsHHPpkPO3B4l+kubBHyMn5liynsc=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=JplPzbTJWcwMnJUUwVU5dEM3d7u6ddwfQDbDRp+mALsnVjfuuM5eDVzt/m8/jbeCf tuwBIYptUo4N8AmscAJQrEaG7JWJCXRx4FRrlgVFzIrj85zg/tkU2oKiJUASoXuI2A nv0ie8K3Fb3vMXCBZiTp9VwwPA9Mibqy+WPSQCuw= Received: from [10.79.162.149] (blr-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.18.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: mojha@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id E654C60F3C; Wed, 20 Mar 2019 20:05:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1553112345; bh=J4dZuMKJKUnbEpzsHHPpkPO3B4l+kubBHyMn5liynsc=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=KHgXKJzRF1got7rWIme0ritJPvmxHydiuRxPsvZaUcs2NlLvYJdETIPUestjYpNwz 2NN74J2U9bnNJAa3yexXZvqHY4NuG1BQvyAx+6dSYAuVh7aDtOFdAwyAa2Qk8Mgohh fD1r60aVJWnDTd/L+PhrQ/fKMDeg2Wa63Yz2whns= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org E654C60F3C Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=mojha@codeaurora.org Subject: Re: [PATCH -next] ubifs: remove unused function __ubifs_shash_final To: Yue Haibing , richard@nod.at, dedekind1@gmail.com, adrian.hunter@intel.com Cc: linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org References: <20190320140955.11576-1-yuehaibing@huawei.com> From: Mukesh Ojha Message-ID: <97289b81-ed73-002a-504d-2e82fad153e7@codeaurora.org> Date: Thu, 21 Mar 2019 01:35:37 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190320140955.11576-1-yuehaibing@huawei.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/20/2019 7:39 PM, Yue Haibing wrote: > From: YueHaibing > > There is no callers in tree, and can be removed. > > Signed-off-by: YueHaibing > --- > fs/ubifs/auth.c | 18 ------------------ > 1 file changed, 18 deletions(-) > > diff --git a/fs/ubifs/auth.c b/fs/ubifs/auth.c > index 5bf5fd0..2a40ccce 100644 > --- a/fs/ubifs/auth.c > +++ b/fs/ubifs/auth.c > @@ -147,24 +147,6 @@ struct shash_desc *__ubifs_hash_get_desc(const struct ubifs_info *c) > } > > /** > - * __ubifs_shash_final - finalize shash > - * @c: UBIFS file-system description object > - * @desc: the descriptor > - * @out: the output hash > - * > - * Simple wrapper around crypto_shash_final(), safe to be called with > - * disabled authentication. > - */ > -int __ubifs_shash_final(const struct ubifs_info *c, struct shash_desc *desc, > - u8 *out) > -{ > - if (ubifs_authenticated(c)) > - return crypto_shash_final(desc, out); > - > - return 0; > -} > - > -/** > * ubifs_bad_hash - Report hash mismatches > * @c: UBIFS file-system description object > * @node: the node Looks fine to be removed. Acked-by: Mukesh Ojha -Mukesh