From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com [209.85.167.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 83A0119E7F8 for ; Wed, 23 Oct 2024 10:06:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729677986; cv=none; b=U7Zc4VkkFVIa51RzTttocTVhMfG7Bet1C9EkwQx2M3yUQNB3ABjHJGZp0Rebytu4NoFjS3ikSmltWPCvio1UA6+7zZqMXpvJFxImQFxSaeIUMr8zW4tFRNdVuw8FahxAInWfysID0v963DFUwtybrCsbNdfyT2BjnIY/+Tv3ZSM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729677986; c=relaxed/simple; bh=yU5dZthC4JR7clFEU+VaiuHzsRK9INyahbMu5Agd3mY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Gr74jpUGacReqIIFKhTQcfj+Gge6MldtNpoG49+CibA2AyC/as7BpfFLnU5I5Z/6QhfBSkFJcDDfunB/K6NZRx4CAYCpFGhk4FN+kcFlIjT8IIbywhy494QQFrWtQpI3yqEVvX2bIHAld9uHrHIbBKxxuhPT+1H4iP/uN8volDk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=BOkPtVOt; arc=none smtp.client-ip=209.85.167.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="BOkPtVOt" Received: by mail-lf1-f51.google.com with SMTP id 2adb3069b0e04-539983beb19so7491220e87.3 for ; Wed, 23 Oct 2024 03:06:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1729677983; x=1730282783; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=QmFWwJacJAgS5CGhagQj/y+QCn9s9Xrg8IyhVVZtACM=; b=BOkPtVOt1LxHQ5opf1ucDJvtIJWKr2JsQ8jYpF9UO4nLWGupGgAA+fhuK1023+NX7R 1ssrUxsyYoxLR9jie7SzjuGKGZ/2h0CS+ktA9JDD46CGz1XbpytaCPTgyt/ikoI6ckij 9GH61VtPQNglgDMWWSClD/cnATNCRPvZ2YW41y1cyZEvT/8EYAlSCON4MTCgJxuLn1E8 WZWWyr1c621UzdzQaHtv50ZmujvDRw3THTCH4yD9iJMKfnCjVWeqjQ5zTlWXq9bF/jEu VN7KCZJreCh2h82rqn3kfA2SEtG1hEANT1/1Ivm2wsJYwj0CWiRaHVlBZQY1WZOv3GYQ 4dVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729677983; x=1730282783; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QmFWwJacJAgS5CGhagQj/y+QCn9s9Xrg8IyhVVZtACM=; b=ow94z+c6hq5Op+XnTGk4Jw+RVfyAos6WS22tdyZUOF3A6EA+KGMXz1oiL9J9E218Px e6Pw39BN8Dp9jMt2JXbS0mxW+Qm9tSHTp9iACVFbzxi6RtSfUSkyquFghgmsLRjCwcMM TuJsjWw4QAlTY2G3qaezaTUm1AYGJWBWd0NvEfYShzuuN0Ujm0wBYXfAk+ggsnUjLkJ8 W1dgZ0JD+LK9/uyYn+6RkAPrhEFKpihETgdJtCagmHYu/Y0CUgYAGIlOHzdiadWKLzhM 4gC+BGlTojNXZZxm2lv9p1Km3XRvmJO3J2r6IlKyL1CKhy5ntU2THWp+SANCgrHW806k KacQ== X-Forwarded-Encrypted: i=1; AJvYcCV3fFmvbNXlVtjarOS0jujXJYAzIC590f+4TJzF63s5l5QOuHo3hOoZ3p7Sdt/BZOuzm5Y0THzkJeWmPws=@vger.kernel.org X-Gm-Message-State: AOJu0YzFQkFJnlAOss73KBv/8ExZSW5EoB+IA2fPD/vPccsiMExko/Hc Vgwws2FC+qfGmF7EkW2+fdVP1pxwT4XYop++7mJYxp+M7q/uYkqzDYNm5AscjZk= X-Google-Smtp-Source: AGHT+IENoLqmzudlZrppge6f/QJA6ViYHAbyrrfgtDyUbQMErRS34yaCQr0YHoWGW0qrUIe/m7/udQ== X-Received: by 2002:a05:6512:1293:b0:536:55a9:4b6c with SMTP id 2adb3069b0e04-53b1a307d85mr1130622e87.13.1729677982662; Wed, 23 Oct 2024 03:06:22 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43186bd69ebsm11979625e9.1.2024.10.23.03.06.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Oct 2024 03:06:22 -0700 (PDT) Date: Wed, 23 Oct 2024 13:06:18 +0300 From: Dan Carpenter To: Kalle Valo Cc: Ping-Ke Shih , Zong-Zhe Yang , "linux-wireless@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "kernel-janitors@vger.kernel.org" Subject: Re: [PATCH next] wifi: rtw89: unlock on error path in rtw89_ops_unassign_vif_chanctx() Message-ID: <9729c2f5-2df5-4468-a4da-cd31f4332b4c@stanley.mountain> References: <8683a712-ffc2-466b-8382-0b264719f8ef@stanley.mountain> <6a80d4adc51f4ea884b5e02f16d8aaed@realtek.com> <931c79c15bc04be99bb87a9826cf2b04@realtek.com> <2e85c84b-31bf-484b-b3e2-9285999bb2e4@stanley.mountain> <87v7xjma5d.fsf@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87v7xjma5d.fsf@kernel.org> On Wed, Oct 23, 2024 at 12:38:38PM +0300, Kalle Valo wrote: > Dan Carpenter writes: > > > On Tue, Oct 22, 2024 at 03:32:23AM +0000, Ping-Ke Shih wrote: > > > >> Zong-Zhe Yang wrote: > >> > Dan Carpenter wrote: > >> > > > >> > > [...] > >> > > > >> > > @@ -1373,6 +1373,7 @@ static void rtw89_ops_unassign_vif_chanctx(struct ieee80211_hw > >> > > *hw, > >> > > > >> > > rtwvif_link = rtwvif->links[link_conf->link_id]; > >> > > if (unlikely(!rtwvif_link)) { > >> > > + mutex_unlock(&rtwdev->mutex); > >> > > rtw89_err(rtwdev, > >> > > "%s: rtwvif link (link_id %u) is not active\n", > >> > > __func__, link_conf->link_id); > >> > > > >> > > >> > Acked-by: Zong-Zhe Yang > >> > > >> > >> Thanks for the ack. > >> > >> Acked-by is often used by the maintainer, so I will change it to Reviewed-by > >> during committing. > > > > To me Acked by just means you're okay with the patch. When I use it, it means I > > don't feel qualified or interested enough to do a full review. For example, if > > I complain about a v1 patch and they fix my issue in v2 then I like to say that > > I'm okay with it. In that case I'll use Reviewed-by for a full review or Acked > > by if the bits that I care about are okay. I don't like to complain and then > > just go silent. > > > > In the end, it doesn't make any difference. You'll get CC'd on bug reports to > > do with the patch and you'll potentially feel bad for not spotting the bug, I > > guess. > > I have understood that Acked-by should be only used by the corresponding > maintainers and the documentation seems to say the same: > > https://docs.kernel.org/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by "If a person was not directly involved in the preparation or handling of a patch but wishes to signify and record their approval of it then they can ask to have an Acked-by: line added to the patch’s changelog." The documentation does say that it's also often used by maintainers for approving part of a patchset. But to me, it's the "partial" which is the more important word in that sentence. I haven't reviewed the whole patch. > > The reason I ask non-maintainers avoid using Acked-by is that it messes > our patchwork listings (it counts both Acked-by and Reviewed-by tags). > > -- > https://patchwork.kernel.org/project/linux-wireless/list/ Huh. I wasn't aware that anything really differentiated between Acks and Reviews. That does make things more complicated. I rarely do Acks, but when I do it's because I'm outside of a subsystem I'm familiar with. I would say LGTM and leave it at that, except other people want proper tags. Probably they won't insist on proper tags from me though so it's fine. regards, dan carpenter