From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753247AbdJaNRV (ORCPT ); Tue, 31 Oct 2017 09:17:21 -0400 Received: from mx2.yrkesakademin.fi ([85.134.45.195]:16216 "EHLO mx2.yrkesakademin.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751951AbdJaNRS (ORCPT ); Tue, 31 Oct 2017 09:17:18 -0400 X-Greylist: delayed 902 seconds by postgrey-1.27 at vger.kernel.org; Tue, 31 Oct 2017 09:17:17 EDT Subject: Re: [PATCH 4.13 28/43] SMB3: Validate negotiate request must always be signed To: Greg Kroah-Hartman , CC: , Steve French References: <20171031095530.520746935@linuxfoundation.org> <20171031095531.633196173@linuxfoundation.org> From: Thomas Backlund Message-ID: <97340c9a-0ea2-0d3d-cf26-58c799d76cae@mageia.org> Date: Tue, 31 Oct 2017 15:02:11 +0200 MIME-Version: 1.0 In-Reply-To: <20171031095531.633196173@linuxfoundation.org> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-WatchGuard-Spam-ID: str=0001.0A0C0204.59F877DE.00EB,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0 X-WatchGuard-Spam-Score: 0, clean; 0, virus threat unknown X-WatchGuard-Mail-Client-IP: 85.134.45.195 X-WatchGuard-Mail-From: tmb@mageia.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Den 31.10.2017 kl. 11:55, skrev Greg Kroah-Hartman: > 4.13-stable review patch. If anyone has any objections, please let me know. > > ------------------ > > From: Steve French > > commit 4587eee04e2ac7ac3ac9fa2bc164fb6e548f99cd upstream. > > According to MS-SMB2 3.2.55 validate_negotiate request must > always be signed. Some Windows can fail the request if you send it unsigned > > See kernel bugzilla bug 197311 > > Acked-by: Ronnie Sahlberg > Signed-off-by: Steve French > Signed-off-by: Greg Kroah-Hartman > > --- > fs/cifs/smb2pdu.c | 3 +++ > 1 file changed, 3 insertions(+) > > --- a/fs/cifs/smb2pdu.c > +++ b/fs/cifs/smb2pdu.c > @@ -1963,6 +1963,9 @@ SMB2_ioctl(const unsigned int xid, struc > } else > iov[0].iov_len = get_rfc1002_length(req) + 4; > > + /* validate negotiate request must be signed - see MS-SMB2 3.2.5.5 */ > + if (opcode == FSCTL_VALIDATE_NEGOTIATE_INFO) > + req->hdr.sync_hdr.Flags |= SMB2_FLAGS_SIGNED; > > rc = SendReceive2(xid, ses, iov, n_iov, &resp_buftype, flags, &rsp_iov); > cifs_small_buf_release(req); > > > This one needs to be backported to all stable kernels as the commit that introduced the regression: ' 0603c96f3af50e2f9299fa410c224ab1d465e0f9 SMB: Validate negotiate (to protect against downgrade) even if signing off is backported in stable trees as of: 4.9.53, 4.4.90, 3.18.73 -- Thomas