From: Bastien Curutchet <bastien.curutchet@bootlin.com>
To: Rodolfo Giometti <giometti@enneenne.com>
Cc: linux-kernel@vger.kernel.org,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
herve.codina@bootlin.com, christophercordahi@nanometrics.ca,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v3 1/1] pps: clients: gpio: Bypass edge's direction check when not needed
Date: Wed, 26 Jun 2024 14:55:40 +0200 [thread overview]
Message-ID: <973aa216-4932-4e21-b9a1-184ce809d483@bootlin.com> (raw)
In-Reply-To: <3612b36e-3350-4a5c-827e-482434753e95@enneenne.com>
Hi Rodolfo
On 4/25/24 14:42, Rodolfo Giometti wrote:
> On 25/04/24 14:28, Bastien Curutchet wrote:
>> In the IRQ handler, the GPIO's state is read to verify the direction of
>> the edge that triggered the interruption before generating the PPS event.
>> If a pulse is too short, the GPIO line can reach back its original state
>> before this verification and the PPS event is lost.
>>
>> This check is needed when info->capture_clear is set because it needs
>> interruptions on both rising and falling edges. When info->capture_clear
>> is not set, interruption is triggered by one edge only so this check can
>> be omitted.
>>
>> Add a warning if irq_handler is left without triggering any PPS event.
>> Bypass the edge's direction verification when info->capture_clear is not
>> set.
>>
>> Signed-off-by: Bastien Curutchet <bastien.curutchet@bootlin.com>
>
> Acked-by: Rodolfo Giometti <giometti@enneenne.com>
>
I don't think I've received any updates since you acked this. Is there
something missing before the patch can be applied?
Best regards,
Bastien
next prev parent reply other threads:[~2024-06-26 12:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-25 12:28 Bastien Curutchet
2024-04-25 12:42 ` Rodolfo Giometti
2024-06-26 12:55 ` Bastien Curutchet [this message]
2024-06-26 14:16 ` Rodolfo Giometti
2024-12-04 10:34 ` Bastien Curutchet
2024-12-04 11:00 ` Rodolfo Giometti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=973aa216-4932-4e21-b9a1-184ce809d483@bootlin.com \
--to=bastien.curutchet@bootlin.com \
--cc=akpm@linux-foundation.org \
--cc=christophercordahi@nanometrics.ca \
--cc=giometti@enneenne.com \
--cc=gregkh@linuxfoundation.org \
--cc=herve.codina@bootlin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®