From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7055C433DF for ; Wed, 26 Aug 2020 16:14:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9DBD62075E for ; Wed, 26 Aug 2020 16:14:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727923AbgHZQOy (ORCPT ); Wed, 26 Aug 2020 12:14:54 -0400 Received: from smtprelay0065.hostedemail.com ([216.40.44.65]:51500 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727860AbgHZQOW (ORCPT ); Wed, 26 Aug 2020 12:14:22 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay06.hostedemail.com (Postfix) with ESMTP id 420C018224506; Wed, 26 Aug 2020 16:14:20 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: rail44_10129d627065 X-Filterd-Recvd-Size: 2123 Received: from XPS-9350.home (unknown [47.151.133.149]) (Authenticated sender: joe@perches.com) by omf20.hostedemail.com (Postfix) with ESMTPA; Wed, 26 Aug 2020 16:14:19 +0000 (UTC) Message-ID: <973f4d54da796db4fcc9b643b10889cbc8839989.camel@perches.com> Subject: Re: [PATCH v1] driver core: Annotate dev_err_probe() with __must_check From: Joe Perches To: Andy Shevchenko Cc: Andrzej Hajda , linux-kernel@vger.kernel.org, Greg Kroah-Hartman , "Rafael J . Wysocki" Date: Wed, 26 Aug 2020 09:14:17 -0700 In-Reply-To: <20200826155507.GV1891694@smile.fi.intel.com> References: <20200826104459.81979-1-andriy.shevchenko@linux.intel.com> <9635eaa4ccc1141fb0dd8c3687f46da7149206ad.camel@perches.com> <20200826155507.GV1891694@smile.fi.intel.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.36.4-0ubuntu1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2020-08-26 at 18:55 +0300, Andy Shevchenko wrote: > On Wed, Aug 26, 2020 at 08:44:30AM -0700, Joe Perches wrote: > > On Wed, 2020-08-26 at 13:44 +0300, Andy Shevchenko wrote: > > ... > > > > -int dev_err_probe(const struct device *dev, int err, const char *fmt, ...); > > > +int __must_check dev_err_probe(const struct device *dev, int err, const char *fmt, ...); > > > > Generally, the __must_check should go before the return type > > and the extern isn't necessary and is also generally not used > > in device.h, so I'd prefer: > > > > __printf(3, 4) > > __must_check int dev_err_probe(...); > > I grepped the current code... I don't see support of your preference. > Maybe I missed something? (I'm talking about include/*) Hey Andy. The __must_check location is just personal belief as it makes grep significantly easier type function(args...) is a much easier grep pattern than type function(args...) extern function declarations are generally unnecessary and should be avoided. cheers, Joe