From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31E4DC43381 for ; Fri, 15 Mar 2019 13:29:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0C44E20854 for ; Fri, 15 Mar 2019 13:29:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728947AbfCON32 (ORCPT ); Fri, 15 Mar 2019 09:29:28 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:36534 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727370AbfCON31 (ORCPT ); Fri, 15 Mar 2019 09:29:27 -0400 Received: from pps.filterd (m0098414.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x2FDNXIl042882 for ; Fri, 15 Mar 2019 09:29:26 -0400 Received: from e06smtp05.uk.ibm.com (e06smtp05.uk.ibm.com [195.75.94.101]) by mx0b-001b2d01.pphosted.com with ESMTP id 2r8brdmg83-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 15 Mar 2019 09:29:25 -0400 Received: from localhost by e06smtp05.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 15 Mar 2019 13:29:23 -0000 Received: from b06cxnps3075.portsmouth.uk.ibm.com (9.149.109.195) by e06smtp05.uk.ibm.com (192.168.101.135) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Fri, 15 Mar 2019 13:29:21 -0000 Received: from d06av26.portsmouth.uk.ibm.com (d06av26.portsmouth.uk.ibm.com [9.149.105.62]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x2FDTKiJ62849066 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 15 Mar 2019 13:29:20 GMT Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 32F0EAE051; Fri, 15 Mar 2019 13:29:20 +0000 (GMT) Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9B151AE045; Fri, 15 Mar 2019 13:29:18 +0000 (GMT) Received: from [9.145.170.151] (unknown [9.145.170.151]) by d06av26.portsmouth.uk.ibm.com (Postfix) with ESMTP; Fri, 15 Mar 2019 13:29:18 +0000 (GMT) Reply-To: pmorel@linux.ibm.com Subject: Re: [PATCH v5 2/7] s390: ap: new vfio_ap_queue structure To: Cornelia Huck Cc: borntraeger@de.ibm.com, alex.williamson@redhat.com, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, kvm@vger.kernel.org, frankja@linux.ibm.com, akrowiak@linux.ibm.com, pasic@linux.ibm.com, david@redhat.com, schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com, freude@linux.ibm.com, mimu@linux.ibm.com References: <1552493104-30510-1-git-send-email-pmorel@linux.ibm.com> <1552493104-30510-3-git-send-email-pmorel@linux.ibm.com> <20190315113330.5ef0eeef.cohuck@redhat.com> From: Pierre Morel Date: Fri, 15 Mar 2019 14:29:18 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <20190315113330.5ef0eeef.cohuck@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 x-cbid: 19031513-0020-0000-0000-00000323B8A7 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19031513-0021-0000-0000-00002175C251 Message-Id: <97431ae5-8a96-2512-870b-0a463e9ec768@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-03-15_09:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=2 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1903150096 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15/03/2019 11:33, Cornelia Huck wrote: > On Wed, 13 Mar 2019 17:04:59 +0100 > Pierre Morel wrote: > >> diff --git a/drivers/s390/crypto/vfio_ap_drv.c b/drivers/s390/crypto/vfio_ap_drv.c >> index e9824c3..df6f21a 100644 >> --- a/drivers/s390/crypto/vfio_ap_drv.c >> +++ b/drivers/s390/crypto/vfio_ap_drv.c >> @@ -40,14 +40,42 @@ static struct ap_device_id ap_queue_ids[] = { >> >> MODULE_DEVICE_TABLE(vfio_ap, ap_queue_ids); >> >> +/** >> + * vfio_ap_queue_dev_probe: >> + * >> + * Allocate a vfio_ap_queue structure and associate it >> + * with the device as driver_data. >> + */ >> static int vfio_ap_queue_dev_probe(struct ap_device *apdev) >> { >> + struct vfio_ap_queue *q; >> + >> + q = kzalloc(sizeof(*q), GFP_KERNEL); >> + if (!q) >> + return -ENOMEM; >> + dev_set_drvdata(&apdev->device, q); >> + q->apqn = to_ap_queue(&apdev->device)->qid; >> + INIT_LIST_HEAD(&q->list); >> + mutex_lock(&matrix_dev->lock); >> + list_add(&q->list, &matrix_dev->free_list); >> + mutex_unlock(&matrix_dev->lock); > > From what I can see, dealing with the free_list is supposed to be > protected by the matrix_dev mutex, and at a glance, it indeed seems to > be held every time you interact with the list. I think it would be good > to document that with a comment. Yes. It is a big lock but only on administrative tasks so I think it is harmless. > > (I have not reviewed this deeply, and I won't be able to look at this > more until April, sorry.) OK. Thanks for the comments. Regards, Pierre -- Pierre Morel Linux/KVM/QEMU in Böblingen - Germany