From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Jayesh Choudhary <j-choudhary@ti.com>,
peda@axentia.se, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
s-vadapalli@ti.com
Subject: Re: [PATCH] dt-bindings: ti-serdes-mux: Add defines for SERDES4 in J784S4 SoC
Date: Tue, 11 Jul 2023 08:04:02 +0200 [thread overview]
Message-ID: <97436a92-2cbd-0498-8aad-444ac3fab99b@linaro.org> (raw)
In-Reply-To: <ecbb6d34-e024-f6c6-5921-ba7bc6fe2e5e@ti.com>
On 11/07/2023 07:55, Jayesh Choudhary wrote:
> Hello Krzysztof,
>
> On 10/07/23 17:11, Krzysztof Kozlowski wrote:
>> On 10/07/2023 12:27, Jayesh Choudhary wrote:
>>> SERDES4 has 4 lanes. Add lane definitions for it.
>>>
>>> Signed-off-by: Jayesh Choudhary <j-choudhary@ti.com>
>>> ---
>>> include/dt-bindings/mux/ti-serdes.h | 20 ++++++++++++++++++++
>>
>> Where are the users of this binding constants? IOW, why do you need to
>> add these?
>>
>> I don't see users of existing constants either...
>>
>
> These constants are propagated in the idle-state property for the
> mux-controller node (named serdes_ln_ctrl) usually in the final
> board dts files and occasionally in the main dtsi files for TI SoCs.
So they are not used. Do not add headers which are not used - neither to
the kernel sources, nor to the DTSI. The header constants don't even
look as suitable for bindings, although this is tricky to judge without
users.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-07-11 6:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-10 10:27 Jayesh Choudhary
2023-07-10 11:41 ` Krzysztof Kozlowski
2023-07-11 5:55 ` Jayesh Choudhary
2023-07-11 6:04 ` Krzysztof Kozlowski [this message]
2023-07-11 7:21 ` Jayesh Choudhary
2023-07-11 7:35 ` Krzysztof Kozlowski
2023-07-11 8:02 ` Jayesh Choudhary
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=97436a92-2cbd-0498-8aad-444ac3fab99b@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=j-choudhary@ti.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peda@axentia.se \
--cc=robh+dt@kernel.org \
--cc=s-vadapalli@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®