From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B11382DAFDA for ; Fri, 13 Mar 2026 12:07:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773403638; cv=none; b=IKurc6HZRYRYt8bNFN72th2gxDobs6IZs+4qic8fTaZWcnfVG5se8i/NV+LK4Tw+ubSX+vtM1qPc8YPJ0aONv7JZ4kvUt7/KU6ijL2c1KqzlMtRwrkwwsFPtFXjaThHhdvThDZZvLP2w0hNZeRbbIimYXZhi9lS3ZCBpstVu7hk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773403638; c=relaxed/simple; bh=WyGBrZEqneOMA36Rq97DAhfkG/b1VNMLozC8HuoKhOM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=oQ85YL04kNDSl9xnidpAWri1yA9tMno1OIbf/pJ56b9ayvCZkUs1VLl42qWNgzM7gkjp5RK4IiA1mlnzJs0a2MJoUxAZLBBtDC1+gu1LRJH2zXPREO4aN2sG/NCCvsEMTk2obDifVb69wBXWh7Pg2wZqmRX0KKDll2IZMWhPKNE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=m6zIYfOx; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="m6zIYfOx" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-485445e80bdso18211175e9.0 for ; Fri, 13 Mar 2026 05:07:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773403635; x=1774008435; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Qi4fWV4Vp6Y6RIKcKR3GE504LvU1lft8ajgS4e4DM4s=; b=m6zIYfOx3yTsNgqrqlmjtcPLbNHg3Ib3LMXpl1hy+sbUV9SvqJEdtcH0mEluk9KWJk pUJ5LKjXH2b4KsbsbzW2ADXPf3ImZ3m576MB6cm7cAcB3U2G/84vOrOQCxQJMqwyqnIO +IA4FW8UGAwzv48siqVBarpGCeGA7XOIPFmNDpKjJ0b59i6v4FCYHLsSIXgoCOoHExeC qCDtOBelUdarLsqT4B/mEdJYTr8Ej1ynr1bCaY41+wRfR9qwL8kqO9bkQJ68J/YYUhqA TzaUH2i4CyaDpcYiVcQYYxvMxOELjAOHKb2JhJ2tkQakLlYryTrIA/JMng8j2VDixXc2 bozQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773403635; x=1774008435; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Qi4fWV4Vp6Y6RIKcKR3GE504LvU1lft8ajgS4e4DM4s=; b=jFyxg58OM9pJHebvxNmA3u751w/Pv8JuIZZVHhKmlICZ8yUhLhsgnLhrau56gweFrf 3ACLe6i4ugCEMR4OzPQy9mnhkwtZ4Xd21GcKLQJP3huZoL7l3oRI0atPNZhbAutnB4FE QMzEDHgcRPSxtqNWj/8KOJNFwh1Qbh32qvXkQkcEI/PAnM8WXmVXE8IjSXyWBR4XDfyl FhRpNF7em541DwGdZKEpArMr15D+zru2oGX7s4IhGoKpduaDwmc/oqcavSq5YrRrrew3 jryA70S+VUpijJozsqJQlsdWkXtYnVUXG1EVFnyrWpNcbFQntBXVzTEZlfQPDSJxLJyx dzMg== X-Forwarded-Encrypted: i=1; AJvYcCVZzhsDQ+n9KPFCYDQU9+b+l4dRyno3Xu3/9WExcqWLdDJ/4d32PcHCbOBSf89xc9wn2FB2edQ85gIFO9k=@vger.kernel.org X-Gm-Message-State: AOJu0YzWSruK9gaOVXkfLqy4K09RoH36W2V+kSJdNa1UYc7DJ3d8yTS7 nw/MQRPIYhrbs42P6n7blDYX+pyJ8T6IZ7Hrb1PjyICYnSiUP81e7GfH X-Gm-Gg: ATEYQzwSmOojhBHS6/16zvCGeleYe8IdJfnOi6wjTx3+TEUpcPAIgdbSiWu+hXjK+rZ lzZJyp/gWYjRkc2DFUjpZbDSmf+Q79NiOmbxl7TTAvloqzrWaur85XtfPs1CkADA78fD/2xPswE U7Rw7s9hTRFCPtH5Zdzox6+NX/BZTmqrZEQm7r2t/Xsuns1u41MY6Xtwct65XynDUGJWNAzPfLK HsxvevFwL58a2UislH5rDHY1mKYU/NvIDrjz2X2z7t7mWQ5q0ArGV7WnpDJHfDQvh2x1MfjMoih F56Wv0CHcV2qDy8iC7SswscSTz8WOR4ckLtFWs4bccrJ5urbrZUwZ3v+64tEKtLSTN/XyRDzBdZ jdAxjcjKonm4Zsx58gBD+/OuQ0OQGFnPJVvzNff80w4YvR64s/qJQbieDQrD66lyv5XpxyYR3sa n5OGo/znKnAkquN5UnLEFd20qcf2a5FTgvhkRGmlkzKgc93SFfYKCNrdJOJABcymOQWN23HaKFH EwYxAeYcX+dOQ== X-Received: by 2002:a05:600c:1f8e:b0:485:3f58:da1 with SMTP id 5b1f17b1804b1-485566e936amr52710955e9.9.1773403634782; Fri, 13 Mar 2026 05:07:14 -0700 (PDT) Received: from [192.168.1.122] (cpc159313-cmbg20-2-0-cust161.5-4.cable.virginm.net. [82.0.78.162]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439fe226473sm15837450f8f.32.2026.03.13.05.07.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Mar 2026 05:07:14 -0700 (PDT) Message-ID: <9748039f-3bba-4420-8da9-7644022d1ffc@gmail.com> Date: Fri, 13 Mar 2026 12:07:13 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 05/10 net-next v2] drivers: net: drop ipv6_stub usage and use direct function calls To: Fernando Fernandez Mancera , netdev@vger.kernel.org Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , open list , "open list:SFC NETWORK DRIVER" References: <20260310153506.5181-1-fmancera@suse.de> <20260310153506.5181-6-fmancera@suse.de> Content-Language: en-GB From: Edward Cree In-Reply-To: <20260310153506.5181-6-fmancera@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 10/03/2026 15:34, Fernando Fernandez Mancera wrote: > As IPv6 is built-in only, the ipv6_stub infrastructure is no longer > necessary. > > Convert all drivers currently utilizing ipv6_stub to make direct > function calls. The fallback functions introduced previously will > prevent linkage errors when CONFIG_IPV6 is disabled. > > Signed-off-by: Fernando Fernandez Mancera ... > diff --git a/drivers/net/ethernet/sfc/tc_counters.c b/drivers/net/ethernet/sfc/tc_counters.c > index d168282f30bf..d8a5f9fd1007 100644 > --- a/drivers/net/ethernet/sfc/tc_counters.c > +++ b/drivers/net/ethernet/sfc/tc_counters.c > @@ -112,7 +112,7 @@ static void efx_tc_counter_work(struct work_struct *work) > encap->neigh->egdev); > else > #if IS_ENABLED(CONFIG_IPV6) > - n = neigh_lookup(ipv6_stub->nd_tbl, > + n = neigh_lookup(ipv6_get_nd_tbl(), > &encap->neigh->dst_ip6, > encap->neigh->egdev); > #else > diff --git a/drivers/net/ethernet/sfc/tc_encap_actions.c b/drivers/net/ethernet/sfc/tc_encap_actions.c > index da35705cc5e1..63d8f794b869 100644 > --- a/drivers/net/ethernet/sfc/tc_encap_actions.c > +++ b/drivers/net/ethernet/sfc/tc_encap_actions.c > @@ -149,8 +149,7 @@ static int efx_bind_neigh(struct efx_nic *efx, > #if IS_ENABLED(CONFIG_IPV6) > struct dst_entry *dst; > > - dst = ipv6_stub->ipv6_dst_lookup_flow(net, NULL, &flow6, > - NULL); > + dst = ip6_dst_lookup_flow(net, NULL, &flow6, NULL); > rc = PTR_ERR_OR_ZERO(dst); > if (rc) { > NL_SET_ERR_MSG_MOD(extack, "Failed to lookup route for IPv6 encap"); > @@ -531,7 +530,7 @@ static int efx_neigh_event(struct efx_nic *efx, struct neighbour *n) > if (n->tbl == &arp_tbl) { > keysize = sizeof(keys.dst_ip); > #if IS_ENABLED(CONFIG_IPV6) > - } else if (n->tbl == ipv6_stub->nd_tbl) { > + } else if (n->tbl == ipv6_get_nd_tbl()) { > ipv6 = true; > keysize = sizeof(keys.dst_ip6); > #endif # for sfc: Reviewed-by: Edward Cree