From: Jens Axboe <axboe@kernel.dk>
To: "Jiri Slaby (SUSE)" <jirislaby@kernel.org>, Tejun Heo <tj@kernel.org>
Cc: linux-kernel@vger.kernel.org, Martin Liska <mliska@suse.cz>,
Josef Bacik <josef@toxicpanda.com>,
cgroups@vger.kernel.org, linux-block@vger.kernel.org
Subject: Re: [PATCH v3] block/blk-iocost (gcc13): keep large values in a new enum
Date: Wed, 14 Dec 2022 09:56:48 -0700 [thread overview]
Message-ID: <974973f8-c703-59aa-5afe-40b33429fdbb@kernel.dk> (raw)
In-Reply-To: <20221213120826.17446-1-jirislaby@kernel.org>
On 12/13/22 5:08 AM, Jiri Slaby (SUSE) wrote:
> Since gcc13, each member of an enum has the same type as the enum [1]. And
> that is inherited from its members. Provided:
> VTIME_PER_SEC_SHIFT = 37,
> VTIME_PER_SEC = 1LLU << VTIME_PER_SEC_SHIFT,
> ...
> AUTOP_CYCLE_NSEC = 10LLU * NSEC_PER_SEC,
> the named type is unsigned long.
>
> This generates warnings with gcc-13:
> block/blk-iocost.c: In function 'ioc_weight_prfill':
> block/blk-iocost.c:3037:37: error: format '%u' expects argument of type 'unsigned int', but argument 4 has type 'long unsigned int'
>
> block/blk-iocost.c: In function 'ioc_weight_show':
> block/blk-iocost.c:3047:34: error: format '%u' expects argument of type 'unsigned int', but argument 3 has type 'long unsigned int'
>
> So split the anonumois enum with large values to a separate enum, so
anonymous?
--
Jens Axboe
next prev parent reply other threads:[~2022-12-14 16:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-13 12:08 Jiri Slaby (SUSE)
2022-12-14 16:56 ` Jens Axboe [this message]
2022-12-14 16:56 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=974973f8-c703-59aa-5afe-40b33429fdbb@kernel.dk \
--to=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=jirislaby@kernel.org \
--cc=josef@toxicpanda.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mliska@suse.cz \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®