mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Pavel Machek <pavel@ucw.cz>, Wilmer van der Gaast <wilmer@gaast.net>
Cc: bhelgaas@google.com, rafael.j.wysocki@intel.com,
	linux-kernel@vger.kernel.org
Subject: Re: Machine crashes right *after* ~successful resume
Date: Mon, 13 Oct 2014 17:06:35 +0200	[thread overview]
Message-ID: <9751497.0fL0kvsyX7@vostro.rjw.lan> (raw)
In-Reply-To: <20141012204032.GA11171@amd>

On Sunday, October 12, 2014 10:40:32 PM Pavel Machek wrote:
> Bjorn, any ideas?
> 
> Would it be feasible to revert 2e8b... to see if it fixes it on 3.17?

That's a merge, isn't it?

I'd rather check what the pci/misc branch was based on and then bisect that
branch.

If you do

$ git show fed2451

you'll see (among other things) that this indeed is the PCI branch merged
by that commit and that it is based on

3b2f64d00c46 Linux 3.11-rc2

So, you can do

$ git bisect 3b2f64d00c46..fed2451

and see which of the commits in there introduced the problem you're seeing.

Note: Test fed2451 itself *first* and if that is bad already, then the merge
itself was problematic, in which case please let me know.


> On Sun 2014-10-12 16:49:18, Wilmer van der Gaast wrote:
> > Hello,
> > 
> > Many thanks for your response!
> > 
> > On 12-10-14 15:30, Pavel Machek wrote:
> > >
> > >Has it ever worked ok? ...aha, in 3.10, ok.
> > >
> > Correct. And I've tried a few more kernels now, compiled on my own. 3.17
> > still has this issue, 3.10 is completely fine all the way up to 3.10.57
> > (I've tested just under 50 cycles last night). 3.11 I tried but it seems to
> > have other suspend-resume stability issues not present anymore in later
> > kernels, I've mostly not used those results.
> > 
> > git bisect: I've finally succeeded! I've tried automating it completely, but
> > sadly Gigabyte couldn't be bothered wiring up the motherboard to make the
> > watchdog work. :-(
> > 
> > The culprit appears to be this one: 2e8b5f621dbe29425906852c6079afb6b28720cb
> > 
> > Merge: 07f2daa fed2451
> > Author: Bjorn Helgaas <bhelgaas@google.com>
> > Date:   Wed Aug 28 20:55:41 2013 -0600
> > 
> >     Merge branch 'pci/misc' into next
> > 
> >     * pci/misc:
> >       PCI: Remove pcie_cap_has_devctl()
> >       PCI: Support PCIe Capability Slot registers only for ports with slots
> >       PCI: Remove PCIe Capability version checks
> >       PCI: Allow PCIe Capability link-related register access for switches
> >       PCI: Add offsets of PCIe capability registers
> >       PCI: Tidy bitmasks and spacing of PCIe capability definitions
> >       PCI: Remove obsolete comment reference to pci_pcie_cap2()
> >       PCI: Clarify PCI_EXP_TYPE_PCI_BRIDGE comment
> >       PCI: Rename PCIe capability definitions to follow convention
> >       PCI: Disable decoding for BAR sizing only when it was actually enabled
> >       PCI: Add comment about needing pci_msi_off() even when
> > CONFIG_PCI_MSI=n
> >       PCI: Add pcibios_pm_ops for optional arch-specific hibernate
> > functionality
> > 
> > I've then tried to narrow down which of the merged changes is my issue but
> > with no luck, possibly because there's a problem with a combination of one
> > of these changes, and a change that was not in the pci/misc branch at the
> > time. I could do a manual test instead.
> > 
> > >>I've already tried to skip the NVidia + VMware modules at boot time (as you
> > >>can see from the logs they're not loaded at any point), but it didn't help.
> > >>I could try omitting more modules.
> > >Yes, try with minimal modules (and no s2ram) would be nice.
> > >									
> > I've tried unloading a bunch of modules (sound and NIC IIRC), same results.
> > I can try this again with an even more minimal set. If this improves the
> > situation, I'll post again.
> > 
> > 
> > Wilmer van der Gaast.
> > 
> 
> 

-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.

  parent reply	other threads:[~2014-10-13 14:46 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-07 23:20 Wilmer van der Gaast
2014-10-12 14:30 ` Pavel Machek
2014-10-12 15:49   ` Wilmer van der Gaast
2014-10-12 20:40     ` Pavel Machek
2014-10-12 23:47       ` Wilmer van der Gaast
2014-10-13 15:06       ` Rafael J. Wysocki [this message]
2014-10-15 11:16         ` Wilmer van der Gaast
2014-10-15 13:58           ` Bjorn Helgaas
2014-10-15 18:39             ` Yinghai Lu
2014-10-15 23:34               ` Wilmer van der Gaast
2014-10-16  4:32                 ` Yinghai Lu
2014-10-16  9:36                   ` Wilmer van der Gaast
2014-10-16 16:36                     ` Yinghai Lu
2014-10-16 21:08                       ` Wilmer van der Gaast
2014-10-18 21:28                         ` Yinghai Lu
2014-10-18 23:57                           ` Wilmer van der Gaast
2014-10-19  4:29                             ` Yinghai Lu
2014-10-19 10:48                               ` Wilmer van der Gaast
2014-10-21 21:40                               ` Wilmer van der Gaast
2014-10-21 23:15                                 ` Yinghai Lu
2014-10-22 12:53                                   ` Wilmer van der Gaast
2014-10-26 21:53                                     ` Yinghai Lu
2014-10-27 10:50                                       ` Wilmer van der Gaast
2014-10-27 18:23                                         ` Yinghai Lu
2014-10-27 22:22                                           ` Wilmer van der Gaast
2014-10-27 23:41                                             ` Yinghai Lu
2014-10-28  0:03                                               ` Wilmer van der Gaast
2014-10-28  1:12                                                 ` Yinghai Lu
2014-10-28  4:03                                                   ` Yinghai Lu
2014-10-28 10:23                                                     ` Wilmer van der Gaast
2014-10-28 23:34                                                   ` Wilmer van der Gaast
2014-10-29  5:17                                                     ` Yinghai Lu
2014-10-29  9:37                                                       ` Wilmer van der Gaast
2014-10-30  0:53                                                         ` Yinghai Lu
2014-10-30 10:36                                                           ` Wilmer van der Gaast
2014-10-30 16:57                                                             ` Yinghai Lu
2014-10-30 21:54                                                               ` Wilmer van der Gaast
2014-10-30 23:02                                                                 ` Yinghai Lu
2014-10-30 23:24                                                                   ` Wilmer van der Gaast
2014-10-31  0:43                                                                     ` Yinghai Lu
2014-10-31  2:13                                                                       ` Yinghai Lu
2014-10-31  9:39                                                                         ` Wilmer van der Gaast
2014-10-31 16:11                                                                           ` Yinghai Lu
2014-10-31 21:13                                                                             ` Wilmer van der Gaast
2014-10-31 21:22                                                                               ` Yinghai Lu
2014-10-31 23:18                                                                                 ` Yinghai Lu
2014-11-01  0:00                                                                                   ` Wilmer van der Gaast
2014-11-01  2:10                                                                                     ` Yinghai Lu
2014-11-02 23:16                                                                                       ` Wilmer van der Gaast
2014-10-27 21:21                                         ` Pavel Machek
2014-10-19  8:07                             ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9751497.0fL0kvsyX7@vostro.rjw.lan \
    --to=rjw@rjwysocki.net \
    --cc=bhelgaas@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=rafael.j.wysocki@intel.com \
    --cc=wilmer@gaast.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®