From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D683C65C20 for ; Mon, 8 Oct 2018 20:06:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 84E7520C0A for ; Mon, 8 Oct 2018 20:06:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 84E7520C0A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727028AbeJIDUD (ORCPT ); Mon, 8 Oct 2018 23:20:03 -0400 Received: from mailout.easymail.ca ([64.68.200.34]:45063 "EHLO mailout.easymail.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726468AbeJIDUC (ORCPT ); Mon, 8 Oct 2018 23:20:02 -0400 Received: from localhost (localhost [127.0.0.1]) by mailout.easymail.ca (Postfix) with ESMTP id 071F241C54; Mon, 8 Oct 2018 20:06:35 +0000 (UTC) Received: from mailout.easymail.ca ([127.0.0.1]) by localhost (emo03-pco.easydns.vpn [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fDyvvFnXitu5; Mon, 8 Oct 2018 20:06:35 +0000 (UTC) Received: from [192.168.1.87] (c-24-9-64-241.hsd1.co.comcast.net [24.9.64.241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mailout.easymail.ca (Postfix) with ESMTPSA id C6BF442BB0; Mon, 8 Oct 2018 20:06:24 +0000 (UTC) Subject: Re: [PATCH] usbip: vhci_hcd: check port number before using To: Sudip Mukherjee Cc: Valentina Manea , Greg Kroah-Hartman , linux-kernel , linux-usb@vger.kernel.org, syzbot+600b03e0cf1b73bb23c4@syzkaller.appspotmail.com, Stable , Shuah Khan References: <20181008191913.11527-1-sudip.mukherjee@codethink.co.uk> From: Shuah Khan Message-ID: <97565b6e-025a-520e-d1c9-8f47b1934153@kernel.org> Date: Mon, 8 Oct 2018 14:06:23 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/08/2018 02:01 PM, Sudip Mukherjee wrote: > On Mon, Oct 8, 2018 at 8:29 PM Shuah Khan wrote: >> >> Hi Sudip, >> >> On 10/08/2018 01:19 PM, Sudip Mukherjee wrote: >>> From: Sudip Mukherjee >>> >>> The port number is checked and it just prints an error message but it >>> still continues to use the invalid port. And as a result it accesses >>> memory which is not its resulting in BUG report from KASAN. >> >> Yes there is an issue with out of bounds access. But this isn't the >> right fix. >> >>> >>> Reported-by: syzbot+600b03e0cf1b73bb23c4@syzkaller.appspotmail.com >>> Cc: stable >>> Signed-off-by: Sudip Mukherjee >> >> I sent in a fix for this last Friday. >> >> https://patchwork.kernel.org/patch/10628833/ > > And I can confirm this patch also fixes the issue tested with the > reproducer I was using in my vm. > > Great Thanks for testing the patch. thanks, -- Shuah